From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#44850: 27.1; Emacs crash in font handling with font-backend ns Date: Sun, 29 Nov 2020 10:45:24 +0100 Message-ID: <87zh30ijij.fsf@gnus.org> References: <9ACDC4D8-9B89-4EC7-BF98-F5E7155CCBA7@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1411"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 44850@debbugs.gnu.org, pieter-l@vanoostrum.org, pieter@vanoostrum.org, Alan Third To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 29 10:46:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kjJHV-0000Fo-M1 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Nov 2020 10:46:09 +0100 Original-Received: from localhost ([::1]:33656 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kjJHU-0001Ix-OQ for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Nov 2020 04:46:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39084) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjJHO-0001I8-Cz for bug-gnu-emacs@gnu.org; Sun, 29 Nov 2020 04:46:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38168) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kjJHO-0006g1-4m for bug-gnu-emacs@gnu.org; Sun, 29 Nov 2020 04:46:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kjJHO-0006DU-17 for bug-gnu-emacs@gnu.org; Sun, 29 Nov 2020 04:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Nov 2020 09:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44850 X-GNU-PR-Package: emacs Original-Received: via spool by 44850-submit@debbugs.gnu.org id=B44850.160664314623874 (code B ref 44850); Sun, 29 Nov 2020 09:46:01 +0000 Original-Received: (at 44850) by debbugs.gnu.org; 29 Nov 2020 09:45:46 +0000 Original-Received: from localhost ([127.0.0.1]:49714 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjJH7-0006Cz-Rl for submit@debbugs.gnu.org; Sun, 29 Nov 2020 04:45:46 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:51444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjJH3-0006Cj-64 for 44850@debbugs.gnu.org; Sun, 29 Nov 2020 04:45:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=BTKQFIzcLA1KLsbEBF2Mz9Qoz2b3RPJXnSB/G/74Ips=; b=X6EoqcBmtWogiHF3UiYWpqaE2B V0J3aDaV9qbazH8iNHfCPGQ7RZOxwVqBm0ApuyGMtfm7VG782lH3GK8TeguE40Yry5yNAQ5AVO882 lEQukOFbeEf6GsH0uwsYBezHHd4V+37UA06ItVm/LrwlLsDa40c+LwIrHI1W8MpHapC8=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kjJGn-00046r-Sw; Sun, 29 Nov 2020 10:45:31 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEWYX16GWlrXyL7/ //9u4OxpAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+QLHQkrEYezq3MAAAGGSURBVCjPPZHBattAEIZn hRWoTq6Ie/ApFAphnkIJOfkkjMYUnXps9RSycUrYUxHJxaeVcMzqf8rOyEoEy+ynf/bfnRkiopWU jn4yoHtKpSLa4APKwv2awUn65H6oRAU5J9vzohWFilwh3C/om8JXSssaozp4hQeRBuPScQZalkth jAXFLcinRAZJuAUhFApxwW0KindPB31JDrcxKFSAfynZIPO4NBr0npgioFsHoG8ofGnAr2sg0obC /QaH56YDpTWFZI3Qc76XiomyDuCXf2QGlF2sLI+pOH4HzsdE9xe64xF4/n1ok9NAAyIjfcwPf7sT 6W3Ze0FAWNUUAR/shBmArxs/wfzFP67+BIyioIcw6NqLpsXBwOe4MYiDisPRpjClmYHjq1vQpkep QI39TeD9SrtTGyzhu7Oe2QJHLd+/2gt2Wg3axL/ZsHRGe27Zv+0M1OE72LeWJipf5ueRbCe4NkR2 FthP9Yg6oOfTVTGHPa9nUIf+vp5hih/K5JDPUFm0O/EfFb0JCzV+bpUAAAAldEVYdGRhdGU6Y3Jl YXRlADIwMjAtMTEtMjlUMDk6NDM6MTcrMDA6MDBiKL+MAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIw LTExLTI5VDA5OjQzOjE3KzAwOjAwE3UHMAAAAABJRU5ErkJggg== X-Now-Playing: Saxon Lee & The Shadows International's _Nigeria 70 (No Wahala: Highlife, Afro-Funk & Juju 1973-1987)_: "Special Secret Of Baby" In-Reply-To: <9ACDC4D8-9B89-4EC7-BF98-F5E7155CCBA7@acm.org> ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Fri, 27 Nov 2020 18:16:48 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194529 Archived-At: Mattias Engdeg=C3=A5rd writes: > Yes, the restriction is a bit odd but perhaps there was a good > reason. For this application, however, we could just switch from > esprintf to sprintf in nsterm.m. (The stated reason for using esprintf > was in case the string is longer than 2 GiB but I think we would have > bigger problems if a frame title ever becomes that long.) > > OK for master? (Also fixed the unsightly 'x' while at it) Like Eli says, this really should be fixed in doprint.c. However, since this is a crash that makes Emacs unusable, and since (as you point out) sprintf is unproblematic here, I'm fine with applying the patch. Perhaps with a FIXME comment about how this should your esprintf once doprintf has been fixed. --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no