From: Lars Ingebrigtsen <larsi@gnus.org>
To: Matt Armstrong <matt@rfc20.org>
Cc: 47572@debbugs.gnu.org
Subject: bug#47572: 27.1; (setf (map-elt m key) value) should return value but does not
Date: Thu, 06 May 2021 13:31:42 +0200 [thread overview]
Message-ID: <87zgx8umht.fsf@gnus.org> (raw)
In-Reply-To: <87eefsfl8f.fsf@rfc20.org> (Matt Armstrong's message of "Fri, 02 Apr 2021 14:08:16 -0700")
Matt Armstrong <matt@rfc20.org> writes:
> Attached is an ert test that demonstrates the problem. The crux is
> that:
>
> (require 'map)
> (setf (map-elt m key) value)
>
> returns VALUE only in the hash table implementation. `setf' should
> return VALUE in all cases.
>
> For alists it returns either nil or (key . value) depending on whether a
> key is inserted or udpated in place. For plists it returns similarly
> variable things.
Thanks; I've included your tests in Emacs 28, and fixed the map-elt code
(hopefully; it passes all the tests, at least).
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2021-05-06 11:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 21:08 bug#47572: 27.1; (setf (map-elt m key) value) should return value but does not Matt Armstrong
2021-04-04 18:31 ` Basil L. Contovounesios
2021-05-06 11:31 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgx8umht.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=47572@debbugs.gnu.org \
--cc=matt@rfc20.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).