From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#47572: 27.1; (setf (map-elt m key) value) should return value but does not Date: Thu, 06 May 2021 13:31:42 +0200 Message-ID: <87zgx8umht.fsf@gnus.org> References: <87eefsfl8f.fsf@rfc20.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3960"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 47572@debbugs.gnu.org To: Matt Armstrong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 06 13:32:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lecEn-0000rW-4R for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 May 2021 13:32:13 +0200 Original-Received: from localhost ([::1]:51528 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lecEm-00030i-4y for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 May 2021 07:32:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46866) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lecEd-0002z2-0S for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 07:32:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54117) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lecEc-0000AG-Gr for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 07:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lecEc-0000q6-DQ for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 07:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 May 2021 11:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47572 X-GNU-PR-Package: emacs Original-Received: via spool by 47572-submit@debbugs.gnu.org id=B47572.16203007152877 (code B ref 47572); Thu, 06 May 2021 11:32:02 +0000 Original-Received: (at 47572) by debbugs.gnu.org; 6 May 2021 11:31:55 +0000 Original-Received: from localhost ([127.0.0.1]:37427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lecEV-0000k7-7B for submit@debbugs.gnu.org; Thu, 06 May 2021 07:31:55 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:47580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lecER-0000dR-PL for 47572@debbugs.gnu.org; Thu, 06 May 2021 07:31:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=dGgXXDCao93Fuf+YtMwDmQFMl9F5WRI6pEjMYbKRJ/I=; b=l2A6/3WcxwqqvgdsQvIFBsO6Ku SWywiM6Pp8us8YdgOboLO2UJSpYsqtsfczDg8pomO07hwi6Wb28Q2z4e8n67+zyW+e8KfXo0/tNNf IYcNL8jit9UrPYfCpHhiNDnYZlmCjvzgFzfkmkwkR8T93VIxjuXksxKcspd0TPdZ4rng=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lecEI-0006k1-Up; Thu, 06 May 2021 13:31:45 +0200 X-Now-Playing: Bark Psychosis's _Manman_: "Tooled Up" In-Reply-To: <87eefsfl8f.fsf@rfc20.org> (Matt Armstrong's message of "Fri, 02 Apr 2021 14:08:16 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205824 Archived-At: Matt Armstrong writes: > Attached is an ert test that demonstrates the problem. The crux is > that: > > (require 'map) > (setf (map-elt m key) value) > > returns VALUE only in the hash table implementation. `setf' should > return VALUE in all cases. > > For alists it returns either nil or (key . value) depending on whether a > key is inserted or udpated in place. For plists it returns similarly > variable things. Thanks; I've included your tests in Emacs 28, and fixed the map-elt code (hopefully; it passes all the tests, at least). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no