From: Augusto Stoffel <arstoffel@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 50459@debbugs.gnu.org, Gregory Heytings <gregory@heytings.org>,
Michael Albinus <michael.albinus@gmx.de>,
joaotavora@gmail.com
Subject: bug#50459: 28.0.50; Python shell completion is incompatible with flex, orderless, etc.
Date: Fri, 10 Sep 2021 13:50:33 +0200 [thread overview]
Message-ID: <87zgskejjq.fsf@gmail.com> (raw)
In-Reply-To: <877dfopsoa.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 10 Sep 2021 13:37:57 +0200")
On Fri, 10 Sep 2021 at 13:37, Lars Ingebrigtsen <larsi@gnus.org> wrote:
> Augusto Stoffel <arstoffel@gmail.com> writes:
>
>> To alleviate this, the completion-at-point function could implement some
>> sort of caching. The difficult question is when to invalidate the
>> cache. I've attached one possiblility as a draft patch. If the
>> approach seems reasonable, then I'll format it properly.
>
> Would it be possible to do caching at a lower level instead of in
> python-mode?
I'm not an expert in this either, but I think the caching mechanism
would be pretty particular to the circumstances of each completion
table, so it indeed belongs here. Maybe João can say more?
Since this comint-based completion is not super smart (it's not
context-dependent at all), the rather naive caching invalidation used
here seems sufficient to me.
>
>> As a side effect, the patch also solves the original issue described in
>> this ticket.
>
> [...]
>
>> - (list start end
>> - (completion-table-dynamic
>> - (apply-partially
>> - completion-fn
>> - process import-statement)))))
>> + (let ((re (or (car python-shell--capf-cache) regexp-unmatchable))
>> + (prefix (buffer-substring-no-properties start end)))
>> + (unless (string-match re prefix)
>> + (setq python-shell--capf-cache
>> + (cons (concat "\\`" (regexp-quote prefix)
>> "\\(?:\\sw\\|\\s_\\)*\\'")
>> + (funcall completion-fn process import-statement prefix)))))
>> + (list start end (cdr python-shell--capf-cache))))
>
> I'm not sure I understand this patch -- it's not using
> `completion-table-dynamic' at all now? (But my understanding of the
> completion functions in Emacs is pretty lacking.)
That's true: the logic here is that the completions are computed
eagerly, and then cached until still valid. So if you type
fo<tab>o.bar.baz
the inferior process is contacted 3 times: after the <tab>, and after
each dot. Before, a lazy table was returned, but the inferior would be
contacted after each character anyway (if using Company or similar).
next prev parent reply other threads:[~2021-09-10 11:50 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 17:52 bug#50459: 28.0.50; Python shell completion is incompatible with flex, orderless, etc Augusto Stoffel
2021-09-08 17:44 ` Augusto Stoffel
2021-09-09 7:11 ` Michael Albinus
2021-09-09 7:32 ` Gregory Heytings
2021-09-09 7:30 ` Gregory Heytings
2021-09-09 7:40 ` Augusto Stoffel
2021-09-09 7:49 ` Gregory Heytings
2021-09-09 8:45 ` Augusto Stoffel
2021-09-09 8:50 ` Gregory Heytings
2021-09-09 16:46 ` Augusto Stoffel
2021-09-10 11:37 ` Lars Ingebrigtsen
2021-09-10 11:50 ` Augusto Stoffel [this message]
2021-09-10 13:14 ` João Távora
2021-09-10 13:28 ` Dmitry Gutov
2021-09-10 14:06 ` João Távora
2021-09-10 14:22 ` Dmitry Gutov
2021-09-10 14:39 ` João Távora
2021-09-10 14:43 ` Dmitry Gutov
2021-09-10 19:27 ` Augusto Stoffel
2021-09-10 20:08 ` João Távora
2021-09-11 12:09 ` Lars Ingebrigtsen
2021-09-11 12:34 ` Augusto Stoffel
2021-09-11 12:36 ` Lars Ingebrigtsen
2021-09-10 13:32 ` Dmitry Gutov
2021-09-10 19:08 ` bug#50459: 28.0.50; [PATCH] " Augusto Stoffel
2021-09-11 12:50 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgskejjq.fsf@gmail.com \
--to=arstoffel@gmail.com \
--cc=50459@debbugs.gnu.org \
--cc=gregory@heytings.org \
--cc=joaotavora@gmail.com \
--cc=larsi@gnus.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).