unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Augusto Stoffel <arstoffel@gmail.com>, 50459@debbugs.gnu.org
Cc: Gregory Heytings <gregory@heytings.org>,
	Michael Albinus <michael.albinus@gmx.de>
Subject: bug#50459: 28.0.50; Python shell completion is incompatible with flex, orderless, etc.
Date: Fri, 10 Sep 2021 16:32:52 +0300	[thread overview]
Message-ID: <86069c89-f058-a1d3-5600-dd1453551c39@yandex.ru> (raw)
In-Reply-To: <87mtolr91a.fsf@gmail.com>

On 09.09.2021 19:46, Augusto Stoffel wrote:
> To alleviate this, the completion-at-point function could implement some
> sort of caching.  The difficult question is when to invalidate the
> cache.  I've attached one possiblility as a draft patch.  If the
> approach seems reasonable, then I'll format it properly.

It's much simpler than what we talked about, but given that 
python-shell-completion-at-point doesn't really look past the current 
line, your approach should work fine.

I'm not very familiar with the code, so I cannot approve the exact 
patch, though, sorry.

As a bonus, though, maybe add the position of prompt on the shell-buffer 
to the invalidation key? Like, if a user imports some new lib in there, 
that can bring in new completions.





  parent reply	other threads:[~2021-09-10 13:32 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-07 17:52 bug#50459: 28.0.50; Python shell completion is incompatible with flex, orderless, etc Augusto Stoffel
2021-09-08 17:44 ` Augusto Stoffel
2021-09-09  7:11   ` Michael Albinus
2021-09-09  7:32     ` Gregory Heytings
2021-09-09  7:30 ` Gregory Heytings
2021-09-09  7:40   ` Augusto Stoffel
2021-09-09  7:49     ` Gregory Heytings
2021-09-09  8:45       ` Augusto Stoffel
2021-09-09  8:50         ` Gregory Heytings
2021-09-09 16:46           ` Augusto Stoffel
2021-09-10 11:37             ` Lars Ingebrigtsen
2021-09-10 11:50               ` Augusto Stoffel
2021-09-10 13:14                 ` João Távora
2021-09-10 13:28                   ` Dmitry Gutov
2021-09-10 14:06                     ` João Távora
2021-09-10 14:22                       ` Dmitry Gutov
2021-09-10 14:39                         ` João Távora
2021-09-10 14:43                           ` Dmitry Gutov
2021-09-10 19:27                             ` Augusto Stoffel
2021-09-10 20:08                               ` João Távora
2021-09-11 12:09                 ` Lars Ingebrigtsen
2021-09-11 12:34                   ` Augusto Stoffel
2021-09-11 12:36                     ` Lars Ingebrigtsen
2021-09-10 13:32             ` Dmitry Gutov [this message]
2021-09-10 19:08 ` bug#50459: 28.0.50; [PATCH] " Augusto Stoffel
2021-09-11 12:50   ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86069c89-f058-a1d3-5600-dd1453551c39@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=50459@debbugs.gnu.org \
    --cc=arstoffel@gmail.com \
    --cc=gregory@heytings.org \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).