bug#66040: 30.0.50; The XF86AudioLowerVolume on keyboard cannot be detected correctly

bug#66040: 30.0.50; The XF86AudioLowerVolume on keyboard cannot be detected correctly

[Wang, Zhenhua (MU-Student)]

[-- Attachment #1: Type: text/plain, Size: 4373 bytes --]

The most recent version of Emacs doesn't recognize the XF86AudioLowerVolume key. I use "C-h k" to check this in "emacs -Q". When I press XF86AudioLowerVolume once, no information is displayed. However, If I press XF86AudioLowerVolume twice, "C-h k" indicates that I pressed "C-g".

I believe that this behavior is introduced in emacs-30, because this key works fine in the released emacs 29.1.

To reproduce, simply press the XF86AudioLowerVolume key  in "emacs -Q".



In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.38, cairo version 1.17.8) of 2023-09-16 built on XPS13
Repository revision: 41a45373c1b7f19b06b3666a359331a40e494313
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101008
System Description: Arch Linux

Configured using:
 'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib
 --localstatedir=/var --mandir=/usr/share/man --with-gameuser=:games
 --with-modules --without-libotf --without-m17n-flt --without-gconf
 --with-native-compilation=yes --with-xinput2 --with-x-toolkit=gtk3
 --without-xaw3d --with-sound=no --with-tree-sitter --without-gpm
 --without-compress-install
 '--program-transform-name=s/\([ec]tags\)/\1.emacs/'
 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions
 -Wp,-D_FORTIFY_SOURCE=2 -Wformat -Werror=format-security
 -fstack-clash-protection -fcf-protection'
 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON
LCMS2 LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG
RSVG SECCOMP SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP
X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=fcitx
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  minibuffer-regexp-mode: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny dired
dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068
epg-config gnus-util mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util mail-prsvr mail-utils compile text-property-search comint
ansi-osc ansi-color ring two-column comp comp-cstr warnings icons rx
cl-seq cl-macs gv cl-extra help-mode bytecomp byte-compile time-date
subr-x cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren
electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset
image regexp-opt fringe tabulated-list replace newcomment text-mode
lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch
easymenu timer select scroll-bar mouse jit-lock font-lock syntax
font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting cairo gtk
x-toolkit xinput2 x multi-tty move-toolbar make-network-process
native-compile emacs)

Memory information:
((conses 16 90265 13111) (symbols 48 7881 0) (strings 32 21523 2285)
 (string-bytes 1 673898) (vectors 16 17505)
 (vector-slots 8 350126 11291) (floats 8 44 47) (intervals 56 300 0)
 (buffers 992 13))

[-- Attachment #2: Type: text/html, Size: 19915 bytes --]

bug#66040: 30.0.50; The XF86AudioLowerVolume on keyboard cannot be detected correctly

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

"Wang, Zhenhua (MU-Student)" <zhenhua.wang@mail.missouri.edu> writes:

> The most recent version of Emacs doesn't recognize the
> XF86AudioLowerVolume key. I use "C-h k" to check this in "emacs
> -Q". When I press XF86AudioLowerVolume once, no information is
> displayed. However, If I press XF86AudioLowerVolume twice, "C-h k"
> indicates that I pressed "C-g".
>
> I believe that this behavior is introduced in emacs-30, because this
> key works fine in the released emacs 29.1.
>
> To reproduce, simply press the XF86AudioLowerVolume key in "emacs -Q".

Set x-quit-keysym to nil in your early-init.el, then restart Emacs.
This feature (reinterpreting volume-down keys as quit) was introduced in
Emacs 30 to support computers without physical input devices capable of
typing `C-g'.

Incidentally, what keyboard are you using?  XF86AudioLowerVolume is not
generated by any I own, and x-quit-keysym is intended to only apply to
volume rocker buttons on mobile phones and their ilk.

bug#66040: 30.0.50; The XF86AudioLowerVolume on keyboard cannot be detected correctly

[Stefan Kangas]

Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text
editors" <bug-gnu-emacs@gnu.org> writes:

> Set x-quit-keysym to nil in your early-init.el, then restart Emacs.
> This feature (reinterpreting volume-down keys as quit) was introduced in
> Emacs 30 to support computers without physical input devices capable of
> typing `C-g'.

That refers to Android phones, right?

> Incidentally, what keyboard are you using?  XF86AudioLowerVolume is not
> generated by any I own, and x-quit-keysym is intended to only apply to
> volume rocker buttons on mobile phones and their ilk.

Such keys are fairly common on standard keyboards, or at least used to
be.  There is usually an extra "function key row" with a "volume down"
key that generates XF86AudioLowerVolume.  I have one of those keyboards
lying around.

Is there a way to support this on mobile phones without this key
breaking on machines with regular keyboards?

bug#66040: 30.0.50; The XF86AudioLowerVolume on keyboard cannot be detected correctly

[Wang, Zhenhua (MU-Student)]

[-- Attachment #1: Type: text/plain, Size: 2266 bytes --]

> Set x-quit-keysym to nil in your early-init.el, then restart Emacs.
> This feature (reinterpreting volume-down keys as quit) was introduced in
> Emacs 30 to support computers without physical input devices capable of
> typing `C-g'.

Thank you, this does solve the problem.

> Incidentally, what keyboard are you using?

> Such keys are fairly common on standard keyboards, or at least used to
> be.  There is usually an extra "function key row" with a "volume down"
> key that generates XF86AudioLowerVolume.  I have one of those keyboards
> lying around.

In my case, it's the keyboard on my laptop, and these multimedia keys are quite common for laptop keyboards.
________________________________
From: Stefan Kangas <stefankangas@gmail.com>
Sent: Monday, September 18, 2023 2:52 AM
To: Po Lu <luangruo@yahoo.com>; Wang, Zhenhua (MU-Student) <zhenhua.wang@mail.missouri.edu>
Cc: 66040@debbugs.gnu.org <66040@debbugs.gnu.org>
Subject: Re: bug#66040: 30.0.50; The XF86AudioLowerVolume on keyboard cannot be detected correctly

WARNING: This message has originated from an External Source. This may be a phishing expedition that can result in unauthorized access to our IT System. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email.

Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text
editors" <bug-gnu-emacs@gnu.org> writes:

> Set x-quit-keysym to nil in your early-init.el, then restart Emacs.
> This feature (reinterpreting volume-down keys as quit) was introduced in
> Emacs 30 to support computers without physical input devices capable of
> typing `C-g'.

That refers to Android phones, right?

> Incidentally, what keyboard are you using?  XF86AudioLowerVolume is not
> generated by any I own, and x-quit-keysym is intended to only apply to
> volume rocker buttons on mobile phones and their ilk.

Such keys are fairly common on standard keyboards, or at least used to
be.  There is usually an extra "function key row" with a "volume down"
key that generates XF86AudioLowerVolume.  I have one of those keyboards
lying around.

Is there a way to support this on mobile phones without this key
breaking on machines with regular keyboards?

[-- Attachment #2: Type: text/html, Size: 3871 bytes --]

bug#66040: 30.0.50; The XF86AudioLowerVolume on keyboard cannot be detected correctly

[Eli Zaretskii]

> Cc: 66040@debbugs.gnu.org
> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Mon, 18 Sep 2023 00:52:16 -0700
> 
> Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text
> editors" <bug-gnu-emacs@gnu.org> writes:
> 
> > Set x-quit-keysym to nil in your early-init.el, then restart Emacs.
> > This feature (reinterpreting volume-down keys as quit) was introduced in
> > Emacs 30 to support computers without physical input devices capable of
> > typing `C-g'.
> 
> That refers to Android phones, right?
> 
> > Incidentally, what keyboard are you using?  XF86AudioLowerVolume is not
> > generated by any I own, and x-quit-keysym is intended to only apply to
> > volume rocker buttons on mobile phones and their ilk.
> 
> Such keys are fairly common on standard keyboards, or at least used to
> be.  There is usually an extra "function key row" with a "volume down"
> key that generates XF86AudioLowerVolume.  I have one of those keyboards
> lying around.
> 
> Is there a way to support this on mobile phones without this key
> breaking on machines with regular keyboards?

That'd be definitely preferable if possible.

If it isn't possible to have an Android-specific binding, I think we
should make the Android-specific binding in android-win.el or
somesuch, and leave the default as it is appropriate for laptops and
desktop systems.

bug#66040: 30.0.50; The XF86AudioLowerVolume on keyboard cannot be detected correctly

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Stefan Kangas <stefankangas@gmail.com> writes:

> Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text
> editors" <bug-gnu-emacs@gnu.org> writes:
>
>> Set x-quit-keysym to nil in your early-init.el, then restart Emacs.
>> This feature (reinterpreting volume-down keys as quit) was introduced in
>> Emacs 30 to support computers without physical input devices capable of
>> typing `C-g'.
>
> That refers to Android phones, right?

GNU/Linux phones, too.  We can't support features on Android that are
absent on free systems.

> Such keys are fairly common on standard keyboards, or at least used to
> be.  There is usually an extra "function key row" with a "volume down"
> key that generates XF86AudioLowerVolume.  I have one of those keyboards
> lying around.
>
> Is there a way to support this on mobile phones without this key
> breaking on machines with regular keyboards?

No idea.  But I've yet to encounter such a phone in practice, so I have
no objection to defaulting x-quit-keysym to nil, if they are indeed left
ungrabbed by window managers on ordinary computers.

bug#66040: 30.0.50; The XF86AudioLowerVolume on keyboard cannot be detected correctly

[Stefan Kangas]

Po Lu <luangruo@yahoo.com> writes:

>> Such keys are fairly common on standard keyboards, or at least used to
>> be.  There is usually an extra "function key row" with a "volume down"
>> key that generates XF86AudioLowerVolume.  I have one of those keyboards
>> lying around.
>>
>> Is there a way to support this on mobile phones without this key
>> breaking on machines with regular keyboards?
>
> No idea.  But I've yet to encounter such a phone in practice, so I have
> no objection to defaulting x-quit-keysym to nil, if they are indeed left
> ungrabbed by window managers on ordinary computers.

Thanks.  Could you please install a change along those lines?

Note also what Eli said:

> If it isn't possible to have an Android-specific binding, I think we
> should make the Android-specific binding in android-win.el or
> somesuch, and leave the default as it is appropriate for laptops and
> desktop systems.

bug#66040: 30.0.50; The XF86AudioLowerVolume on keyboard cannot be detected correctly

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Stefan Kangas <stefankangas@gmail.com> writes:

>> No idea.  But I've yet to encounter such a phone in practice, so I have
>> no objection to defaulting x-quit-keysym to nil, if they are indeed left
>> ungrabbed by window managers on ordinary computers.
>
> Thanks.  Could you please install a change along those lines?

Now done.

> Note also what Eli said:
>
>> If it isn't possible to have an Android-specific binding, I think we
>> should make the Android-specific binding in android-win.el or
>> somesuch, and leave the default as it is appropriate for laptops and
>> desktop systems.

Such a binding is not apposite for the Android port, given that its quit
keysym is set in stone (for there is no melange of incompatible display
servers each supplying their own keysym definitions for volume keys).

bug#66040: 30.0.50; The XF86AudioLowerVolume on keyboard cannot be detected correctly

[Stefan Kangas]

Po Lu <luangruo@yahoo.com> writes:

> Stefan Kangas <stefankangas@gmail.com> writes:
>
>>> No idea.  But I've yet to encounter such a phone in practice, so I have
>>> no objection to defaulting x-quit-keysym to nil, if they are indeed left
>>> ungrabbed by window managers on ordinary computers.
>>
>> Thanks.  Could you please install a change along those lines?
>
> Now done.

Thanks.  Wang, Zhenhua, could you please test if it now works for you?

bug#66040: 30.0.50; The XF86AudioLowerVolume on keyboard cannot be detected correctly

[Eli Zaretskii]

> Cc: "Wang, Zhenhua \(MU-Student\)" <zhenhua.wang@mail.missouri.edu>,
>  66040@debbugs.gnu.org
> Date: Sun, 01 Oct 2023 17:11:03 +0800
> From:  Po Lu via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> Stefan Kangas <stefankangas@gmail.com> writes:
> 
> > Note also what Eli said:
> >
> >> If it isn't possible to have an Android-specific binding, I think we
> >> should make the Android-specific binding in android-win.el or
> >> somesuch, and leave the default as it is appropriate for laptops and
> >> desktop systems.
> 
> Such a binding is not apposite for the Android port, given that its quit
> keysym is set in stone (for there is no melange of incompatible display
> servers each supplying their own keysym definitions for volume keys).

I was not worried about Android, I was worried about the other systems
and configurations.

In general, key bindings specific to some window-system are defined on
the respective *-win.el files.

bug#66040: 30.0.50; The XF86AudioLowerVolume on keyboard cannot be detected correctly

[Wang, Zhenhua (MU-Student)]

[-- Attachment #1: Type: text/plain, Size: 143 bytes --]

> Thanks.  Wang, Zhenhua, could you please test if it now works for you?

Thanks for the fix, this works well for me now!

Best,
Zhenhua

[-- Attachment #2: Type: text/html, Size: 1530 bytes --]

bug#66040: 30.0.50; The XF86AudioLowerVolume on keyboard cannot be detected correctly

[Stefan Kangas]

Version: 30.1

"Wang, Zhenhua (MU-Student)" <zhenhua.wang@mail.missouri.edu> writes:

>> Thanks.  Wang, Zhenhua, could you please test if it now works for you?
>
> Thanks for the fix, this works well for me now!

Thanks, I'm therefore closing this bug report.

bug#66040: 30.0.50; The XF86AudioLowerVolume on keyboard cannot be detected correctly

[Mauro Aranda]

On 1/10/23 06:11, Po Lu via Bug reports for GNU Emacs, the Swiss army 
knife of text editors wrote:
> Stefan Kangas <stefankangas@gmail.com> writes:
> 
>>> No idea.  But I've yet to encounter such a phone in practice, so I have
>>> no objection to defaulting x-quit-keysym to nil, if they are indeed left
>>> ungrabbed by window managers on ordinary computers.
>>
>> Thanks.  Could you please install a change along those lines?
> 
> Now done.
> 

Po Lu <luangruo@yahoo.com> writes:

 > Stefan Kangas <stefankangas@gmail.com> writes:
 >
 >>> No idea.  But I've yet to encounter such a phone in practice, so I have
 >>> no objection to defaulting x-quit-keysym to nil, if they are indeed 
left
 >>> ungrabbed by window managers on ordinary computers.
 >>
 >> Thanks.  Could you please install a change along those lines?
 >
 > Now done.
 >

I've found through bisecting that the following commit, which references
this Bug Report, has affected input of some characters for me.

commit 12aca0f90d7aeaa8444508245e7596a64f2e8dce
Author: Po Lu <luangruo@yahoo.com>
Date:   Sun Oct 1 17:07:58 2023 +0800

   Update Android port

   * doc/emacs/input.texi (On-Screen Keyboards): Revise
   documentation to reflect changes.

   * src/keyboard.c (lispy_function_keys) <KEYCODE_DPAD_CENTER>:
   Define select key absent out of negligence.

   * src/xterm.c (syms_of_xterm) <x-quit-keysym>: Default to nil.
   (bug#66040)

---

In a working checkout, I do:
emacs -Q
Hit the keys that would insert '^' twice, and I see ^ in the buffer.

I'm used to hit those keys twice, that's not a problem.  The first time
I type I see an indication, in case I want to type something like â.

After the cited commit, I do:
emacs -Q
Hit the keys that would insert '^' once, and I see that indication.  But
then, if I hit it again, Emacs says 'Quit'.  And there's no way for me
to insert ^, or â, or anything like that.

In case it helps, when I try to input ^ xev says:
KeyPress event, serial 37, synthetic NO, window 0x1200001,
     root 0x3c6, subw 0x0, time 109901302, (866,325), root:(1076,529),
     state 0x10, keycode 108 (keysym 0xfe03, ISO_Level3_Shift), 
same_screen YES,
     XKeysymToKeycode returns keycode: 92
     XLookupString gives 0 bytes:
     XmbLookupString gives 0 bytes:
     XFilterEvent returns: False

KeyPress event, serial 37, synthetic NO, window 0x1200001,
     root 0x3c6, subw 0x0, time 109901366, (866,325), root:(1076,529),
     state 0x90, keycode 48 (keysym 0xfe52, dead_circumflex), 
same_screen YES,
     XLookupString gives 1 bytes: (5e) "^"
     XmbLookupString gives 0 bytes:
     XFilterEvent returns: True

KeyRelease event, serial 37, synthetic NO, window 0x1200001,
     root 0x3c6, subw 0x0, time 109901494, (866,325), root:(1076,529),
     state 0x90, keycode 48 (keysym 0xfe52, dead_circumflex), 
same_screen YES,
     XLookupString gives 1 bytes: (5e) "^"
     XFilterEvent returns: False

KeyRelease event, serial 37, synthetic NO, window 0x1200001,
     root 0x3c6, subw 0x0, time 109901526, (866,325), root:(1076,529),
     state 0x90, keycode 108 (keysym 0xfe03, ISO_Level3_Shift), 
same_screen YES,
     XKeysymToKeycode returns keycode: 92
     XLookupString gives 0 bytes:
     XFilterEvent returns: False


And here's the info from report-emacs-bug from the affected session:

In GNU Emacs 30.0.50 (build 45, x86_64-pc-linux-gnu, GTK+ Version
  3.24.33, cairo version 1.16.0) of 2023-10-02 built on tbb-desktop
Repository revision: ad2bb3e9f36d1a4f25e1e2228586331b40a30a46
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12201001
System Description: Ubuntu 22.04.3 LTS

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY
INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF
TOOLKIT_SCROLL_BARS TREE_SITTER X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB

Important settings:
   value of $LC_MONETARY: es_AR.UTF-8
   value of $LC_NUMERIC: es_AR.UTF-8
   value of $LC_TIME: es_AR.UTF-8
   value of $LANG: en_US.UTF-8
   value of $XMODIFIERS: @im=ibus
   locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
   tooltip-mode: t
   global-eldoc-mode: t
   eldoc-mode: t
   show-paren-mode: t
   electric-indent-mode: t
   mouse-wheel-mode: t
   tool-bar-mode: t
   menu-bar-mode: t
   file-name-shadow-mode: t
   global-font-lock-mode: t
   font-lock-mode: t
   blink-cursor-mode: t
   minibuffer-regexp-mode: t
   line-number-mode: t
   indent-tabs-mode: t
   transient-mark-mode: t
   auto-composition-mode: t
   auto-encryption-mode: t
   auto-compression-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message mailcap yank-media puny dired
dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068
epg-config gnus-util text-property-search time-date subr-x mm-decode
mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader
cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric
uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel
term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset
image regexp-opt fringe tabulated-list replace newcomment text-mode
lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch
easymenu timer select scroll-bar mouse jit-lock font-lock syntax
font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
composite emoji-zwj charscript charprop case-table epa-hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs
theme-loaddefs faces cus-face macroexp files window text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget keymap
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting cairo gtk
x-toolkit xinput2 x multi-tty move-toolbar make-network-process emacs)

Memory information:
((conses 16 37547 9201) (symbols 48 5213 0) (strings 32 13197 2675)
  (string-bytes 1 373504) (vectors 16 10299)
  (vector-slots 8 156179 13963) (floats 8 21 23) (intervals 56 222 0)
  (buffers 992 10))

bug#66040: 30.0.50; The XF86AudioLowerVolume on keyboard cannot be detected correctly

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Mauro Aranda <maurooaranda@gmail.com> writes:

> I've found through bisecting that the following commit, which references
> this Bug Report, has affected input of some characters for me.
>
> commit 12aca0f90d7aeaa8444508245e7596a64f2e8dce
> Author: Po Lu <luangruo@yahoo.com>
> Date:   Sun Oct 1 17:07:58 2023 +0800
>
>   Update Android port
>
>   * doc/emacs/input.texi (On-Screen Keyboards): Revise
>   documentation to reflect changes.
>
>   * src/keyboard.c (lispy_function_keys) <KEYCODE_DPAD_CENTER>:
>   Define select key absent out of negligence.
>
>   * src/xterm.c (syms_of_xterm) <x-quit-keysym>: Default to nil.
>   (bug#66040)
>
> ---
>
> In a working checkout, I do:
> emacs -Q
> Hit the keys that would insert '^' twice, and I see ^ in the buffer.
>
> I'm used to hit those keys twice, that's not a problem.  The first time
> I type I see an indication, in case I want to type something like â.
>
> After the cited commit, I do:
> emacs -Q
> Hit the keys that would insert '^' once, and I see that indication.  But
> then, if I hit it again, Emacs says 'Quit'.  And there's no way for me
> to insert ^, or â, or anything like that.

Please try again, thanks.

bug#66040: 30.0.50; The XF86AudioLowerVolume on keyboard cannot be detected correctly

[Mauro Aranda]

On 2/10/23 22:01, Po Lu wrote:
 > Mauro Aranda <maurooaranda@gmail.com> writes:
 >
 >> I've found through bisecting that the following commit, which references
 >> this Bug Report, has affected input of some characters for me.
 >>
 >> commit 12aca0f90d7aeaa8444508245e7596a64f2e8dce
 >> Author: Po Lu <luangruo@yahoo.com>
 >> Date:   Sun Oct 1 17:07:58 2023 +0800
 >>
 >>   Update Android port
 >>
 >>   * doc/emacs/input.texi (On-Screen Keyboards): Revise
 >>   documentation to reflect changes.
 >>
 >>   * src/keyboard.c (lispy_function_keys) <KEYCODE_DPAD_CENTER>:
 >>   Define select key absent out of negligence.
 >>
 >>   * src/xterm.c (syms_of_xterm) <x-quit-keysym>: Default to nil.
 >>   (bug#66040)
 >>
 >> ---
 >>
 >> In a working checkout, I do:
 >> emacs -Q
 >> Hit the keys that would insert '^' twice, and I see ^ in the buffer.
 >>
 >> I'm used to hit those keys twice, that's not a problem. The first time
 >> I type I see an indication, in case I want to type something like â.
 >>
 >> After the cited commit, I do:
 >> emacs -Q
 >> Hit the keys that would insert '^' once, and I see that indication.  But
 >> then, if I hit it again, Emacs says 'Quit'.  And there's no way for me
 >> to insert ^, or â, or anything like that.
 >
 > Please try again, thanks.

Fixed, thanks.