bug#4025: 23.1.50; VC shows bazaar files as modified on modeline

bug#4025: 23.1.50; VC shows bazaar files as modified on modeline

[ofv]

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

When visiting a file which is versioned with bazaar, on a pristine
branch, the modeline indicates that it is locally modified (shows
Bzr:700). After M-x vc-revert, it shows its right state (Bzr-700)
and keeps doing so for subsequent emacs sessions.

One workaround is to execute `bzr revert` for the whole branch.

If there is a modified file, VC will keep showing it as locally modified
even after executing `bzr revert` on a shell and doing a M-x
revert-buffer.

Using bzr 1.17

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/usr/local/share/emacs/23.1.50/etc/DEBUG for instructions.


In GNU Emacs 23.1.50.3 (x86_64-unknown-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2009-07-31 on qcore
Windowing system distributor `The X.Org Foundation', version 11.0.10600000
configured using `configure  '--with-x-toolkit=lucid''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <menu-bar> 
<help-menu> <send-emacs-bug-report>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Load-path shadows:
None found.

bug#4025: 23.1.50; VC shows bazaar files as modified on modeline

[Óscar Fuentes]

The problem is in vc-bzr-state-heuristic. It doesn't notice that the
heuristics used for checking the state doesn't work and returns some
garbage instead of crashing and hence invoke vc-bzr-state through the
`error` form at the end.

bug#4025: 23.1.50; VC shows bazaar files as modified on modeline

[Óscar Fuentes]

Another workaround is to execute `bzr status` for the branch on a
shell. VC will detect the correct state afterwards.

bug#4025: 23.1.50; VC shows bazaar files as modified on modeline

[Dan Nicolaescu]

Óscar Fuentes <ofv@wanadoo.es> writes:

  > The problem is in vc-bzr-state-heuristic. It doesn't notice that the
  > heuristics used for checking the state doesn't work and returns some
  > garbage instead of crashing and hence invoke vc-bzr-state through the
  > `error` form at the end.

vc-bzr-state-heuristic looks for some very specific things to try to
guess the state, if none of the match it returns 'edited, which is what
you see.

You can try looking at the entry in .bzr/checkout/dirstate for the file
in question in both the branch and the repository. Check the difference
between the two and try to find out why vc-bzr-state-heuristic fails.

bug#4025: 23.1.50; VC shows bazaar files as modified on modeline

[Óscar Fuentes]

For the record, this issue is fixed.