unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#21316: 25.0.50; eww-browse-with-external-browser should respect browse-url by default
@ 2015-08-21 18:44 Artur Malabarba
  2015-12-25  5:52 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 3+ messages in thread
From: Artur Malabarba @ 2015-08-21 18:44 UTC (permalink / raw)
  To: 21316

The browser used by `eww-browse-with-external-browser' is given by the
variable `shr-external-browser'. The default value of this variable is
`browse-url-default-browser', which gives me the impression that it's
trying to fallback on whatever `browse-url' would do.
But `browse-url' behaviour is actually configured by
`browse-url-browser-function'

In terms of actual user experience, I was surprised when
`eww-browse-with-external-browser' launched the wrong browser for me.

In my opinion:
- There should be a value for this variable (nil?) that simply
fallsback on browse-url. (pretty straightforward)
- This value should be the default. (slightly subjective)





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#21316: 25.0.50; eww-browse-with-external-browser should respect browse-url by default
  2015-08-21 18:44 bug#21316: 25.0.50; eww-browse-with-external-browser should respect browse-url by default Artur Malabarba
@ 2015-12-25  5:52 ` Lars Ingebrigtsen
  2015-12-28 23:36   ` Artur Malabarba
  0 siblings, 1 reply; 3+ messages in thread
From: Lars Ingebrigtsen @ 2015-12-25  5:52 UTC (permalink / raw)
  To: Artur Malabarba; +Cc: 21316

Artur Malabarba <bruce.connor.am@gmail.com> writes:

> The browser used by `eww-browse-with-external-browser' is given by the
> variable `shr-external-browser'. The default value of this variable is
> `browse-url-default-browser', which gives me the impression that it's
> trying to fallback on whatever `browse-url' would do.
> But `browse-url' behaviour is actually configured by
> `browse-url-browser-function'
>
> In terms of actual user experience, I was surprised when
> `eww-browse-with-external-browser' launched the wrong browser for me.

This is so that you can set `browse-url-browser-function' to eww, which
is what everybody does.  :-)  You still need an external browser, and
`browse-url-default-browser' returns one of those.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#21316: 25.0.50; eww-browse-with-external-browser should respect browse-url by default
  2015-12-25  5:52 ` Lars Ingebrigtsen
@ 2015-12-28 23:36   ` Artur Malabarba
  0 siblings, 0 replies; 3+ messages in thread
From: Artur Malabarba @ 2015-12-28 23:36 UTC (permalink / raw)
  To: Lars Magne Ingebrigtsen; +Cc: 21316

[-- Attachment #1: Type: text/plain, Size: 622 bytes --]

On 25 Dec 2015 3:52 am, "Lars Ingebrigtsen" <larsi@gnus.org> wrote:
> > In terms of actual user experience, I was surprised when
> > `eww-browse-with-external-browser' launched the wrong browser for me.
>
> This is so that you can set `browse-url-browser-function' to eww, which
> is what everybody does.  :-)  You still need an external browser, and
> `browse-url-default-browser' returns one of those.

I understand the logic. Still, is there any chance we can find another
solution?
Something that avoids the surprise I had? This was the first time emacs
ever opened the wrong browser for me.

Not a huge deal, though.

[-- Attachment #2: Type: text/html, Size: 802 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-12-28 23:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-21 18:44 bug#21316: 25.0.50; eww-browse-with-external-browser should respect browse-url by default Artur Malabarba
2015-12-25  5:52 ` Lars Ingebrigtsen
2015-12-28 23:36   ` Artur Malabarba

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).