* bug#31137: 27.0.50; `Info-find-node-2': Pass STRICT-CASE in last 2 `Info-find-node' calls?
@ 2018-04-12 18:14 Drew Adams
2018-04-12 18:46 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Drew Adams @ 2018-04-12 18:14 UTC (permalink / raw)
To: 31137
At the end of `Info-find-node-2' we see this in the second
part of `unwind-protect':
;; If we did not finish finding the specified node,
;; go back to the previous one or to the Top node.
(unless (or Info-current-node no-going-back)
(if Info-history
(let ((hist (car Info-history)))
(setq Info-history (cdr Info-history))
(Info-find-node (nth 0 hist) (nth 1 hist) t)
(goto-char (nth 2 hist)))
(Info-find-node Info-current-file "Top" t)))))
Shouldn't those calls to `Info-find-node' pass along the
received value of arg STRICT-CASE?
In GNU Emacs 27.0.50 (build 3, x86_64-w64-mingw32)
of 2018-03-21 built on CIRROCUMULUS
Repository revision: e70d0c9e66d7a8609450b2889869d16aeb0363b5
Windowing system distributor 'Microsoft Corp.', version 6.1.7601
Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Read-Only mode enabled in current buffer
Mark saved where search started
Mark set
Quit
Quit
Configured using:
'configure --without-dbus --host=x86_64-w64-mingw32
--without-compress-install -C 'CFLAGS=-O2 -static -g3''
Configured features:
XPM JPEG TIFF GIF PNG RSVG SOUND NOTIFY ACL GNUTLS LIBXML2 ZLIB
TOOLKIT_SCROLL_BARS THREADS LCMS2
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#31137: 27.0.50; `Info-find-node-2': Pass STRICT-CASE in last 2 `Info-find-node' calls?
2018-04-12 18:14 bug#31137: 27.0.50; `Info-find-node-2': Pass STRICT-CASE in last 2 `Info-find-node' calls? Drew Adams
@ 2018-04-12 18:46 ` Eli Zaretskii
2021-02-04 10:23 ` Lars Ingebrigtsen
0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2018-04-12 18:46 UTC (permalink / raw)
To: Drew Adams; +Cc: 31137
> Date: Thu, 12 Apr 2018 11:14:37 -0700 (PDT)
> From: Drew Adams <drew.adams@oracle.com>
>
> ;; If we did not finish finding the specified node,
> ;; go back to the previous one or to the Top node.
> (unless (or Info-current-node no-going-back)
> (if Info-history
> (let ((hist (car Info-history)))
> (setq Info-history (cdr Info-history))
> (Info-find-node (nth 0 hist) (nth 1 hist) t)
> (goto-char (nth 2 hist)))
> (Info-find-node Info-current-file "Top" t)))))
>
> Shouldn't those calls to `Info-find-node' pass along the
> received value of arg STRICT-CASE?
I don't think it matters, because in both calls the node names are
exact. We actually might as well force the 4th arg to Info-find-node
be t.
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#31137: 27.0.50; `Info-find-node-2': Pass STRICT-CASE in last 2 `Info-find-node' calls?
2018-04-12 18:46 ` Eli Zaretskii
@ 2021-02-04 10:23 ` Lars Ingebrigtsen
0 siblings, 0 replies; 3+ messages in thread
From: Lars Ingebrigtsen @ 2021-02-04 10:23 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 31137
Eli Zaretskii <eliz@gnu.org> writes:
> I don't think it matters, because in both calls the node names are
> exact. We actually might as well force the 4th arg to Info-find-node
> be t.
Makes sense. I've now made this change in Emacs 28.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-04 10:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-12 18:14 bug#31137: 27.0.50; `Info-find-node-2': Pass STRICT-CASE in last 2 `Info-find-node' calls? Drew Adams
2018-04-12 18:46 ` Eli Zaretskii
2021-02-04 10:23 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).