From: Lars Ingebrigtsen <larsi@gnus.org>
To: William Denton <wtd@pobox.com>
Cc: 48681@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#48681: Patch: Make prettify-symbols-mode work with ruby-mode
Date: Thu, 27 May 2021 00:10:26 +0200 [thread overview]
Message-ID: <87y2c19mel.fsf@gnus.org> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2105261315090.44199@shell3.miskatonic.org> (William Denton's message of "Wed, 26 May 2021 13:26:03 -0400 (EDT)")
William Denton <wtd@pobox.com> writes:
> Hello,
>
> Attached is a small patch that will make prettify-symbols-mode work in
> ruby-mode. It just adapts the code that's there for perl-mode, using
> some of the symbols from python-mode.
>
> This is my first time submitting a patch, and I hope it and this
> commit message are close to what's needed:
Thanks; the patch looks good to me. I see that the equivalent thing in
Perl mode was added as:
+(defconst perl--prettify-symbols-alist
+ '(;;("andalso" . ?∧) ("orelse" . ?∨) ("as" . ?≡)("not" . ?¬)
+ ;;("div" . ?÷) ("*" . ?×) ("o" . ?○)
+ ("->" . ?→)
+ ("=>" . ?⇒)
+ ;;("<-" . ?←) ("<>" . ?≠) (">=" . ?≥) ("<=" . ?≤) ("..." . ?⋯)
+ ("::" . ?∷)
+ ))
And then later the commented-out ?∧ (etc) stuff was removed, so I'm
wondering:
> +(defconst ruby--prettify-symbols-alist
> + '(("and" . ?∧)
> + ("or" . ?∨))
> + "Value for `prettify-symbols-alist' in `ruby-mode'.")
Whether this is something that users of symbol prettification would
appreciate or not. Since I use neither prettification or write Ruby, I
have no opinion here. Perhaps Stefan has? (Added to the CCs.)
(And why are these defconsts, anyway?)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-05-26 22:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 17:26 bug#48681: Patch: Make prettify-symbols-mode work with ruby-mode William Denton
2021-05-26 22:10 ` Lars Ingebrigtsen [this message]
2021-05-27 1:54 ` William Denton
2021-05-27 2:54 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-27 3:52 ` William Denton
2021-05-27 18:02 ` Dmitry Gutov
2021-05-29 6:10 ` Lars Ingebrigtsen
2021-05-29 11:07 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2c19mel.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=48681@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=wtd@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).