From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#48681: Patch: Make prettify-symbols-mode work with ruby-mode Date: Thu, 27 May 2021 00:10:26 +0200 Message-ID: <87y2c19mel.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27516"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 48681@debbugs.gnu.org, Stefan Monnier To: William Denton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 27 00:11:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lm1kB-0006we-1i for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 May 2021 00:11:15 +0200 Original-Received: from localhost ([::1]:36452 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lm1kA-0000dD-1C for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 26 May 2021 18:11:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47082) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lm1jy-0000cm-Q0 for bug-gnu-emacs@gnu.org; Wed, 26 May 2021 18:11:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38559) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lm1jy-0004Hu-Ie for bug-gnu-emacs@gnu.org; Wed, 26 May 2021 18:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lm1jy-0005F1-E7 for bug-gnu-emacs@gnu.org; Wed, 26 May 2021 18:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 May 2021 22:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48681 X-GNU-PR-Package: emacs Original-Received: via spool by 48681-submit@debbugs.gnu.org id=B48681.162206704020104 (code B ref 48681); Wed, 26 May 2021 22:11:02 +0000 Original-Received: (at 48681) by debbugs.gnu.org; 26 May 2021 22:10:40 +0000 Original-Received: from localhost ([127.0.0.1]:50102 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lm1jb-0005EC-SU for submit@debbugs.gnu.org; Wed, 26 May 2021 18:10:40 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:34688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lm1jZ-0005Dv-AN for 48681@debbugs.gnu.org; Wed, 26 May 2021 18:10:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=eD/8O0uWSluOkP8CViU2nCB2kXH/dDB92Crmhxu+k7k=; b=eTX30Os/sTxcDaY6cGb0EQjiat fX7d1XBHcxszwHaJQ2RZCWRsgb0+dNs4ySiASZOBTESq/5he2uKXzY30wk0EdqCrdS/OFY+NMxDSH Ja8BBdRthlLTvxb2wGqW6DoAUYD01pKR7GOuOpbLc9whUNFN1Bjt95zDQWsm1gRErul4=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lm1jO-0003jR-Ie; Thu, 27 May 2021 00:10:29 +0200 X-Now-Playing: Tuxedomoon's _Live At The Palms (1978)_: "New Machine" In-Reply-To: (William Denton's message of "Wed, 26 May 2021 13:26:03 -0400 (EDT)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207323 Archived-At: William Denton writes: > Hello, > > Attached is a small patch that will make prettify-symbols-mode work in > ruby-mode. It just adapts the code that's there for perl-mode, using > some of the symbols from python-mode. > > This is my first time submitting a patch, and I hope it and this > commit message are close to what's needed: Thanks; the patch looks good to me. I see that the equivalent thing in Perl mode was added as: +(defconst perl--prettify-symbols-alist + '(;;("andalso" . ?=E2=88=A7) ("orelse" . ?=E2=88=A8) ("as" . ?=E2=89=A1= )("not" . ?=C2=AC) + ;;("div" . ?=C3=B7) ("*" . ?=C3=97) ("o" . ?=E2=97=8B) + ("->" . ?=E2=86=92) + ("=3D>" . ?=E2=87=92) + ;;("<-" . ?=E2=86=90) ("<>" . ?=E2=89=A0) (">=3D" . ?=E2=89=A5) ("<= =3D" . ?=E2=89=A4) ("..." . ?=E2=8B=AF) + ("::" . ?=E2=88=B7) + )) And then later the commented-out ?=E2=88=A7 (etc) stuff was removed, so I'm wondering: > +(defconst ruby--prettify-symbols-alist > + '(("and" . ?=E2=88=A7) > + ("or" . ?=E2=88=A8)) > + "Value for `prettify-symbols-alist' in `ruby-mode'.") Whether this is something that users of symbol prettification would appreciate or not. Since I use neither prettification or write Ruby, I have no opinion here. Perhaps Stefan has? (Added to the CCs.) (And why are these defconsts, anyway?) --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no