From: Amin Bandali <bandali@gnu.org>
To: Po Lu <luangruo@yahoo.com>
Cc: 65919@debbugs.gnu.org, Lars Ingebrigtsen <larsi@gnus.org>,
Ivan Popovych <ivan@ipvych.com>, Bob Rogers <rogers@rgrjr.com>
Subject: bug#65919: 29.1; build without xinput does not get focused when hovering over window
Date: Fri, 15 Sep 2023 01:02:33 -0400 [thread overview]
Message-ID: <87y1h8qb9y.fsf@gnu.org> (raw)
In-Reply-To: <87h6nw126w.fsf@yahoo.com>
Po Lu writes:
> Amin Bandali <bandali@gnu.org> writes:
>
>> Hello,
>>
>> Po Lu writes:
>>
>>> This should be fixed on the master branch. [...]
>>
>> FYI your e1a730017d6 patch introduces the following compiler warning:
>>
>> process.c: In function ‘child_signal_notify’:
>> process.c:7436:54: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]
>> 7436 | /* emacs_perror ("writing to child signal FD") */;
>> | ^
>
> Thanks. Does this silence the warning?
>
> diff --git a/configure.ac b/configure.ac
> index 7ca75be996d..3b5f3c1c37a 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1776,6 +1776,9 @@ AC_DEFUN
> # Emacs doesn't need this paranoia.
> nw="$nw -Wbidi-chars=any,ucn"
>
> + # Or this hysteria, which impedes commentary within if statements.
> + nw="$nw -Wempty-body"
> +
> if test "$emacs_cv_clang" = yes; then
> nw="$nw -Wdouble-promotion"
> nm="$nm -Wunknown-pragmas"
>
Thanks, but it doesn't seem to. Also, IMHO this is a useful warning,
and the better fix would be to add the braces for that if statement.
That part of the code now looks quite fragile, and a problem waiting
to happen if that lone semicolon is accidentally mistakenly removed.
next prev parent reply other threads:[~2023-09-15 5:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 9:56 bug#65919: 29.1; build without xinput does not get focused when hovering over window Ivan Popovych via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-14 0:45 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-14 7:56 ` Ivan Popovych via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-14 8:47 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-14 10:13 ` Ivan Popovych via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-14 11:04 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-15 2:38 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-15 3:57 ` Amin Bandali
2023-09-15 4:37 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-15 5:02 ` Amin Bandali [this message]
2023-09-15 5:06 ` Stefan Kangas
2023-09-15 5:17 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-15 5:43 ` Stefan Kangas
2023-09-15 6:07 ` Eli Zaretskii
2023-09-15 5:10 ` Bob Rogers
2023-09-15 5:18 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-15 9:54 ` Ivan Popovych via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-09-15 11:10 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1h8qb9y.fsf@gnu.org \
--to=bandali@gnu.org \
--cc=65919@debbugs.gnu.org \
--cc=ivan@ipvych.com \
--cc=larsi@gnus.org \
--cc=luangruo@yahoo.com \
--cc=rogers@rgrjr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).