From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Amin Bandali Newsgroups: gmane.emacs.bugs Subject: bug#65919: 29.1; build without xinput does not get focused when hovering over window Date: Fri, 15 Sep 2023 01:02:33 -0400 Message-ID: <87y1h8qb9y.fsf@gnu.org> References: <87led9rxw0.fsf@ipvych.com> <87edj12lbk.fsf@yahoo.com> <87fs3hrriy.fsf@ipvych.com> <87a5tp2eyz.fsf@yahoo.com> <87y1h817qd.fsf@yahoo.com> <87ttrwulzt.fsf@gnu.org> <87h6nw126w.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16900"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (gnu/linux) Cc: 65919@debbugs.gnu.org, Lars Ingebrigtsen , Ivan Popovych , Bob Rogers To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 15 07:03:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qh0zB-0004Eh-2x for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Sep 2023 07:03:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qh0yv-0006Y3-KR; Fri, 15 Sep 2023 01:03:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qh0yn-0006X2-5y for bug-gnu-emacs@gnu.org; Fri, 15 Sep 2023 01:02:57 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qh0ym-0005Gi-Qp for bug-gnu-emacs@gnu.org; Fri, 15 Sep 2023 01:02:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qh0yt-0002eg-0N for bug-gnu-emacs@gnu.org; Fri, 15 Sep 2023 01:03:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Amin Bandali Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Sep 2023 05:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65919 X-GNU-PR-Package: emacs Original-Received: via spool by 65919-submit@debbugs.gnu.org id=B65919.169475417610179 (code B ref 65919); Fri, 15 Sep 2023 05:03:02 +0000 Original-Received: (at 65919) by debbugs.gnu.org; 15 Sep 2023 05:02:56 +0000 Original-Received: from localhost ([127.0.0.1]:41772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh0ym-0002e7-Dn for submit@debbugs.gnu.org; Fri, 15 Sep 2023 01:02:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51452) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qh0yj-0002dq-E9 for 65919@debbugs.gnu.org; Fri, 15 Sep 2023 01:02:55 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qh0yX-0005Ax-4G; Fri, 15 Sep 2023 01:02:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=nx860VzYZ60ec2cycrT0/QnBrqHDyczvq0D10ugTq+U=; b=PfVhozHiu2dVkFxulYzk gev963gwOuT/UmfUDFtvFwAc2US6IPydtTX1D6km2F3v90q0ktFwUOqBeMVixlk+c0zgoq7xm+3b2 8OajTTs1SIFkV8Gkd3A8+G5wxyH9t8908ADDaWZkEOXIfELneZOpF+HyIP8UqHA5fRh24Yjy8cJLy Aqv8mRDOnYfwcSuvIPVtUD5kIUmRUV+tMpgpjWuk6Bp8d9SWQv3vjZWxLud7H7g7J6gP3zs2fZ+Hy SyLzhMv0ZTKu9GSJGdyzTS3lXfIENhq3yOInCwSSiEqOeEnY/W/mmUr55WTUaVqQLmY0cHztLVGKW BbHGhZUTIvlhAQ==; In-Reply-To: <87h6nw126w.fsf@yahoo.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270478 Archived-At: Po Lu writes: > Amin Bandali writes: > >> Hello, >> >> Po Lu writes: >> >>> This should be fixed on the master branch. [...] >> >> FYI your e1a730017d6 patch introduces the following compiler warning: >> >> process.c: In function =E2=80=98child_signal_notify=E2=80=99: >> process.c:7436:54: warning: suggest braces around empty body in an =E2= =80=98if=E2=80=99 statement [-Wempty-body] >> 7436 | /* emacs_perror ("writing to child signal FD") */; >> | ^ > > Thanks. Does this silence the warning? > > diff --git a/configure.ac b/configure.ac > index 7ca75be996d..3b5f3c1c37a 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1776,6 +1776,9 @@ AC_DEFUN > # Emacs doesn't need this paranoia. > nw=3D"$nw -Wbidi-chars=3Dany,ucn" >=20=20 > + # Or this hysteria, which impedes commentary within if statements. > + nw=3D"$nw -Wempty-body" > + > if test "$emacs_cv_clang" =3D yes; then > nw=3D"$nw -Wdouble-promotion" > nm=3D"$nm -Wunknown-pragmas" > Thanks, but it doesn't seem to. Also, IMHO this is a useful warning, and the better fix would be to add the braces for that if statement. That part of the code now looks quite fragile, and a problem waiting to happen if that lone semicolon is accidentally mistakenly removed.