From: Stephen Berman <stephen.berman@gmx.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: pent@aparamon.msk.ru, 2749@debbugs.gnu.org
Subject: bug#2749: 23.0.91; Visual Line Mode: incorrect line wrapping in corner case
Date: Fri, 10 May 2013 17:49:40 +0200 [thread overview]
Message-ID: <87wqr66dij.fsf@rosalinde.fritz.box> (raw)
In-Reply-To: <83ip2qc23k.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 10 May 2013 17:59:43 +0300")
On Fri, 10 May 2013 17:59:43 +0300 Eli Zaretskii <eliz@gnu.org> wrote:
>> From: Stephen Berman <stephen.berman@gmx.net>
>> Date: Fri, 10 May 2013 16:01:22 +0200
>> Cc: pent <pent@aparamon.msk.ru>, 2749@debbugs.gnu.org
>>
>> I've been using Emacs as described above (i.e., with the patch below)
>> and till today have had no problems, but I just bumped into one, which
>> is indeed confusing, even pretty nasty. I've reproduced it with -Q on a
>> fresh build from the latest trunk (with the patch added). I don't know
>> how to debug it, but I will describe how to reproduce it, in the hope
>> that someone can fix it (or at least give me some help in trying to
>> debug it) and then hopefully overflow-newline-into-fringe can be allowed
>> in Visual Line mode.
>
> Does the patch below fix the problem (and whatever original problem
> that led you to this recipe)?
>
> --- src/xdisp.c~0 2013-05-10 17:56:44.338000000 +0300
> +++ src/xdisp.c 2013-05-10 17:57:07.197375000 +0300
> @@ -8466,7 +8466,8 @@
> && it->bidi_it.paragraph_dir == R2L)
> ? WINDOW_LEFT_FRINGE_WIDTH (it->w)
> : WINDOW_RIGHT_FRINGE_WIDTH (it->w)) == 0
> - || IT_OVERFLOW_NEWLINE_INTO_FRINGE (it))
> + || (IT_OVERFLOW_NEWLINE_INTO_FRINGE (it)
> + && it->line_wrap != WORD_WRAP))
> {
> if (!get_next_display_element (it))
> {
Yes, it fixes the "confusing results" with the patch in my previous
mail. Thanks very much! (I wish I understood why this problem occurred
and how your patch fixes it...) Unless someone knows of another problem
with allowing overflow-newline-into-fringe in Visual Line mode, I would
like to request that both my patch and yours be committed to the trunk;
I can do that if I'm given the go-ahead. Then I think this bug could be
closed.
Steve Berman
next prev parent reply other threads:[~2013-05-10 15:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-24 18:04 bug#2749: 23.0.91; Visual Line Mode: incorrect line wrapping in corner case Chong Yidong
2009-03-25 1:35 ` Stefan Monnier
2009-03-22 19:13 ` pent
2013-02-18 12:03 ` Stephen Berman
2013-05-10 14:01 ` Stephen Berman
2013-05-10 14:59 ` Eli Zaretskii
2013-05-10 15:49 ` Stephen Berman [this message]
2013-05-10 17:37 ` Eli Zaretskii
2013-05-10 19:06 ` Stephen Berman
2013-05-10 19:31 ` Eli Zaretskii
2013-05-18 20:30 ` Stephen Berman
2013-05-19 15:29 ` Eli Zaretskii
2013-05-19 16:28 ` Stephen Berman
2013-05-19 17:38 ` Eli Zaretskii
2013-05-28 22:26 ` Stefan Monnier
2013-07-02 15:54 ` Eli Zaretskii
2013-07-03 9:15 ` Stefan Monnier
2013-07-03 9:52 ` Stephen Berman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wqr66dij.fsf@rosalinde.fritz.box \
--to=stephen.berman@gmx.net \
--cc=2749@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=pent@aparamon.msk.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).