From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#2749: 23.0.91; Visual Line Mode: incorrect line wrapping in corner case Date: Fri, 10 May 2013 17:49:40 +0200 Message-ID: <87wqr66dij.fsf@rosalinde.fritz.box> References: <87d4c694r2.fsf@cyd.mit.edu> <87obfhhn9d.fsf@rosalinde.fritz.box> <871u9f6ij1.fsf@rosalinde.fritz.box> <83ip2qc23k.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1368201008 14499 80.91.229.3 (10 May 2013 15:50:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 10 May 2013 15:50:08 +0000 (UTC) Cc: pent@aparamon.msk.ru, 2749@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri May 10 17:50:06 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Uapa6-0005Li-EC for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 May 2013 17:50:02 +0200 Original-Received: from localhost ([::1]:51667 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uapa6-00075T-4h for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 May 2013 11:50:02 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:47944) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uapa0-00075K-88 for bug-gnu-emacs@gnu.org; Fri, 10 May 2013 11:49:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UapZw-0007iB-VA for bug-gnu-emacs@gnu.org; Fri, 10 May 2013 11:49:56 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59927) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UapZw-0007i7-QW for bug-gnu-emacs@gnu.org; Fri, 10 May 2013 11:49:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Uapa6-0001iC-Ht for bug-gnu-emacs@gnu.org; Fri, 10 May 2013 11:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 May 2013 15:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 2749 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 2749-submit@debbugs.gnu.org id=B2749.13682009996562 (code B ref 2749); Fri, 10 May 2013 15:50:02 +0000 Original-Received: (at 2749) by debbugs.gnu.org; 10 May 2013 15:49:59 +0000 Original-Received: from localhost ([127.0.0.1]:35803 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Uapa2-0001hl-B1 for submit@debbugs.gnu.org; Fri, 10 May 2013 11:49:59 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:63188) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UapZz-0001hO-TM for 2749@debbugs.gnu.org; Fri, 10 May 2013 11:49:57 -0400 Original-Received: from mailout-de.gmx.net ([10.1.76.31]) by mrigmx.server.lan (mrigmx001) with ESMTP (Nemesis) id 0LtC7R-1UQLym2h9X-012tVo for <2749@debbugs.gnu.org>; Fri, 10 May 2013 17:49:43 +0200 Original-Received: (qmail invoked by alias); 10 May 2013 15:49:43 -0000 Original-Received: from i59F57249.versanet.de (EHLO rosalinde.fritz.box) [89.245.114.73] by mail.gmx.net (mp031) with SMTP; 10 May 2013 17:49:43 +0200 X-Authenticated: #20778731 X-Provags-ID: V01U2FsdGVkX1/1smQOIl/1shE9IpJATlHjEG67dCLXfIJN4H5ZYd j0G5ggCVPlqh6Q In-Reply-To: <83ip2qc23k.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 10 May 2013 17:59:43 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-Y-GMX-Trusted: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:74129 Archived-At: On Fri, 10 May 2013 17:59:43 +0300 Eli Zaretskii wrote: >> From: Stephen Berman >> Date: Fri, 10 May 2013 16:01:22 +0200 >> Cc: pent , 2749@debbugs.gnu.org >> >> I've been using Emacs as described above (i.e., with the patch below) >> and till today have had no problems, but I just bumped into one, which >> is indeed confusing, even pretty nasty. I've reproduced it with -Q on a >> fresh build from the latest trunk (with the patch added). I don't know >> how to debug it, but I will describe how to reproduce it, in the hope >> that someone can fix it (or at least give me some help in trying to >> debug it) and then hopefully overflow-newline-into-fringe can be allowed >> in Visual Line mode. > > Does the patch below fix the problem (and whatever original problem > that led you to this recipe)? > > --- src/xdisp.c~0 2013-05-10 17:56:44.338000000 +0300 > +++ src/xdisp.c 2013-05-10 17:57:07.197375000 +0300 > @@ -8466,7 +8466,8 @@ > && it->bidi_it.paragraph_dir == R2L) > ? WINDOW_LEFT_FRINGE_WIDTH (it->w) > : WINDOW_RIGHT_FRINGE_WIDTH (it->w)) == 0 > - || IT_OVERFLOW_NEWLINE_INTO_FRINGE (it)) > + || (IT_OVERFLOW_NEWLINE_INTO_FRINGE (it) > + && it->line_wrap != WORD_WRAP)) > { > if (!get_next_display_element (it)) > { Yes, it fixes the "confusing results" with the patch in my previous mail. Thanks very much! (I wish I understood why this problem occurred and how your patch fixes it...) Unless someone knows of another problem with allowing overflow-newline-into-fringe in Visual Line mode, I would like to request that both my patch and yours be committed to the trunk; I can do that if I'm given the go-ahead. Then I think this bug could be closed. Steve Berman