unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Marcin Borkowski <mbork@mbork.pl>
To: npostavs@users.sourceforge.net
Cc: 21072@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#21072: Brave new mark-defun (and a testing tool)
Date: Tue, 25 Apr 2017 13:43:38 +0200	[thread overview]
Message-ID: <87wpa8yaol.fsf@jane> (raw)
In-Reply-To: <8737cyotmt.fsf@users.sourceforge.net>


On 2017-04-24, at 14:52, npostavs@users.sourceforge.net wrote:

> Marcin Borkowski <mbork@mbork.pl> writes:
>
>> On 2017-04-22, at 20:05, npostavs@users.sourceforge.net wrote:
>>
>>>> Still not there - I tried first on Elisp, like this:
>>>>
>>>> ;; A comment
>>>> (defun ...)
>>>>
>>>> and it left the point at the end of the "A comment" line instead of at
>>>> the beginning...
>>>
>>> Hmm, I don't get that, although I did miss an inf loop when the comment
>>> is at beginning of buffer.  Here is a fixed version:
>>
>> Still the same here, also in emacs -Q.
>
> Hmm, I was testing before now just by evaluating the changed functions
> after startup, I must have messed something up.  I think this one might
> be okay.
>
>     (defun beginning-of-defun-comments (&optional arg)
>       "Move to the beginning of ARGth defun, including comments."
>       (interactive "^p")
>       (unless arg (setq arg 1))
>       (beginning-of-defun arg)
>       (while (let ((pt (line-beginning-position))
>                    (ppss (and (zerop (forward-line -1)) (syntax-ppss))))
>                (cond ((nth 4 ppss) (goto-char (nth 8 ppss)))
>                      ((and ppss
>                            (parse-partial-sexp
>                             (point) (line-end-position) nil t ppss)
>                            (not (bolp)) (eolp)))
>                      (t (goto-char pt) nil)))))

Quick tests show that you are right.  I'd like to understand the code,
too - that will take me a while.

>>> Looks good to me (apart from the commit messages).
>
> Actually, now that I've applied this thing properly, I notice 2 test
> failures in batch mode:
>
> 2 unexpected results:
>    FAILED  mark-defun-arg-region-active
>    FAILED  mark-defun-no-arg-region-active
>
> They pass when run in interactive mode (I haven't looked into why).

That seems strange - all tests pass here with M-x ert.  What do you mean
by "batch mode"?

>> What should they look like, then?  Should I make all of them into the
>> ChangeLog format, or just rebase/squash all of them so that there are
>> two of them only (one for the testing tool and one for the
>> beginning-of-defun)?
>
> Yeah, I would go ahead and squash them, since you need to rebase to fix
> commit messages anyway.

Will do.

Thanks,

-- 
Marcin Borkowski





  reply	other threads:[~2017-04-25 11:43 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87o9ydrzkr.fsf@mbork.pl>
     [not found] ` <m2bmu7lwal.fsf@newartisans.com>
     [not found]   ` <87mvdriuss.fsf@mbork.pl>
     [not found]     ` <m2k28v3xp2.fsf@newartisans.com>
     [not found]       ` <87bmu6icea.fsf@mbork.pl>
     [not found]         ` <c04b44ac-8bd4-ecfa-5d2f-492135a067ad@yandex.ru>
     [not found]           ` <m2d1el29yr.fsf@newartisans.com>
2017-02-14 10:45             ` bug#21072: Brave new mark-defun (and a testing tool) Marcin Borkowski
2017-02-14 13:02               ` Dmitry Gutov
     [not found]               ` <52e67f43-edcf-09e3-5fd6-6079763fd234@yandex.ru>
2017-02-14 19:06                 ` Marcin Borkowski
     [not found]                 ` <87tw7wh9sf.fsf@mbork.pl>
     [not found]                   ` <jwvr330wp9a.fsf-monnier+gmane.emacs.devel@gnu.org>
2017-02-15  6:45                     ` Marcin Borkowski
     [not found]                     ` <87k28sdka6.fsf@jane>
2017-02-15  7:56                       ` Stefan Monnier
     [not found]                       ` <jwvh93vopsr.fsf-monnier+Inbox@gnu.org>
2017-02-15 19:18                         ` Marcin Borkowski
2017-02-15 19:27                           ` Stefan Monnier
     [not found]                           ` <jwvbmu3p88m.fsf-monnier+Inbox@gnu.org>
2017-02-16  4:40                             ` Marcin Borkowski
     [not found]                             ` <87bmu2eoji.fsf@jane>
2017-02-16 13:22                               ` Stefan Monnier
2017-02-17  8:54                                 ` Marcin Borkowski
2017-03-07 16:46                                   ` Eli Zaretskii
2017-03-07 16:50                                   ` Dmitry Gutov
2017-03-07 16:53                                     ` Eli Zaretskii
2017-03-29  6:30                                     ` Marcin Borkowski
     [not found]                                     ` <83innlgh95.fsf@gnu.org>
2017-03-29  6:30                                       ` Marcin Borkowski
     [not found]                                   ` <83o9xdghmc.fsf@gnu.org>
2017-03-29  6:34                                     ` Marcin Borkowski
     [not found]                                     ` <87o9wkoald.fsf@jane>
2017-03-31 11:18                                       ` Marcin Borkowski
2017-04-02 20:22                                         ` Glenn Morris
2017-04-07  8:26                                           ` Marcin Borkowski
2017-04-02 22:56                                         ` npostavs
     [not found]                                         ` <87k272wh8x.fsf@users.sourceforge.net>
2017-04-07  8:25                                           ` Marcin Borkowski
2017-04-07 14:41                                             ` Noam Postavsky
2017-04-18 12:35                                               ` Marcin Borkowski
2017-04-18 14:04                                                 ` Drew Adams
2017-04-18 14:38                                                   ` Eli Zaretskii
2017-04-19  0:04                                                 ` npostavs
2017-04-19  0:35                                                   ` John Mastro
2017-04-20  0:47                                                     ` John Mastro
2017-04-20 12:11                                                       ` Marcin Borkowski
2017-04-21 12:24                                                   ` Marcin Borkowski
2017-04-21 12:29                                                     ` Marcin Borkowski
2017-04-22 18:05                                                     ` npostavs
2017-04-24 12:17                                                       ` Marcin Borkowski
2017-04-24 12:52                                                         ` npostavs
2017-04-25 11:43                                                           ` Marcin Borkowski [this message]
2017-04-25 12:13                                                             ` npostavs
2017-04-25 20:49                                                             ` Noam Postavsky
2017-04-27 16:43                                                           ` Marcin Borkowski
2017-04-27 21:48                                                             ` Noam Postavsky
2017-04-30 14:49                                                               ` Marcin Borkowski
2017-04-30 15:19                                                               ` Marcin Borkowski
2017-04-30 16:10                                                                 ` Stefan Monnier
2017-04-30 18:04                                                                   ` Noam Postavsky
2017-04-30 18:46                                                                     ` Stefan Monnier
2017-04-30 19:18                                                                       ` npostavs
2017-04-30 20:09                                                                         ` Stefan Monnier
2017-04-30 21:41                                                                           ` npostavs
2017-04-30 22:03                                                                             ` Stefan Monnier
2017-04-30 22:21                                                                               ` npostavs
2017-05-03 15:20                                                                                 ` Marcin Borkowski
2017-05-03  5:27                                                                   ` Marcin Borkowski
2017-05-03  8:43                                                                     ` Michael Heerdegen
2017-05-03 12:44                                                                     ` Stefan Monnier
2017-05-09 12:39                                                               ` Marcin Borkowski
2017-05-10  2:53                                                                 ` npostavs
2017-05-10  3:15                                                                   ` Stefan Monnier
2017-05-10  3:31                                                                     ` npostavs
2017-05-10 16:31                                                                       ` Eli Zaretskii
2017-05-12  9:42                                                                   ` Marcin Borkowski
2017-05-12 20:32                                                                     ` npostavs
2017-05-14  5:13                                                                     ` Marcin Borkowski
2017-05-15  0:17                                                                       ` Glenn Morris
2017-05-16 22:38                                                                         ` npostavs
2017-05-20 22:30                                                                           ` npostavs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wpa8yaol.fsf@jane \
    --to=mbork@mbork.pl \
    --cc=21072@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=npostavs@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).