* bug#32994: 27.0.50; Regression in image type auto-detection
@ 2018-10-08 22:08 Juri Linkov
2018-10-15 22:33 ` Juri Linkov
0 siblings, 1 reply; 2+ messages in thread
From: Juri Linkov @ 2018-10-08 22:08 UTC (permalink / raw)
To: 32994
Tags: patch
A recent change in image-mode.el broke a useful feature that
automatically detects an image type, so now visiting an image file
without a file extension signals the error "upcase(nil) -
(wrong-type-argument char-or-string-p nil)". This patch fixes it:
diff --git a/lisp/image-mode.el b/lisp/image-mode.el
index 19fa28d440..eb7b410f4a 100644
--- a/lisp/image-mode.el
+++ b/lisp/image-mode.el
@@ -781,8 +785,9 @@ image-toggle-display-image
(defun image--imagemagick-wanted-p (filename)
(and (fboundp 'imagemagick-types)
(not (eq imagemagick-types-inhibit t))
- (not (memq (intern (upcase (file-name-extension filename)) obarray)
- imagemagick-types-inhibit))))
+ (not (and (file-name-extension filename)
+ (memq (intern (upcase (file-name-extension filename)) obarray)
+ imagemagick-types-inhibit)))))
(defun image-toggle-hex-display ()
"Toggle between image and hex display."
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#32994: 27.0.50; Regression in image type auto-detection
2018-10-08 22:08 bug#32994: 27.0.50; Regression in image type auto-detection Juri Linkov
@ 2018-10-15 22:33 ` Juri Linkov
0 siblings, 0 replies; 2+ messages in thread
From: Juri Linkov @ 2018-10-15 22:33 UTC (permalink / raw)
To: 32994-done
> Tags: patch
>
> A recent change in image-mode.el broke a useful feature that
> automatically detects an image type, so now visiting an image file
> without a file extension signals the error "upcase(nil) -
> (wrong-type-argument char-or-string-p nil)". This patch fixes it:
Fixed.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-15 22:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-08 22:08 bug#32994: 27.0.50; Regression in image type auto-detection Juri Linkov
2018-10-15 22:33 ` Juri Linkov
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).