From: Dario Gjorgjevski <dario.gjorgjevski@gmail.com>
To: 36006@debbugs.gnu.org
Subject: bug#36006: electric-pair-mode fails to balance in certain cases
Date: Thu, 30 May 2019 17:11:31 +0200 [thread overview]
Message-ID: <87woi80yfw.fsf@gmail.com> (raw)
Consider the following text in html-mode with electric-pair-mode turned
on and electric-pair-skip-self set to electric-pair-default-skip-self:
<|>
(Take | to denote point.) In this situation, the expected result of
attempting to insert > is to skip over the one immediately after point,
i.e., end up with <>|. However, what we get instead is <>|>. Only if
we *now* attempt to insert >, we end up with <>>|, which doesn't make
any sense.
The same behavior is observed with ordinary parentheses in html-mode,
too.
From my debugging, the culprit seems to be an unnecessary (or mistaken?)
use of electric-pair--with-uncached-syntax. I am not sure *why* exactly
it happens, and would appreciate further insight.
The patch shown below fixes the issue.
diff --git a/lisp/elec-pair.el b/lisp/elec-pair.el
index 5fb9d751e2..6450d02c9e 100644
--- a/lisp/elec-pair.el
+++ b/lisp/elec-pair.el
@@ -325,11 +325,9 @@ electric-pair--balance-info
(cond ((< direction 0)
(condition-case nil
(eq (char-after pos)
- (electric-pair--with-uncached-syntax
- (table)
- (matching-paren
- (char-before
- (scan-sexps (point) 1)))))
+ (matching-paren
+ (char-before
+ (scan-sexps (point) 1))))
(scan-error nil)))
(t
;; In this case, no need to use
--
Dario Gjorgjevski :: <dario.gjorgjevski@gmail.com>
:: 744A 4F0B 4F1C 9371
:: +48 1525 8666837
next reply other threads:[~2019-05-30 15:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 15:11 Dario Gjorgjevski [this message]
2019-05-30 17:36 ` bug#36006: electric-pair-mode fails to balance in certain cases npostavs
2019-05-30 21:51 ` Dario Gjorgjevski
2019-06-06 23:39 ` Noam Postavsky
2019-11-22 12:28 ` Dario Gjorgjevski
2020-08-27 19:08 ` Gregory Heytings via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-08-27 21:38 ` Gregory Heytings via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-08-28 8:00 ` Gregory Heytings via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-10 7:50 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87woi80yfw.fsf@gmail.com \
--to=dario.gjorgjevski@gmail.com \
--cc=36006@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).