From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dario Gjorgjevski Newsgroups: gmane.emacs.bugs Subject: bug#36006: electric-pair-mode fails to balance in certain cases Date: Thu, 30 May 2019 17:11:31 +0200 Message-ID: <87woi80yfw.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="48690"; mail-complaints-to="usenet@blaine.gmane.org" To: 36006@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 30 17:12:15 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hWMj0-000CVE-PU for geb-bug-gnu-emacs@m.gmane.org; Thu, 30 May 2019 17:12:15 +0200 Original-Received: from localhost ([127.0.0.1]:55411 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWMiz-0008EB-3k for geb-bug-gnu-emacs@m.gmane.org; Thu, 30 May 2019 11:12:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60229) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWMis-0008Dt-Fj for bug-gnu-emacs@gnu.org; Thu, 30 May 2019 11:12:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hWMir-0003SU-Kq for bug-gnu-emacs@gnu.org; Thu, 30 May 2019 11:12:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48234) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hWMiq-0003Ro-5R for bug-gnu-emacs@gnu.org; Thu, 30 May 2019 11:12:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hWMin-00067e-RN for bug-gnu-emacs@gnu.org; Thu, 30 May 2019 11:12:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dario Gjorgjevski Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 May 2019 15:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 36006 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.155922910623510 (code B ref -1); Thu, 30 May 2019 15:12:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 30 May 2019 15:11:46 +0000 Original-Received: from localhost ([127.0.0.1]:33545 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWMiX-000677-Va for submit@debbugs.gnu.org; Thu, 30 May 2019 11:11:46 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:45795) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hWMiW-00066q-17 for submit@debbugs.gnu.org; Thu, 30 May 2019 11:11:45 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:40495) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hWMiQ-0003Dp-VE for submit@debbugs.gnu.org; Thu, 30 May 2019 11:11:38 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60177) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hWMiP-0008Bj-V2 for bug-gnu-emacs@gnu.org; Thu, 30 May 2019 11:11:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hWMiP-0003Ch-4Z for bug-gnu-emacs@gnu.org; Thu, 30 May 2019 11:11:37 -0400 Original-Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]:38643) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hWMiO-00036Y-S6 for bug-gnu-emacs@gnu.org; Thu, 30 May 2019 11:11:37 -0400 Original-Received: by mail-ed1-x531.google.com with SMTP id g13so9615815edu.5 for ; Thu, 30 May 2019 08:11:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=5F7xIqpWrZSizk5eIbc06stmrRAcMgkMrWXfYA/vJ+k=; b=EoD2l61kjcVG8Xfyd8AugwFtBEtVS+HjC7V/7qO2VeRiYCNxsi0PBE17G749RAgk4y eebIDGIaXPtKcJYj/k39ZZfV+ole37E0cRuArLyKwSxE5sKNaZ7NFpqm50kgUZwe5MAq JAohNrJ9nCYPzev3Ie7P21GDAbI1pK8t68V8GME+wJE8nAPBBom9SKZjcGD2kbHTXvlj aJ7pKUq/HNl6QhUmWybVKSWtvKzKX1PmvGZ2uq4q1GvUZ0PaI9NQU+8QdNJtPGyuAv6F 3g2zTk4hDD/GqG3OgOs6xU8Q4gXdgoqAsxnKvgpwv433e/qx9Ra1qH6X4dP0Y63t97UP VTAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=5F7xIqpWrZSizk5eIbc06stmrRAcMgkMrWXfYA/vJ+k=; b=EiHWcPNOJLlg8c22clCyWcZ/C/5Q/RePzx2Yp+87oGBUlU+cWIDven/3Gl2isNZHzg lRHnaaYu14mPN3RFzhvTE34OET9yTRWjDDFsXXUl8mFgruk9TnEG8NWK1ju0DHjr7FUc wkmwFQnE+/anjvd8r8r29xpi6rBlNoGZKxrGlJwLrkQySMnOiFlyyVkJ9epwWlisPNsE dfFQAistnsNA/0dyDH75E5Sx6qOmUJWHGeehbqGwl/UDqmgTzdixKl4l9pmC0p7azQb8 oV7ihxUp9Vh50gszAmdM9fIiW5UK8x35ZWMGuobuR0BfkLZLLf2+Kr+pafiNYArmBytn qvsw== X-Gm-Message-State: APjAAAU/U+h20pWNAopkG2a89JxtIDk1BJitwzNUml4a3hO+2Q7YqB5K nguSMGzNBuR1AH4S8C4AutvThNWycJQ= X-Google-Smtp-Source: APXvYqxVmZuGWnUUrRNpZPhXveaNLCcWPylg6HKZLLgoSO3yC2FD593e+K66f8lxNMoaTsz7vXgvAQ== X-Received: by 2002:a50:9785:: with SMTP id e5mr5222483edb.94.1559229093201; Thu, 30 May 2019 08:11:33 -0700 (PDT) Original-Received: from dario-XPS-13-9370 (cable-158-181-75-126.cust.telecolumbus.net. [158.181.75.126]) by smtp.gmail.com with ESMTPSA id y5sm804450edd.49.2019.05.30.08.11.32 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 May 2019 08:11:32 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159924 Archived-At: Consider the following text in html-mode with electric-pair-mode turned on and electric-pair-skip-self set to electric-pair-default-skip-self: <|> (Take | to denote point.) In this situation, the expected result of attempting to insert > is to skip over the one immediately after point, i.e., end up with <>|. However, what we get instead is <>|>. Only if we *now* attempt to insert >, we end up with <>>|, which doesn't make any sense. The same behavior is observed with ordinary parentheses in html-mode, too. >From my debugging, the culprit seems to be an unnecessary (or mistaken?) use of electric-pair--with-uncached-syntax. I am not sure *why* exactly it happens, and would appreciate further insight. The patch shown below fixes the issue. diff --git a/lisp/elec-pair.el b/lisp/elec-pair.el index 5fb9d751e2..6450d02c9e 100644 --- a/lisp/elec-pair.el +++ b/lisp/elec-pair.el @@ -325,11 +325,9 @@ electric-pair--balance-info (cond ((< direction 0) (condition-case nil (eq (char-after pos) - (electric-pair--with-uncached-syntax - (table) - (matching-paren - (char-before - (scan-sexps (point) 1))))) + (matching-paren + (char-before + (scan-sexps (point) 1)))) (scan-error nil))) (t ;; In this case, no need to use -- Dario Gjorgjevski :: :: 744A 4F0B 4F1C 9371 :: +48 1525 8666837