unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#36654: Docview: show current zoom % in the modeline bar
@ 2019-07-14 11:50 積丹尼 Dan Jacobson
  2019-07-18 18:34 ` Tassilo Horn
  0 siblings, 1 reply; 4+ messages in thread
From: 積丹尼 Dan Jacobson @ 2019-07-14 11:50 UTC (permalink / raw)
  To: 36654

       + runs the command doc-view-enlarge (found in doc-view-mode-map),
       which is an interactive compiled Lisp function in ‘doc-view.el’.

OK good, but those plus and minuses should put the current zoom scale
(200%, etc.) into the mode line. (Plenty of room there.)
In fact perhaps start by showing "100%" there even before we start zooming.

(Please do something to make it look different to the user than the
"what percent of the file am I looking at" item in the modeline (even if
not ever present at the same time.) Maybe say: "Zoom 55%".)





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#36654: Docview: show current zoom % in the modeline bar
  2019-07-14 11:50 bug#36654: Docview: show current zoom % in the modeline bar 積丹尼 Dan Jacobson
@ 2019-07-18 18:34 ` Tassilo Horn
  2019-07-19  2:28   ` 積丹尼 Dan Jacobson
  0 siblings, 1 reply; 4+ messages in thread
From: Tassilo Horn @ 2019-07-18 18:34 UTC (permalink / raw)
  To: 積丹尼 Dan Jacobson; +Cc: 36654

積丹尼 Dan Jacobson <jidanni@jidanni.org> writes:

Hi Dan,

>        + runs the command doc-view-enlarge (found in doc-view-mode-map),
>        which is an interactive compiled Lisp function in ‘doc-view.el’.
>
> OK good, but those plus and minuses should put the current zoom scale
> (200%, etc.) into the mode line. (Plenty of room there.)  In fact
> perhaps start by showing "100%" there even before we start zooming.
>
> (Please do something to make it look different to the user than the
> "what percent of the file am I looking at" item in the modeline (even
> if not ever present at the same time.) Maybe say: "Zoom 55%".)

I'd argue that the percentage is not interesting at all.  I mean, what
you want is a level of scaling that makes the text good to read for your
eyes, no matter if that's 55% or 200%.  Who cares?

And I actually don't know what a zoom level of 100% should be.  The
initial size when opening a document for the first time?  That depends
on `doc-view-resolution'...

Bye,
Tassilo





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#36654: Docview: show current zoom % in the modeline bar
  2019-07-18 18:34 ` Tassilo Horn
@ 2019-07-19  2:28   ` 積丹尼 Dan Jacobson
  2019-07-19  7:20     ` Tassilo Horn
  0 siblings, 1 reply; 4+ messages in thread
From: 積丹尼 Dan Jacobson @ 2019-07-19  2:28 UTC (permalink / raw)
  To: Tassilo Horn; +Cc: 36654

Well all I know is gv(1), firefox(1), chromium(1) all show the new "xx%"
every time one zooms or unzooms, if not permanently shown on their
panels, then at least on a brief popup.





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#36654: Docview: show current zoom % in the modeline bar
  2019-07-19  2:28   ` 積丹尼 Dan Jacobson
@ 2019-07-19  7:20     ` Tassilo Horn
  0 siblings, 0 replies; 4+ messages in thread
From: Tassilo Horn @ 2019-07-19  7:20 UTC (permalink / raw)
  To: 積丹尼 Dan Jacobson; +Cc: 36654-done

Tags: wontfix

積丹尼 Dan Jacobson <jidanni@jidanni.org> writes:

> Well all I know is gv(1), firefox(1), chromium(1) all show the new
> "xx%" every time one zooms or unzooms, if not permanently shown on
> their panels, then at least on a brief popup.

Yes, right.  However, DocView just shows just images converted from the
document.  It has no clue about the original document's paper size,
e.g., US Letter, DIN A4, etc.  So it's not really feasilble to show a
meaningful percentage without using external tools to query that
information.

I'm assuming that with usual document readers a zoom level of 100% means
"Assuming you configured the correct DPI for you monitor [which, I
guess, almost nobody has], the document is displayed in the same size as
if it were printed out on a sheet of paper of the right dimensions".

Of course, we could simply say the initial size of the images when
opening a document is 100% and then change that when zooming.  That
would match my above assumption if `doc-view-resolution' is set to your
monitor's DPI.

However, DocView has two ways of zooming: if emacs is built with
ImageMagick support and `doc-view-scale-internally' is t, the images are
scaled dynamically, otherwise the document is reconverted with a changed
setting of `doc-view-resolution'.  So if you use emacs with ImageMagick
support, you'd usually configure a higher `doc-view-resolution' value in
order to improve the image quality when scaling dynamically.  But then
the "same size as printout" assumption is moot.

And without ImageMagick support, the recipe

  1) Open doc, zoom level indicator shows 100%
  2) Zoom in, zoom level indicator shows, e.g., 110%
  3) Kill buffer
  4) Find doc again, zoom level indicator shows 100%

would show a larger doc in step 4 than in step 1 although the zoom level
is 100% in both cases.  This is because DocView caches the images and
the corresponding resolution in a temporary directory.  Well, of course
it could also save more information on the initial conversion run so
that step 4 would result in 110%, but I think such a feature wouldn't be
worth the effort.

Therefore, I'm closing this issue as wontfix.

Bye,
Tassilo





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-07-19  7:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-14 11:50 bug#36654: Docview: show current zoom % in the modeline bar 積丹尼 Dan Jacobson
2019-07-18 18:34 ` Tassilo Horn
2019-07-19  2:28   ` 積丹尼 Dan Jacobson
2019-07-19  7:20     ` Tassilo Horn

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).