* bug#37874: 27.0.50; A recent commit broke doc-view (and pdf-tools)
@ 2019-10-22 18:27 Andreas Politz
2019-10-23 18:49 ` bug#37874: AW: Re: bug#37578: closed (Re: bug#37578: 26.3; image-mode does not display the bottom edge of a tall image) Andreas Politz
0 siblings, 1 reply; 5+ messages in thread
From: Andreas Politz @ 2019-10-22 18:27 UTC (permalink / raw)
To: 37874
Since commit 9c66b09950cf2db50eb6d818656a268ef750bfe6 image-next-line
returns the current window-vscroll as a unit of pixels. Before, it was
returning it in terms of character-height. This breaks multiple
functions in doc-view, which are comparing those values to the value of
(window-vscroll). If this change is going to stay doc-view.el needs to
be adapted as well.
-ap
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#37874: AW: Re: bug#37578: closed (Re: bug#37578: 26.3; image-mode does not display the bottom edge of a tall image)
2019-10-22 18:27 bug#37874: 27.0.50; A recent commit broke doc-view (and pdf-tools) Andreas Politz
@ 2019-10-23 18:49 ` Andreas Politz
2019-10-23 18:56 ` bug#37578: " Tassilo Horn
0 siblings, 1 reply; 5+ messages in thread
From: Andreas Politz @ 2019-10-23 18:49 UTC (permalink / raw)
To: Eli Zaretskii, Tassilo Horn; +Cc: 37874, 37578
[-- Attachment #1: Type: text/plain, Size: 150 bytes --]
I have already adapted my package in a branch. And I think the required changes are straightforward. I suppose the same holds for doc-view.
Andreas
[-- Attachment #2: Type: text/html, Size: 285 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#37578: AW: Re: bug#37578: closed (Re: bug#37578: 26.3; image-mode does not display the bottom edge of a tall image)
2019-10-23 18:49 ` bug#37874: AW: Re: bug#37578: closed (Re: bug#37578: 26.3; image-mode does not display the bottom edge of a tall image) Andreas Politz
@ 2019-10-23 18:56 ` Tassilo Horn
2019-10-23 19:01 ` Eli Zaretskii
0 siblings, 1 reply; 5+ messages in thread
From: Tassilo Horn @ 2019-10-23 18:56 UTC (permalink / raw)
To: Andreas Politz, Eli Zaretskii; +Cc: 37874, 37578
On October 23, 2019 8:49:17 PM Andreas Politz <politza@hochschule-trier.de>
wrote:
> I have already adapted my package in a branch. And I think the required
> changes are straightforward. I suppose the same holds for doc-view.
Ok, great. I'll adapt doc-view.el ASAP and then close this issue. Thanks
for your report.
Bye,
Tassilo
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#37578: AW: Re: bug#37578: closed (Re: bug#37578: 26.3; image-mode does not display the bottom edge of a tall image)
2019-10-23 18:56 ` bug#37578: " Tassilo Horn
@ 2019-10-23 19:01 ` Eli Zaretskii
2019-10-25 20:23 ` bug#37874: " Tassilo Horn
0 siblings, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2019-10-23 19:01 UTC (permalink / raw)
To: Tassilo Horn; +Cc: 37874, 37578, politza
> From: Tassilo Horn <tsdh@gnu.org>
> CC: <37578@debbugs.gnu.org>, <37874@debbugs.gnu.org>
> Date: Wed, 23 Oct 2019 20:56:48 +0200
>
> On October 23, 2019 8:49:17 PM Andreas Politz <politza@hochschule-trier.de>
> wrote:
>
> > I have already adapted my package in a branch. And I think the required
> > changes are straightforward. I suppose the same holds for doc-view.
>
> Ok, great. I'll adapt doc-view.el ASAP and then close this issue. Thanks
> for your report.
Thanks, and sorry again for not being more vigilant.
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#37874: AW: Re: bug#37578: closed (Re: bug#37578: 26.3; image-mode does not display the bottom edge of a tall image)
2019-10-23 19:01 ` Eli Zaretskii
@ 2019-10-25 20:23 ` Tassilo Horn
0 siblings, 0 replies; 5+ messages in thread
From: Tassilo Horn @ 2019-10-25 20:23 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 37874-done, 37578, politza
Eli Zaretskii <eliz@gnu.org> writes:
>> > I have already adapted my package in a branch. And I think the
>> > required changes are straightforward. I suppose the same holds for
>> > doc-view.
>>
>> Ok, great. I'll adapt doc-view.el ASAP and then close this
>> issue. Thanks for your report.
I've fixed doc-view just now (bug#37874) with commit a0f7ea5999.
> Thanks, and sorry again for not being more vigilant.
You're welcome,
Tassilo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-10-25 20:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-22 18:27 bug#37874: 27.0.50; A recent commit broke doc-view (and pdf-tools) Andreas Politz
2019-10-23 18:49 ` bug#37874: AW: Re: bug#37578: closed (Re: bug#37578: 26.3; image-mode does not display the bottom edge of a tall image) Andreas Politz
2019-10-23 18:56 ` bug#37578: " Tassilo Horn
2019-10-23 19:01 ` Eli Zaretskii
2019-10-25 20:23 ` bug#37874: " Tassilo Horn
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).