bug#33197: 26.1; cc-mode enum indentation

bug#33197: 26.1; cc-mode enum indentation

[Ota, Takaaki]

The enum indentation in cc-mode used to look like this.

	  enum {
	    pDlen = sizeof pD - 1,
	    pIlen = sizeof pI - 1,
	    pMlen = sizeof pMd - 2
	  };
	  enum {
	    no_modifier, long_modifier, pD_modifier, pI_modifier, pM_modifier
	  } length_modifier = no_modifier;

This is a portion of doprnt.c in the current 26.1 source code.  But
now the 26.1 cc-mode indents like this

	  enum {
                pDlen = sizeof pD - 1,
                pIlen = sizeof pI - 1,
                pMlen = sizeof pMd - 2
	  };
	  enum {
                no_modifier, long_modifier, pD_modifier, pI_modifier, pM_modifier
	  } length_modifier = no_modifier;

If the enum has a long name before the open brace it looks even worse
by wasting a lot of unnecessary spaces.

	  enum some_long_enum_type_name {
                                         pDlen = sizeof pD - 1,
                                         pIlen = sizeof pI - 1,
                                         pMlen = sizeof pMd - 2
	  };
	  enum another_long_enum_type_name {
                                            no_modifier, long_modifier, pD_modifier, pI_modifier, pM_modifier
	  } length_modifier = no_modifier;

Please consider bringing it back to how it used to be.

-Tak

bug#33197: 26.1; cc-mode enum indentation

[Lars Ingebrigtsen]

"Ota, Takaaki" <Takaaki.Ota@sony.com> writes:

> The enum indentation in cc-mode used to look like this.
>
> 	  enum {
> 	    pDlen = sizeof pD - 1,
> 	    pIlen = sizeof pI - 1,
> 	    pMlen = sizeof pMd - 2
> 	  };
> 	  enum {
> 	    no_modifier, long_modifier, pD_modifier, pI_modifier, pM_modifier
> 	  } length_modifier = no_modifier;
>
> This is a portion of doprnt.c in the current 26.1 source code.  But
> now the 26.1 cc-mode indents like this
>
> 	  enum {
>                 pDlen = sizeof pD - 1,
>                 pIlen = sizeof pI - 1,
>                 pMlen = sizeof pMd - 2
> 	  };

I tested this in Emacs 27.1 and Emacs 28, and they both indent this code
like in the first example.

Are you still seeing this issue in Emacs 27?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#33197: 26.1; cc-mode enum indentation

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> I tested this in Emacs 27.1 and Emacs 28, and they both indent this code
> like in the first example.

I build Emacs 26.1 and tested there, and I could indeed see the bug you
describe.

So it looks like it's been fixed in Emacs 27, and I'm closing this bug
report.  If it's still an issue, please respond to the debbugs address
and we'll reopen.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no