From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: dalanicolai <dalanicolai@gmail.com>
Cc: 45417@debbugs.gnu.org
Subject: bug#45417: 28.0.50; vcard-parse-buffer only parses single card
Date: Fri, 25 Dec 2020 21:44:38 -0800 [thread overview]
Message-ID: <87wnx5unnd.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <CACJP=3nsQXW5G32oKmdRXP6vcm6QMK7QZ8_4PPeS88bn=RDZsg@mail.gmail.com> (dalanicolai's message of "Fri, 25 Dec 2020 07:30:17 +0100")
dalanicolai <dalanicolai@gmail.com> writes:
> Install vcard via list-packages.
> Insert following lines (vcard file example, from google contacts export)
> in a buffer:
>
> BEGIN:VCARD
> VERSION:3.0
> TEL;TYPE=CELL:+00 000 00 00 00
> CATEGORIES:myContacts
> end:VCARD
> BEGIN:VCARD
> VERSION:3.0
> TEL;TYPE=WORK:000 000 0000
> CATEGORIES:myContacts
> END:VCARD
>
> in the buffer evaluate (M-:): (vcard-parse-buffer)
>
> it will stop after the first card.
>
> SOLUTION: in the function `vcard-parse-buffer`, (line-end-position 2)
> should be replaced by (+ (line-end-position 2) 1)
Whoops! I've been running with a few local patches and didn't realize
I hadn't committed this fix. `vcard-parse-card' was supposed to end with
a final `forward-line', to get past the "END:VCARD" line, and I'll push
version 0.1.1 with this change in a moment.
I'm glad someone's actually using this library! Please feel free to
report further bugs and feature requests, and maybe cc me if you do.
In particular I'm trying to decide how useful it actually is to provide
`vcard-parse-(property|card)-consumer-function' options, and I would be
interested to hear opinions about this. I'm also planning on
re-implementing parsing using syntax tables, which I hope will make it
faster.
Thanks,
Eric
prev parent reply other threads:[~2020-12-26 5:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-25 6:30 bug#45417: 28.0.50; vcard-parse-buffer only parses single card dalanicolai
2020-12-25 22:18 ` Lars Ingebrigtsen
2020-12-26 5:47 ` Eric Abrahamsen
2020-12-26 5:52 ` Lars Ingebrigtsen
2020-12-26 13:09 ` dalanicolai
2020-12-26 5:44 ` Eric Abrahamsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnx5unnd.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=45417@debbugs.gnu.org \
--cc=dalanicolai@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).