From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#45417: 28.0.50; vcard-parse-buffer only parses single card Date: Fri, 25 Dec 2020 21:44:38 -0800 Message-ID: <87wnx5unnd.fsf@ericabrahamsen.net> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23291"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 45417@debbugs.gnu.org To: dalanicolai Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 26 06:45:22 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kt2OH-0005wb-Dx for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 26 Dec 2020 06:45:21 +0100 Original-Received: from localhost ([::1]:58310 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kt2OF-00086z-Ut for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 26 Dec 2020 00:45:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46018) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kt2O0-00086s-EZ for bug-gnu-emacs@gnu.org; Sat, 26 Dec 2020 00:45:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47083) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kt2Ny-0001TP-GG for bug-gnu-emacs@gnu.org; Sat, 26 Dec 2020 00:45:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kt2Ny-0005tC-DM for bug-gnu-emacs@gnu.org; Sat, 26 Dec 2020 00:45:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Dec 2020 05:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45417 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 45417-submit@debbugs.gnu.org id=B45417.160896149322607 (code B ref 45417); Sat, 26 Dec 2020 05:45:02 +0000 Original-Received: (at 45417) by debbugs.gnu.org; 26 Dec 2020 05:44:53 +0000 Original-Received: from localhost ([127.0.0.1]:58629 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kt2No-0005sY-ON for submit@debbugs.gnu.org; Sat, 26 Dec 2020 00:44:52 -0500 Original-Received: from ericabrahamsen.net ([52.70.2.18]:50830 helo=mail.ericabrahamsen.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kt2Nm-0005sM-U0 for 45417@debbugs.gnu.org; Sat, 26 Dec 2020 00:44:51 -0500 Original-Received: from localhost (c-73-254-86-141.hsd1.wa.comcast.net [73.254.86.141]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id AE40DFA22B; Sat, 26 Dec 2020 05:44:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1608961484; bh=k1dTwZfUAiRai6Gu8pBMY5KZScaX+aIkfZYzkZZwwXE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=uJVFwu1qyVD0fFoGu/tE0IuhpC2pPSCIbJlB+ntbnKaBvmg61j5TaKNpNtXCTZlPA PWCMoPK42yimdBfE93Ez7uUqCKPu4XmNkLpgCmems3944nUEDb35/eSmC9ZfK8ZZuD 0moMxzTqOG7DGwG85HUNABhES2TcowM2LJLUj45s= In-Reply-To: (dalanicolai's message of "Fri, 25 Dec 2020 07:30:17 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196746 Archived-At: dalanicolai writes: > Install vcard via list-packages. > Insert following lines (vcard file example, from google contacts export) > in a buffer: > > BEGIN:VCARD > VERSION:3.0 > TEL;TYPE=CELL:+00 000 00 00 00 > CATEGORIES:myContacts > end:VCARD > BEGIN:VCARD > VERSION:3.0 > TEL;TYPE=WORK:000 000 0000 > CATEGORIES:myContacts > END:VCARD > > in the buffer evaluate (M-:): (vcard-parse-buffer) > > it will stop after the first card. > > SOLUTION: in the function `vcard-parse-buffer`, (line-end-position 2) > should be replaced by (+ (line-end-position 2) 1) Whoops! I've been running with a few local patches and didn't realize I hadn't committed this fix. `vcard-parse-card' was supposed to end with a final `forward-line', to get past the "END:VCARD" line, and I'll push version 0.1.1 with this change in a moment. I'm glad someone's actually using this library! Please feel free to report further bugs and feature requests, and maybe cc me if you do. In particular I'm trying to decide how useful it actually is to provide `vcard-parse-(property|card)-consumer-function' options, and I would be interested to hear opinions about this. I'm also planning on re-implementing parsing using syntax tables, which I hope will make it faster. Thanks, Eric