From: Lars Ingebrigtsen <larsi@gnus.org>
To: Juri Linkov <juri@linkov.net>
Cc: "David M. Koppelman" <koppel@ece.lsu.edu>, 51101@debbugs.gnu.org
Subject: bug#51101: 29.0.50; read-char-from-minibuffer accepts Enter even when not a choice.
Date: Sun, 10 Oct 2021 22:06:56 +0200 [thread overview]
Message-ID: <87wnmkmyov.fsf@gnus.org> (raw)
In-Reply-To: <87h7dpc7e0.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 10 Oct 2021 20:31:31 +0300")
Juri Linkov <juri@linkov.net> writes:
> Maybe it works here because ask-user-about-supersession-threat
> is called from C with some flag that disables signaling 'quit'.
> But when trying to type RET after (y-or-n-p "Answer y or n: ")
> it terminates with the 'quit' signal. And indeed in the map
> used by y-or-n-p, RET is bound to 'exit':
>
> (define-key query-replace-map "\r" 'exit)
I must have tested this in the wrong version of Emacs -- I thought I was
testing y-or-n-p in Emacs 26.3 to see what it did there, but I must have
started a more recent version instead.
> I noticed the recent commit ec9f25bd356c7c81d94c78f11100b97d6d52ce97
> saying that RET means "yes" in y-or-n-p. But anyway since RET
> now does the same that read-char-choice-with-read-key does,
> so I removed mentions of RET from the doc string. Or should
> the fixed behavior be mentioned?
No, that's fine.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2021-10-10 20:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-08 20:19 bug#51101: 29.0.50; read-char-from-minibuffer accepts Enter even when not a choice David M. Koppelman
2021-10-09 13:09 ` Lars Ingebrigtsen
2021-10-09 15:02 ` David Koppelman
2021-10-10 17:31 ` Juri Linkov
2021-10-10 20:06 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnmkmyov.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=51101@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=koppel@ece.lsu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).