From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#51101: 29.0.50; read-char-from-minibuffer accepts Enter even when not a choice. Date: Sun, 10 Oct 2021 22:06:56 +0200 Message-ID: <87wnmkmyov.fsf@gnus.org> References: <877demny4b.fsf@gnus.org> <87h7dpc7e0.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38540"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: "David M. Koppelman" , 51101@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 10 22:08:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mZf7K-0009q0-J6 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Oct 2021 22:08:18 +0200 Original-Received: from localhost ([::1]:53538 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mZf7I-0003KT-Lk for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Oct 2021 16:08:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42018) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mZf74-00038R-VA for bug-gnu-emacs@gnu.org; Sun, 10 Oct 2021 16:08:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44339) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mZf74-0007O8-Mb for bug-gnu-emacs@gnu.org; Sun, 10 Oct 2021 16:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mZf74-0007w7-Dx for bug-gnu-emacs@gnu.org; Sun, 10 Oct 2021 16:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Oct 2021 20:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51101 X-GNU-PR-Package: emacs Original-Received: via spool by 51101-submit@debbugs.gnu.org id=B51101.163389642830441 (code B ref 51101); Sun, 10 Oct 2021 20:08:02 +0000 Original-Received: (at 51101) by debbugs.gnu.org; 10 Oct 2021 20:07:08 +0000 Original-Received: from localhost ([127.0.0.1]:55885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZf6C-0007uu-9K for submit@debbugs.gnu.org; Sun, 10 Oct 2021 16:07:08 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:47310) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mZf6A-0007uR-Mn for 51101@debbugs.gnu.org; Sun, 10 Oct 2021 16:07:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DgSaACfv2fm6FFSP/NuT/v8iS3Gc5BLe8djfiaDCK5c=; b=XxtDPsLblTdsqgMvu+hrzCA4VB Cm6t4ZCpYwfII6Nmg7p0gXhtUtrwqi9ddqeqI5kFFN7VRX3mYyvjOoIgaAXtsb7VeFblW5zdVmL/U CTq3vzhLvShXgL4MFDQZxtoqVHHWhsokM2qa5Alza2maLYX9DJ5AFmIeLcD8ppkgINAo=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mZf60-0003E0-Q6; Sun, 10 Oct 2021 22:06:59 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEURGCBEU15reIR2 h5SaprH////6wHPaAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+UKChQFH0QAKkgAAAHBSURBVDjLrVNt lsMgCIw9gZAeoGAvEPACW7n/mXY02qb7e3nJS3QcGD7ctn+2vCW859/FiPJGOQ/sAiQAlPGk7bGl fD2vdL6dmC4ASyJyYqZO/nhiYlUKds6UOkCLQLsbvW6heccCMiaDmldD9DjI005gLVctGgAOEkMo HFmMGiaUby8+aH8JkZzAwV4EvjkdRk+DjsloqjZyYDk4iipPIIStZ7eH5L05kAX8wFcNjmgl3NUk n9ljY6/xjGGlma8YWGqrNvbbsyHXqapEmNafQbHaXGWmzqVvvbhGDUUNhCZAjNBwV2s0D7d3Hqxd FPSMKA7GbBYVh1U8rTbgecYGAwji9E2rZsJ59UNVS3eiVd1sieqdJSrdOfrlzvIeByZg0qtlYPC7 6RicQdKC+pmu0GcM+FGtSFr5ChT1Hr82Ef146vPGkKJIUHjPl7lKQISqRzswIJ9JxIypoosFLfq+ AmnIRRT/BjIGSaBZ6JPaJ5HUP2P6HinJUtCBMZjpduSbYurj8efG7dRvVKK3z9madG+at3t7bEv1 7SzRiaeD6HE/j97b+E4X+ZmeU/ldpgrUYdzddUf3lWq+1mTbvhf/b7/Nq1BgINOsrAAAACV0RVh0 ZGF0ZTpjcmVhdGUAMjAyMS0xMC0xMFQyMDowNTozMSswMDowMNbK8YkAAAAldEVYdGRhdGU6bW9k aWZ5ADIwMjEtMTAtMTBUMjA6MDU6MzErMDA6MDCnl0k1AAAAAElFTkSuQmCC X-Now-Playing: Cocteau Twins's _Treasure_: "Donimo" In-Reply-To: <87h7dpc7e0.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 10 Oct 2021 20:31:31 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:216831 Archived-At: Juri Linkov writes: > Maybe it works here because ask-user-about-supersession-threat > is called from C with some flag that disables signaling 'quit'. > But when trying to type RET after (y-or-n-p "Answer y or n: ") > it terminates with the 'quit' signal. And indeed in the map > used by y-or-n-p, RET is bound to 'exit': > > (define-key query-replace-map "\r" 'exit) I must have tested this in the wrong version of Emacs -- I thought I was testing y-or-n-p in Emacs 26.3 to see what it did there, but I must have started a more recent version instead. > I noticed the recent commit ec9f25bd356c7c81d94c78f11100b97d6d52ce97 > saying that RET means "yes" in y-or-n-p. But anyway since RET > now does the same that read-char-choice-with-read-key does, > so I removed mentions of RET from the doc string. Or should > the fixed behavior be mentioned? No, that's fine. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no