unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "J.P." <jp@neverwas.me>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: Lin Jian <jlin.dev@outlook.com>, 54343@debbugs.gnu.org
Subject: bug#54343: 28.0.91; find-function goes to a wrong place for erc
Date: Sat, 12 Mar 2022 16:53:14 -0800	[thread overview]
Message-ID: <87wngyad1h.fsf@neverwas.me> (raw)
In-Reply-To: <87h783ys33.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 12 Mar 2022 18:54:24 +0100")

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Lin Jian <jlin.dev@outlook.com> writes:
>
>> steps to reproduce this bug:
>>
>> step 1: run: emacs -Q
>> step 2: eval (find-function 'erc)
>> step 3: the point goes to the defgroup of erc instead of the cl-defun of
>> it, which I think is wrong
>
> I've now fixed this in Emacs 29.

Fantastic. What you did is much less invasive.

So, just to summarize the new behavior re generics, if I do

  (find-function 'xref-location-marker)

it jumps to the first method definition in xref.el, whereas it used to
end up on a defgeneric higher up in the same file, if present. But if
there's no method in the file (as with `xref-backend-definitions', for
example), the behavior remains unchanged. Probably not newsworthy
enough, but just thought I'd state it for the record.

Thanks.

P.S. OK to install #53617 duplicate checks in erc--switch-to-buffer?





  reply	other threads:[~2022-03-13  0:53 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-11 19:57 bug#54343: 28.0.91; find-function goes to a wrong place for erc Lin Jian
2022-03-12  0:16 ` J.P.
2022-03-12  1:48   ` Michael Heerdegen
2022-03-12  3:59     ` F. Jason Park
2022-03-12  8:27   ` J.P.
2022-03-12 17:54 ` Lars Ingebrigtsen
2022-03-13  0:53   ` J.P. [this message]
2022-03-13  0:59     ` Lars Ingebrigtsen
2022-03-13  3:09       ` J.P.
2022-03-13 14:10         ` Lars Ingebrigtsen
2022-03-13 20:12           ` J.P.
2022-03-13 20:16             ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wngyad1h.fsf@neverwas.me \
    --to=jp@neverwas.me \
    --cc=54343@debbugs.gnu.org \
    --cc=jlin.dev@outlook.com \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).