From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#54343: 28.0.91; find-function goes to a wrong place for erc Date: Sat, 12 Mar 2022 16:53:14 -0800 Message-ID: <87wngyad1h.fsf@neverwas.me> References: <87h783ys33.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21054"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Lin Jian , 54343@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 13 01:54:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nTCUx-0005JB-55 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Mar 2022 01:54:15 +0100 Original-Received: from localhost ([::1]:47490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nTCUv-0006hr-Qt for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Mar 2022 19:54:13 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45022) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nTCUk-0006hj-1E for bug-gnu-emacs@gnu.org; Sat, 12 Mar 2022 19:54:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47306) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nTCUj-0000Yj-LI for bug-gnu-emacs@gnu.org; Sat, 12 Mar 2022 19:54:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nTCUj-0006oN-Km for bug-gnu-emacs@gnu.org; Sat, 12 Mar 2022 19:54:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Mar 2022 00:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54343 X-GNU-PR-Package: emacs Original-Received: via spool by 54343-submit@debbugs.gnu.org id=B54343.164713281026144 (code B ref 54343); Sun, 13 Mar 2022 00:54:01 +0000 Original-Received: (at 54343) by debbugs.gnu.org; 13 Mar 2022 00:53:30 +0000 Original-Received: from localhost ([127.0.0.1]:41203 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTCUD-0006na-OQ for submit@debbugs.gnu.org; Sat, 12 Mar 2022 19:53:29 -0500 Original-Received: from mail-108-mta199.mxroute.com ([136.175.108.199]:35965) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nTCUB-0006nN-ID for 54343@debbugs.gnu.org; Sat, 12 Mar 2022 19:53:28 -0500 Original-Received: from filter006.mxroute.com ([140.82.40.27] 140.82.40.27.vultrusercontent.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta199.mxroute.com (ZoneMTA) with ESMTPSA id 17f80c3e86f000763e.001 for <54343@debbugs.gnu.org> (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Sun, 13 Mar 2022 00:53:17 +0000 X-Zone-Loop: d530ede1c3bb24bc19d945c1c1e2e105f6af86aef2a5 X-Originating-IP: [140.82.40.27] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Qjt9G6leeeWpnsfbA5UWDJt8p9D8ncUfmG1vFgR4LGk=; b=nsr7WV7SYnv89D91rWqnBR+mzl U0mM3vKM9KiIh7IWZpqJww+uZ/3PJ0Dv7M4uG0EWs55bI6OTXE3lrE1bo8YSVEAJhA8GpLfOmmtac OVU5vH8DZSalbrjHEcQ/afWuKqtuMhIph0f8LLlEh8G1JU6dwUuFSoMkKywvC3n2JEXqll0JwF828 nVqqiHGmpVZMwzwCCzue1ZyJgDbS062f43w8xm4gFr6hbBKktG2lzKnH3gPUhCEZcwPTiD2UrT858 31i6m+x5bMVitW+Ibk+KAucjSjJk0k50+G0VsaYcujPy4zMZyq4I52oHgqM9CFXpKwug3TghPER1y ECUq+OkA==; In-Reply-To: <87h783ys33.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 12 Mar 2022 18:54:24 +0100") X-AuthUser: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228270 Archived-At: Lars Ingebrigtsen writes: > Lin Jian writes: > >> steps to reproduce this bug: >> >> step 1: run: emacs -Q >> step 2: eval (find-function 'erc) >> step 3: the point goes to the defgroup of erc instead of the cl-defun of >> it, which I think is wrong > > I've now fixed this in Emacs 29. Fantastic. What you did is much less invasive. So, just to summarize the new behavior re generics, if I do (find-function 'xref-location-marker) it jumps to the first method definition in xref.el, whereas it used to end up on a defgeneric higher up in the same file, if present. But if there's no method in the file (as with `xref-backend-definitions', for example), the behavior remains unchanged. Probably not newsworthy enough, but just thought I'd state it for the record. Thanks. P.S. OK to install #53617 duplicate checks in erc--switch-to-buffer?