* bug#14816: 24.3.50.1; ispell remember position, feature request
@ 2013-07-08 6:06 Andreas Röhler
2022-05-10 14:24 ` Lars Ingebrigtsen
0 siblings, 1 reply; 7+ messages in thread
From: Andreas Röhler @ 2013-07-08 6:06 UTC (permalink / raw)
To: 14816
When ispell process ends, user might want to jump to last position
where checking was done.
See
http://stackoverflow.com/questions/17510249/emacs-ispell-goto-previous-word
Don't see it's possible for now.
Implementation would be trivial.
In ispell.el
defun ispell-process-line
line 3572
(goto-char word-start)
knows position of last ispell.
Store it in a suitable defvared variable, so it's accessible
when ispell ends.
Afterwards a command ispell-goto-last-position might jump there.
Thanks,
Andreas
GNU Emacs 24.3.50.1 (i686-pc-linux-gnu, GTK+ Version 2.24.10) of 2013-07-06
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#14816: 24.3.50.1; ispell remember position, feature request
2013-07-08 6:06 bug#14816: 24.3.50.1; ispell remember position, feature request Andreas Röhler
@ 2022-05-10 14:24 ` Lars Ingebrigtsen
2022-05-10 17:16 ` Eli Zaretskii
0 siblings, 1 reply; 7+ messages in thread
From: Lars Ingebrigtsen @ 2022-05-10 14:24 UTC (permalink / raw)
To: Andreas Röhler; +Cc: 14816
Andreas Röhler <andreas.roehler@easy-emacs.de> writes:
> When ispell process ends, user might want to jump to last position
> where checking was done.
I've now fixed this in Emacs 29 -- but instead of adding a special
command/user option, I just made it push the location of the final word
to the mark ring, so that `C-x C-x' can skip back to it.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#14816: 24.3.50.1; ispell remember position, feature request
2022-05-10 14:24 ` Lars Ingebrigtsen
@ 2022-05-10 17:16 ` Eli Zaretskii
2022-05-11 11:46 ` Lars Ingebrigtsen
0 siblings, 1 reply; 7+ messages in thread
From: Eli Zaretskii @ 2022-05-10 17:16 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 14816, andreas.roehler
> Cc: 14816@debbugs.gnu.org
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Tue, 10 May 2022 16:24:44 +0200
>
> Andreas Röhler <andreas.roehler@easy-emacs.de> writes:
>
> > When ispell process ends, user might want to jump to last position
> > where checking was done.
>
> I've now fixed this in Emacs 29 -- but instead of adding a special
> command/user option, I just made it push the location of the final word
> to the mark ring, so that `C-x C-x' can skip back to it.
This changeset changes the form of the return value of
ispell-process-line, so shouldn't that at least appear in
incompatible changes in NEWS (if not done in some more compatible
way)?
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#14816: 24.3.50.1; ispell remember position, feature request
2022-05-10 17:16 ` Eli Zaretskii
@ 2022-05-11 11:46 ` Lars Ingebrigtsen
2022-05-11 12:04 ` Eli Zaretskii
0 siblings, 1 reply; 7+ messages in thread
From: Lars Ingebrigtsen @ 2022-05-11 11:46 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 14816, andreas.roehler
Eli Zaretskii <eliz@gnu.org> writes:
> This changeset changes the form of the return value of
> ispell-process-line, so shouldn't that at least appear in
> incompatible changes in NEWS (if not done in some more compatible
> way)?
It seemed unlikely to me that third party packages would be using
ispell-process-line, so I didn't think either was necessary. If it
turns out that it is, I was thinking of adding a new optional argument
to the function to alter the return value.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#14816: 24.3.50.1; ispell remember position, feature request
2022-05-11 11:46 ` Lars Ingebrigtsen
@ 2022-05-11 12:04 ` Eli Zaretskii
2022-05-12 0:07 ` Lars Ingebrigtsen
0 siblings, 1 reply; 7+ messages in thread
From: Eli Zaretskii @ 2022-05-11 12:04 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 14816, andreas.roehler
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: andreas.roehler@easy-emacs.de, 14816@debbugs.gnu.org
> Date: Wed, 11 May 2022 13:46:55 +0200
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> > This changeset changes the form of the return value of
> > ispell-process-line, so shouldn't that at least appear in
> > incompatible changes in NEWS (if not done in some more compatible
> > way)?
>
> It seemed unlikely to me that third party packages would be using
> ispell-process-line, so I didn't think either was necessary. If it
> turns out that it is, I was thinking of adding a new optional argument
> to the function to alter the return value.
Yes, I'm asking why not do that now, proactively?
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#14816: 24.3.50.1; ispell remember position, feature request
2022-05-11 12:04 ` Eli Zaretskii
@ 2022-05-12 0:07 ` Lars Ingebrigtsen
2022-05-12 5:29 ` Eli Zaretskii
0 siblings, 1 reply; 7+ messages in thread
From: Lars Ingebrigtsen @ 2022-05-12 0:07 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 14816, andreas.roehler
Eli Zaretskii <eliz@gnu.org> writes:
>> It seemed unlikely to me that third party packages would be using
>> ispell-process-line, so I didn't think either was necessary. If it
>> turns out that it is, I was thinking of adding a new optional argument
>> to the function to alter the return value.
>
> Yes, I'm asking why not do that now, proactively?
Having an optional parameter to a function that has one single usage
didn't seem warranted.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#14816: 24.3.50.1; ispell remember position, feature request
2022-05-12 0:07 ` Lars Ingebrigtsen
@ 2022-05-12 5:29 ` Eli Zaretskii
0 siblings, 0 replies; 7+ messages in thread
From: Eli Zaretskii @ 2022-05-12 5:29 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 14816, andreas.roehler
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: andreas.roehler@easy-emacs.de, 14816@debbugs.gnu.org
> Date: Thu, 12 May 2022 02:07:07 +0200
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> It seemed unlikely to me that third party packages would be using
> >> ispell-process-line, so I didn't think either was necessary. If it
> >> turns out that it is, I was thinking of adding a new optional argument
> >> to the function to alter the return value.
> >
> > Yes, I'm asking why not do that now, proactively?
>
> Having an optional parameter to a function that has one single usage
> didn't seem warranted.
It's a public API that could be used out there any number of times.
And the compatible change is very simple. Sounds like a no-brainer to
me.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-05-12 5:29 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-08 6:06 bug#14816: 24.3.50.1; ispell remember position, feature request Andreas Röhler
2022-05-10 14:24 ` Lars Ingebrigtsen
2022-05-10 17:16 ` Eli Zaretskii
2022-05-11 11:46 ` Lars Ingebrigtsen
2022-05-11 12:04 ` Eli Zaretskii
2022-05-12 0:07 ` Lars Ingebrigtsen
2022-05-12 5:29 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).