From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: 56400@debbugs.gnu.org
Subject: bug#56400: Make setopt warn on type mismatch
Date: Tue, 05 Jul 2022 18:57:17 +0200 [thread overview]
Message-ID: <87wncrzedu.fsf@gnus.org> (raw)
In-Reply-To: <CADwFkmnTFP_291kpAzSotCZ_JgxXK2ZL_UrOmJcCYLhRcCr8ww@mail.gmail.com> (Stefan Kangas's message of "Tue, 5 Jul 2022 08:32:29 -0700")
Stefan Kangas <stefan@marxist.se> writes:
> Why not make `setopt' warn in case there is a type mismatch?
> For example, in:
>
> (setopt tetris-buffer-width "hello")
>
> But the type of `tetris-buffer-width' is natnum.
It should throw an error already:
;;;###autoload
(defun setopt--set (variable value)
(custom-load-symbol variable)
;; Check that the type is correct.
(when-let ((type (get variable 'custom-type)))
(unless (widget-apply (widget-convert type) :match value)
(user-error "Value `%S' does not match type %s" value type)))
Did you mean a byte compilation warning? I don't really think that
people will be using setopt much in code, just in .emacs, so I'm not
sure that'd give us much.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2022-07-05 16:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 15:32 bug#56400: Make setopt warn on type mismatch Stefan Kangas
2022-07-05 16:57 ` Lars Ingebrigtsen [this message]
2022-07-05 17:08 ` Stefan Kangas
2022-07-05 17:32 ` Lars Ingebrigtsen
2022-07-05 17:42 ` Stefan Kangas
2022-07-05 18:07 ` Lars Ingebrigtsen
2022-07-05 18:51 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wncrzedu.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=56400@debbugs.gnu.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).