From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#56400: Make setopt warn on type mismatch Date: Tue, 05 Jul 2022 18:57:17 +0200 Message-ID: <87wncrzedu.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31057"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 56400@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 05 19:08:42 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8m2U-0007tu-Ip for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 Jul 2022 19:08:42 +0200 Original-Received: from localhost ([::1]:51054 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o8m2S-0007Z8-Kd for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 Jul 2022 13:08:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44198) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8lsA-0003I6-8X for bug-gnu-emacs@gnu.org; Tue, 05 Jul 2022 12:58:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57616) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o8ls9-0004Qp-VF for bug-gnu-emacs@gnu.org; Tue, 05 Jul 2022 12:58:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o8ls9-0004VD-Uq for bug-gnu-emacs@gnu.org; Tue, 05 Jul 2022 12:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Jul 2022 16:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56400 X-GNU-PR-Package: emacs Original-Received: via spool by 56400-submit@debbugs.gnu.org id=B56400.165704025317260 (code B ref 56400); Tue, 05 Jul 2022 16:58:01 +0000 Original-Received: (at 56400) by debbugs.gnu.org; 5 Jul 2022 16:57:33 +0000 Original-Received: from localhost ([127.0.0.1]:51510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8lre-0004U9-4t for submit@debbugs.gnu.org; Tue, 05 Jul 2022 12:57:33 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:45964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8lrc-0004Tw-Dl for 56400@debbugs.gnu.org; Tue, 05 Jul 2022 12:57:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=AnNYUPYxTw0mT41uEWRPhgK7RNm2Y8u4M3OSl2PGwIw=; b=BnsJlxvDPYow0jXncGiVwzsDDP ONoZKicpDNl8VLFatdKZPgFsFF/pezUZEPGl+s9R0iosfSfFFaQzzrJ5N4eVtaOKGvSSL7TSSrCoX 3SUejeqbzA1KjlIgVNwDbq89d4G9u3P7w3uklo/0YHwjjosLXs0i3Y0/pwL/dka+lfAQ=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8lrT-0003yX-MI; Tue, 05 Jul 2022 18:57:22 +0200 In-Reply-To: (Stefan Kangas's message of "Tue, 5 Jul 2022 08:32:29 -0700") X-Now-Playing: Frankie Goes To Hollywood's _Liverpool_: "Rage Hard" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236150 Archived-At: Stefan Kangas writes: > Why not make `setopt' warn in case there is a type mismatch? > For example, in: > > (setopt tetris-buffer-width "hello") > > But the type of `tetris-buffer-width' is natnum. It should throw an error already: ;;;###autoload (defun setopt--set (variable value) (custom-load-symbol variable) ;; Check that the type is correct. (when-let ((type (get variable 'custom-type))) (unless (widget-apply (widget-convert type) :match value) (user-error "Value `%S' does not match type %s" value type))) Did you mean a byte compilation warning? I don't really think that people will be using setopt much in code, just in .emacs, so I'm not sure that'd give us much. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no