* bug#59886: Manual error in (elisp) Searching Keymaps regarding keymap char properties?
@ 2022-12-07 16:21 hokomo
2022-12-10 13:07 ` Eli Zaretskii
0 siblings, 1 reply; 2+ messages in thread
From: hokomo @ 2022-12-07 16:21 UTC (permalink / raw)
To: 59886
Hello,
The psuedo-Lisp code presented in the manual (elisp) Searching
Keymaps says:
(if (get-text-property (point) 'local-map)
(FIND-IN (get-char-property (point) 'local-map))
(FIND-IN (current-local-map)))
Why does the condition use `get-text-property', but then the
consequent uses `get-char-property'? Shouldn't they both be
`get-char-property'? According to (elisp) Active Keymaps:
"If there is a 'local-map' /text or overlay/ property at point,
that specifies the local keymap to use, in place of the buffer's
default local keymap."
Am I missing something?
Additionally, perhaps the two paragraphs in (elisp) Active Keymaps
that mention the `keymap` and the `local-map' property (search for
"property") should be reworded slightly to emphasize that the
search prefers the overlay property over the text property, since
that's how `get-char-property' is documented to work. Maybe change
the ordering of "text or overlay" to "overlay or text", along with
an explicit emphasis?
hokomo
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#59886: Manual error in (elisp) Searching Keymaps regarding keymap char properties?
2022-12-07 16:21 bug#59886: Manual error in (elisp) Searching Keymaps regarding keymap char properties? hokomo
@ 2022-12-10 13:07 ` Eli Zaretskii
0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2022-12-10 13:07 UTC (permalink / raw)
To: hokomo; +Cc: 59886-done
> From: hokomo <hokomo@airmail.cc>
> Date: Wed, 07 Dec 2022 17:21:36 +0100
>
>
> Hello,
>
> The psuedo-Lisp code presented in the manual (elisp) Searching
> Keymaps says:
>
> (if (get-text-property (point) 'local-map)
> (FIND-IN (get-char-property (point) 'local-map))
> (FIND-IN (current-local-map)))
>
> Why does the condition use `get-text-property', but then the
> consequent uses `get-char-property'? Shouldn't they both be
> `get-char-property'? According to (elisp) Active Keymaps:
>
> "If there is a 'local-map' /text or overlay/ property at point,
> that specifies the local keymap to use, in place of the buffer's
> default local keymap."
>
> Am I missing something?
>
> Additionally, perhaps the two paragraphs in (elisp) Active Keymaps
> that mention the `keymap` and the `local-map' property (search for
> "property") should be reworded slightly to emphasize that the
> search prefers the overlay property over the text property, since
> that's how `get-char-property' is documented to work. Maybe change
> the ordering of "text or overlay" to "overlay or text", along with
> an explicit emphasis?
Thanks, I've changed the example to use get-char-property.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-10 13:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-07 16:21 bug#59886: Manual error in (elisp) Searching Keymaps regarding keymap char properties? hokomo
2022-12-10 13:07 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).