From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 61403@debbugs.gnu.org, casouri@gmail.com
Subject: bug#61403: 30.0.50; C tree-sitter bug?
Date: Sun, 12 Feb 2023 18:30:41 +0800 [thread overview]
Message-ID: <87wn4nyy3y.fsf@yahoo.com> (raw)
In-Reply-To: <835yc7i7nl.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 12 Feb 2023 10:56:30 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> Cc: 61403@debbugs.gnu.org
>> Date: Sun, 12 Feb 2023 16:36:10 +0800
>> From: Po Lu via "Bug reports for GNU Emacs,
>> the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>>
>> Yuan Fu <casouri@gmail.com> writes:
>>
>> > Po Lu <luangruo@yahoo.com> writes:
>> >
>> >> Go to sfnt.c in the feature/android branch, and turn on c-ts-mode.
>> >>
>> >> Then, go to line 10754, around which should be the function definition:
>> >>
>> >> /* Load the simple glyph GLYPH into the specified INTERPRETER, scaling
>> >> it up by INTERPRETER's scale, and run its glyph program if
>> >> present. Use the unscaled metrics specified in METRICS.
>> >>
>> >> Upon success, return NULL and the resulting points and contours in
>> >> *VALUE. Else, value is the reason interpretation failed. */
>> >>
>> >> TEST_STATIC const char *
>> >> sfnt_interpret_simple_glyph (struct sfnt_glyph *glyph,
>> >> struct sfnt_interpreter *interpreter,
>> >> struct sfnt_glyph_metrics *metrics,
>> >> struct sfnt_instructed_outline **value)
>> >> {
>> >> size_t zone_size, temp, outline_size, i;
>> >> struct sfnt_interpreter_zone *zone;
>> >> struct sfnt_interpreter_zone *volatile preserved_zone;
>> >> sfnt_f26dot6 phantom_point_1_x;
>> >>
>> >> `TEST_STATIC' is fontified as a type. Perhaps tree-sitter needs
>> >> something along the lines of `c-noise-macros'?
>> >
>> > Would it be reasonable to assume that all caps "type" are almost always
>> > macros? If it is, we can optionally defontify these kind of "types".
>>
>> Not really, because an extremely common type is:
>>
>> PTR_T *ptr;
>>
>> where ``PTR_T'' is used to represent pointers on systems that may lack
>> properly working pointers to void.
>>
>> The standard library FILE * is also one such type with a capitalized
>> name.
>
> I admit I don't understand the problem that is the subject of this
> bug. Why is it wrong to fontify TEST_STATIC as a type? CC mode also
> fontifies it as a type, btw.
Yes, but CC Mode provides `c-noise-macro-names'. I said something
similar should exist in c-ts-mode at the beginning of this thread.
> The only problem I see in what c-ts-mode does is that it does NOT
> fontify 'char', whereas CC mode does. So if anything needs to be done
> here, we need to look into why 'char' is not fontified by c-ts-mode.
Apparently tree-sitter thinks only TEST_STATIC is the type, and
everything else is a syntactic error.
next prev parent reply other threads:[~2023-02-12 10:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87h6vt364d.fsf.ref@yahoo.com>
2023-02-10 15:14 ` bug#61403: 30.0.50; C tree-sitter bug? Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-12 8:27 ` Yuan Fu
2023-02-12 8:36 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-12 8:56 ` Eli Zaretskii
2023-02-12 10:30 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-02-12 12:31 ` Eli Zaretskii
2023-02-12 12:36 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-12 13:04 ` Eli Zaretskii
2023-02-12 14:12 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-12 14:36 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wn4nyy3y.fsf@yahoo.com \
--to=bug-gnu-emacs@gnu.org \
--cc=61403@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=eliz@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).