unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 61403@debbugs.gnu.org, casouri@gmail.com
Subject: bug#61403: 30.0.50; C tree-sitter bug?
Date: Sun, 12 Feb 2023 20:36:22 +0800	[thread overview]
Message-ID: <87o7pzysah.fsf@yahoo.com> (raw)
In-Reply-To: <83sffbgj5h.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 12 Feb 2023 14:31:06 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Po Lu <luangruo@yahoo.com>
>> Cc: casouri@gmail.com,  61403@debbugs.gnu.org
>> Date: Sun, 12 Feb 2023 18:30:41 +0800
>> 
>> Eli Zaretskii <eliz@gnu.org> writes:
>> 
>> > I admit I don't understand the problem that is the subject of this
>> > bug.  Why is it wrong to fontify TEST_STATIC as a type?  CC mode also
>> > fontifies it as a type, btw.
>> 
>> Yes, but CC Mode provides `c-noise-macro-names'.  I said something
>> similar should exist in c-ts-mode at the beginning of this thread.
>
> Maybe so, but not for this case: I see absolutely no reason to
> "de-fontify" TEST_STATIC here, as it is part of the type.

It actually ``static'' on TEST builds or nothing at all, not part of the
type.  It ought not to be fontified, just as we don't fontify _Noreturn
or __attribute__ as types.

>> > The only problem I see in what c-ts-mode does is that it does NOT
>> > fontify 'char', whereas CC mode does.  So if anything needs to be done
>> > here, we need to look into why 'char' is not fontified by c-ts-mode.
>> 
>> Apparently tree-sitter thinks only TEST_STATIC is the type, and
>> everything else is a syntactic error.
>
> Whatever the reasons, we need to try to fix this part.

Yes, please.  Also the bit about _Noreturn.





  reply	other threads:[~2023-02-12 12:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87h6vt364d.fsf.ref@yahoo.com>
2023-02-10 15:14 ` bug#61403: 30.0.50; C tree-sitter bug? Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-12  8:27   ` Yuan Fu
2023-02-12  8:36     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-12  8:56       ` Eli Zaretskii
2023-02-12 10:30         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-12 12:31           ` Eli Zaretskii
2023-02-12 12:36             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-02-12 13:04               ` Eli Zaretskii
2023-02-12 14:12                 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-12 14:36                   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7pzysah.fsf@yahoo.com \
    --to=bug-gnu-emacs@gnu.org \
    --cc=61403@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=eliz@gnu.org \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).