unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: Mauro Aranda <maurooaranda@gmail.com>
Cc: 66071@debbugs.gnu.org
Subject: bug#66071: 30.0.50; term-scroll-to-bottom-on-output missing choices
Date: Mon, 18 Sep 2023 17:22:13 +0200	[thread overview]
Message-ID: <87wmwnik0q.fsf@gmail.com> (raw)
In-Reply-To: <53e55fdd-598d-efd3-e3ac-9cc19334b47c@gmail.com> (Mauro Aranda's message of "Mon, 18 Sep 2023 12:12:41 -0300")

>>>>> On Mon, 18 Sep 2023 12:12:41 -0300, Mauro Aranda <maurooaranda@gmail.com> said:

    Mauro> On 18/9/23 11:20, Robert Pluim wrote:
    >> On Mon, 18 Sep 2023 09:20:07 -0300, Mauro Aranda
    Mauro>   <maurooaranda@gmail.com> said:
    >>      Mauro> Patch attached.
    >> 
    >>      Mauro> From d891a9f705b3b4af2aedeed645f4636535ea6c2e Mon Sep 17
    Mauro>  00:00:00 2001
    >>      Mauro> From: Mauro Aranda <maurooaranda@gmail.com>
    >>      Mauro> Date: Mon, 18 Sep 2023 09:19:04 -0300
    >>      Mauro> Subject: [PATCH] Fix term-scroll-to-bottom-on-output
    Mauro>  :type (Bug#66071)
    >> 
    >>      Mauro> * lisp/term.el (term-scroll-to-bottom-on-output): Add
    Mauro>  missing choices.
    >>      Mauro> ---
    >>      Mauro>  lisp/term.el | 5 ++++-
    >>      Mauro>  1 file changed, 4 insertions(+), 1 deletion(-)
    >> 
    >>      Mauro> diff --git a/lisp/term.el b/lisp/term.el
    >>      Mauro> index b8466b21332..5dd73447cfb 100644
    >>      Mauro> --- a/lisp/term.el
    >>      Mauro> +++ b/lisp/term.el
    >>      Mauro> @@ -494,7 +494,10 @@ term-scroll-to-bottom-on-output
    >> 
    >>      Mauro>  See variable `term-scroll-show-maximum-output'.
    >>      Mauro>  This variable is buffer-local."
    >>      Mauro> -  :type 'boolean
    >>      Mauro> +  :type '(choice (const :tag "Don't scroll" nil)
    >>      Mauro> +                 (const :tag "Scroll selected window
    Mauro>  only" this)
    >>      Mauro> +                 (const :tag "Scroll unselected windows"
    Mauro>  others)
    >>      Mauro> +                 (other :tag "Scroll all windows" t))
    >>      Mauro>    :group 'term)
    >> 
    >> The code (and the docstring) also mention 'all.

    Mauro> I know, that's why I put other, to catch either t or 'all, since it
    Mauro> doesn't make sense to have 2 different items for the same option. And
    Mauro> adding something to match only t or 'all didn't seem worth the trouble.

    Mauro> Am I missing something?

Both before and after your patch, the defcustom and the docstring
disagree. The docstring says 'all', but thatʼs not a value you can get
via customize.

Personally Iʼd be inclined to delete 'all' from the docstring. People
already using 'all' wonʼt notice, since the code will still recognize
it.

Robert
-- 





  reply	other threads:[~2023-09-18 15:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-18 12:17 bug#66071: 30.0.50; term-scroll-to-bottom-on-output missing choices Mauro Aranda
2023-09-18 12:20 ` Mauro Aranda
2023-09-18 14:20   ` Robert Pluim
2023-09-18 15:12     ` Mauro Aranda
2023-09-18 15:22       ` Robert Pluim [this message]
2023-09-18 15:29         ` Mauro Aranda
2023-09-24 11:38         ` Mauro Aranda
2023-09-30 23:36           ` Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wmwnik0q.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=66071@debbugs.gnu.org \
    --cc=maurooaranda@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).