From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#66071: 30.0.50; term-scroll-to-bottom-on-output missing choices Date: Mon, 18 Sep 2023 17:22:13 +0200 Message-ID: <87wmwnik0q.fsf@gmail.com> References: <147ab958-899e-07cc-f175-52ad2d25e54b@gmail.com> <871qevk1fh.fsf@gmail.com> <53e55fdd-598d-efd3-e3ac-9cc19334b47c@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18489"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 66071@debbugs.gnu.org To: Mauro Aranda Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 18 17:23:47 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qiG6E-0004Si-4y for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 18 Sep 2023 17:23:46 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qiG5R-0004RO-E9; Mon, 18 Sep 2023 11:22:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qiG5N-0004QB-PZ for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2023 11:22:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qiG5N-00035r-Hq for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2023 11:22:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qiG5V-0000IH-Pc for bug-gnu-emacs@gnu.org; Mon, 18 Sep 2023 11:23:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Sep 2023 15:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66071 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66071-submit@debbugs.gnu.org id=B66071.16950505501067 (code B ref 66071); Mon, 18 Sep 2023 15:23:01 +0000 Original-Received: (at 66071) by debbugs.gnu.org; 18 Sep 2023 15:22:30 +0000 Original-Received: from localhost ([127.0.0.1]:54092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qiG50-0000H9-FH for submit@debbugs.gnu.org; Mon, 18 Sep 2023 11:22:30 -0400 Original-Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]:60671) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qiG4z-0000Gp-1e for 66071@debbugs.gnu.org; Mon, 18 Sep 2023 11:22:29 -0400 Original-Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-404732a0700so46811355e9.0 for <66071@debbugs.gnu.org>; Mon, 18 Sep 2023 08:22:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695050534; x=1695655334; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=dxNxe/Q67TeWsudDNz6gSV31rSNKkqPZlwATnFg9Z5Y=; b=VPbpmLBfrE0KlmoNRg7rpl2z95do1ijlVfmGmYD2AK9yirBokFsvwJDYRfFgezrZ+r 1PSoONShRO91LXkUY17qOFeZTTvc6VWJ0w1appwELGWTIu8yV/81E45wls3Fb+wu2E/g rjNXDFbIJHhtkEPApjoH542dO9mkLqxupgP/hjuVNXcfdU0euv3Z5stlp9NRRF5Asv2f chohj1pqK/CpsyAzSx15q9xevGLhg31O85GYnZmzSiYYNH+1K4rU+E70ee+EhHBXqB4l VVB8mx8nBnOwN/KG88J12a99iwqiZzP+IcU1ry/6/AROIuXWJ+RoCGStvGPkaPZwMu9X vOvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695050534; x=1695655334; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dxNxe/Q67TeWsudDNz6gSV31rSNKkqPZlwATnFg9Z5Y=; b=jbc32qQ1QcsyW7xkPnRV31r4jXifUjLQlD06N3LPqV/q5ejfBNJpaRzgEflg9oSbg9 G8it+etFluocrLGD4/TZEAFhlEDg4/dlXKv1V9JG6bOjxAqs8HE+wgcCylSrtpHjS9bE KXOO6xoegZvj81eLw8fl+wepwWSfnv5Caboops3WaXI9cUJNMLZahAmUzUXMFXfzQWIy l4xxLhTKVvd9wLkDxgI8DBQNjtLkE8vtdbH1h8ydc2t8982GeTCO9y9y5nY3BwXDSvEq YLVfEpiyMyh/wddtOKJEJSaZokG8CGwN0Wk8ioieGtcd27h/iimx5pvXzJje1R9rcUx1 5aig== X-Gm-Message-State: AOJu0YxuQO6if3WPyldML8zlABU7M52y3C0tdsMGP5M1jl6/nFiFeEUG lIeJSliNAzYFnaeyIrX85j8bEZlGos/Fzw== X-Google-Smtp-Source: AGHT+IE7ZTxFmeMeFGJ1uvG0d0NdenRm+/oCDt4W6eqisfmBOBnZ7byAjAZYim3sdcaVxu9Le6V/ow== X-Received: by 2002:a5d:5a12:0:b0:320:7fa:c71e with SMTP id bq18-20020a5d5a12000000b0032007fac71emr7209978wrb.15.1695050534220; Mon, 18 Sep 2023 08:22:14 -0700 (PDT) Original-Received: from rltb ([2a01:e0a:3f3:fb50:d837:9a8f:f5d9:8bdc]) by smtp.gmail.com with ESMTPSA id e7-20020a056000194700b00317b063590fsm12776032wry.55.2023.09.18.08.22.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 08:22:13 -0700 (PDT) In-Reply-To: <53e55fdd-598d-efd3-e3ac-9cc19334b47c@gmail.com> (Mauro Aranda's message of "Mon, 18 Sep 2023 12:12:41 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270813 Archived-At: >>>>> On Mon, 18 Sep 2023 12:12:41 -0300, Mauro Aranda said: Mauro> On 18/9/23 11:20, Robert Pluim wrote: >> On Mon, 18 Sep 2023 09:20:07 -0300, Mauro Aranda Mauro> said: >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro> Patch attached. >>=20 >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro> From d891a9f705b3b4af2aedeed645f4636= 535ea6c2e Mon Sep 17 Mauro> 00:00:00 2001 >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro> From: Mauro Aranda >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro> Date: Mon, 18 Sep 2023 09:19:04 -0300 >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro> Subject: [PATCH] Fix term-scroll-to-= bottom-on-output Mauro> :type (Bug#66071) >>=20 >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro> * lisp/term.el (term-scroll-to-botto= m-on-output): Add Mauro> missing choices. >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro> --- >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro>=C2=A0 lisp/term.el | 5 ++++- >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro>=C2=A0 1 file changed, 4 insertions(+= ), 1 deletion(-) >>=20 >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro> diff --git a/lisp/term.el b/lisp/ter= m.el >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro> index b8466b21332..5dd73447cfb 100644 >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro> --- a/lisp/term.el >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro> +++ b/lisp/term.el >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro> @@ -494,7 +494,10 @@ term-scroll-to-= bottom-on-output >>=20 >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro>=C2=A0 See variable `term-scroll-show= -maximum-output'. >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro>=C2=A0 This variable is buffer-local." >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro> -=C2=A0 :type 'boolean >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro> +=C2=A0 :type '(choice (const :tag "= Don't scroll" nil) >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (const :tag= "Scroll selected window Mauro> only" this) >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (const :tag= "Scroll unselected windows" Mauro> others) >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (other :tag= "Scroll all windows" t)) >> =C2=A0=C2=A0=C2=A0=C2=A0 Mauro>=C2=A0=C2=A0=C2=A0 :group 'term) >>=20 >> The code (and the docstring) also mention 'all. Mauro> I know, that's why I put other, to catch either t or 'all, since= it Mauro> doesn't make sense to have 2 different items for the same option= . And Mauro> adding something to match only t or 'all didn't seem worth the t= rouble. Mauro> Am I missing something? Both before and after your patch, the defcustom and the docstring disagree. The docstring says 'all', but that=CA=BCs not a value you can get via customize. Personally I=CA=BCd be inclined to delete 'all' from the docstring. People already using 'all' won=CA=BCt notice, since the code will still recognize it. Robert --=20