From: "J.P." <jp@neverwas.me>
To: Alcor via General discussion about ERC <emacs-erc@gnu.org>
Cc: 69860@debbugs.gnu.org, Alcor <alcor@tilde.club>
Subject: bug#69860: 29.2; ERC 5.6-git: erc: Incorrect face formatting applied for fg=99 bg=x (irccontrols module with erc-interpret-mirc-color=t)
Date: Sun, 17 Mar 2024 10:16:16 -0700 [thread overview]
Message-ID: <87wmq0srrz.fsf__25615.8950434596$1710695825$gmane$org@neverwas.me> (raw)
In-Reply-To: <874jd4q0pb.fsf@tilde.club> (Alcor via General discussion about's message of "Sun, 17 Mar 2024 17:31:44 +0100")
Alcor via General discussion about ERC <emacs-erc@gnu.org> writes:
> On Emacs 29.2, using erc-5.6snapshot0.20240310.61129:
>
> 1. Enable the irccontrols module (for erc)
> 2. Enable `erc-interpret-mirc-color'
> 3. Login onto any IRC network, any channel, or perform a /query session
> 4. Either send, or have someone send you the string ^C99,4Text with a
> red background^C (Key sequence: C-q C-c 99,4Text with a red background
> C-q C-c)
>
> According to https://modern.ircdocs.horse/formatting.html the text
> *should* get formatted with a default foreground, and a red background. The
> observed behavior - however - is that the text is formatted with multiple
> background "bg" faces: (erc-control-default-bg bg:erc-color-face4
> erc-input-face).
>
> A screenshot illustrating the issue is attached to this message.
Oof. Looks like `erc-get-fg-color-face' sets `erc-control-default-bg' in
its catch-all `cond' case. As you say, this produces:
#("THIS TEXT IS FORMATTED"
0 22 (font-lock-face (erc-control-default-bg bg:erc-color-face4)))
And `erc-get-bg-color-face' sets `erc-control-default-fg'. Clearly,
whoever's responsible for this outrage should be banished. (Thanks.)
next prev parent reply other threads:[~2024-03-17 17:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-17 16:31 bug#69860: 29.2; ERC 5.6-git: erc: Incorrect face formatting applied for fg=99 bg=x (irccontrols module with erc-interpret-mirc-color=t) Alcor via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-17 17:16 ` J.P. [this message]
[not found] ` <87wmq0srrz.fsf@neverwas.me>
2024-03-17 17:23 ` Alcor via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <87zfuwojpt.fsf@tilde.club>
2024-03-20 14:27 ` J.P.
[not found] ` <875xxhkmfo.fsf@neverwas.me>
2024-03-20 17:23 ` Alcor via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <87frwkq0ll.fsf@tilde.club>
2024-03-28 17:31 ` J.P.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='87wmq0srrz.fsf__25615.8950434596$1710695825$gmane$org@neverwas.me' \
--to=jp@neverwas.me \
--cc=69860@debbugs.gnu.org \
--cc=alcor@tilde.club \
--cc=emacs-erc@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).