From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#69860: 29.2; ERC 5.6-git: erc: Incorrect face formatting applied for fg=99 bg=x (irccontrols module with erc-interpret-mirc-color=t) Date: Sun, 17 Mar 2024 10:16:16 -0700 Message-ID: <87wmq0srrz.fsf__25615.8950434596$1710695825$gmane$org@neverwas.me> References: <874jd4q0pb.fsf@tilde.club> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28351"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 69860@debbugs.gnu.org, Alcor To: Alcor via General discussion about ERC Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 17 18:16:55 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rlu7v-0006zY-QO for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 Mar 2024 18:16:52 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rlu7X-0001pa-5Y; Sun, 17 Mar 2024 13:16:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rlu7V-0001pG-KT for bug-gnu-emacs@gnu.org; Sun, 17 Mar 2024 13:16:25 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rlu7V-0002Ks-CF for bug-gnu-emacs@gnu.org; Sun, 17 Mar 2024 13:16:25 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rlu86-0005sn-VU for bug-gnu-emacs@gnu.org; Sun, 17 Mar 2024 13:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Mar 2024 17:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69860 X-GNU-PR-Package: emacs Original-Received: via spool by 69860-submit@debbugs.gnu.org id=B69860.171069582122596 (code B ref 69860); Sun, 17 Mar 2024 17:17:02 +0000 Original-Received: (at 69860) by debbugs.gnu.org; 17 Mar 2024 17:17:01 +0000 Original-Received: from localhost ([127.0.0.1]:58895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rlu84-0005sN-Fd for submit@debbugs.gnu.org; Sun, 17 Mar 2024 13:17:00 -0400 Original-Received: from mail-108-mta19.mxroute.com ([136.175.108.19]:46439) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rlu83-0005sG-1C for 69860@debbugs.gnu.org; Sun, 17 Mar 2024 13:16:59 -0400 Original-Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta19.mxroute.com (ZoneMTA) with ESMTPSA id 18e4d6a074c0003bea.001 for <69860@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sun, 17 Mar 2024 17:16:18 +0000 X-Zone-Loop: d17e12ff296c97ba0e973897643b5929ef39f80f505c X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Zi7dR7cG9+wUT98b/MAlPnkeWUlp6vMRJm+pctLNNJY=; b=SJz/8cpENebrWlTuDjaQvcbwHC yo6mq+OokTh9Ccwjf9J0ETBv4u6oaBU+aDlggCTLKmzBZlZGdvSk9KHpbUJdErY7MSc5OaaU7JRpP 5PUzuKOD61Y3BJcYk9di98oANc8eNp9juSalHDvqqZvJxgTCgXWd7FYYc0ujUw8d+Rg0NREnKAJNu lolG0P6s1l6EbPzy8nrHmnV8pAbnoVZowuqP6FKihAsUpLsrdDR/kt6Qa6aKK0pBCME4ur6dj2Ddw xVgpq7LCaDCxhxulAaD4CUKnvQLHO3ODG86I1u/RS+11rYKgp1SWDWhXrewDrvup9Ko1W1mrmN87l SU2h/8GA==; In-Reply-To: <874jd4q0pb.fsf@tilde.club> (Alcor via General discussion about's message of "Sun, 17 Mar 2024 17:31:44 +0100") X-Authenticated-Id: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281767 Archived-At: Alcor via General discussion about ERC writes: > On Emacs 29.2, using erc-5.6snapshot0.20240310.61129: > > 1. Enable the irccontrols module (for erc) > 2. Enable `erc-interpret-mirc-color' > 3. Login onto any IRC network, any channel, or perform a /query session > 4. Either send, or have someone send you the string ^C99,4Text with a > red background^C (Key sequence: C-q C-c 99,4Text with a red background > C-q C-c) > > According to https://modern.ircdocs.horse/formatting.html the text > *should* get formatted with a default foreground, and a red background. The > observed behavior - however - is that the text is formatted with multiple > background "bg" faces: (erc-control-default-bg bg:erc-color-face4 > erc-input-face). > > A screenshot illustrating the issue is attached to this message. Oof. Looks like `erc-get-fg-color-face' sets `erc-control-default-bg' in its catch-all `cond' case. As you say, this produces: #("THIS TEXT IS FORMATTED" 0 22 (font-lock-face (erc-control-default-bg bg:erc-color-face4))) And `erc-get-bg-color-face' sets `erc-control-default-fg'. Clearly, whoever's responsible for this outrage should be banished. (Thanks.)