* bug#16415: 24.3.50; Handle contiguous links correctly in shr [PATCH]
@ 2014-01-11 3:22 Nathan Trapuzzano
2014-01-11 12:50 ` Nathan Trapuzzano
2014-01-31 2:09 ` Lars Ingebrigtsen
0 siblings, 2 replies; 14+ messages in thread
From: Nathan Trapuzzano @ 2014-01-11 3:22 UTC (permalink / raw)
To: 16415
[-- Attachment #1: Type: text/plain, Size: 370 bytes --]
`shr-next-link' and `shr-previous-link' currently skip over links that
are contiguous with the current link. The attached patch addressed this
problem.
When I say "contiguous", I'm talking in terms of Emacs "positions"--not
in terms of HTML.
P.S. I'm still waiting for my boss to return the copyright disclaimer
form to me. Hopefully this change is minor enough...
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: shr.patch --]
[-- Type: text/x-diff, Size: 4848 bytes --]
# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: nbtrap@nbtrap.com-20140111031617-s3vx9z7lf9ah91gr
# target_branch: file:///home/nathan/opt/etc/bzr-repos/emacs/trunk/
# testament_sha1: 2b99f693499c398c7a9599c8d6b5eb6c7ccb7a47
# timestamp: 2014-01-10 22:16:56 -0500
# base_revision_id: rgm@gnu.org-20140110201931-3ybs57oe9egahtb4
#
# Begin patch
=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog 2014-01-10 20:19:31 +0000
+++ lisp/ChangeLog 2014-01-11 03:16:17 +0000
@@ -1,3 +1,8 @@
+2014-01-11 Nathan Trapuzzano <nbtrap@nbtrap.com>
+
+ * lisp/net/shr.el (shr-next-link, shr-previous-link): Don't skip
+ over contiguous links.
+
2014-01-10 Glenn Morris <rgm@gnu.org>
* emacs-lisp/authors.el (authors-fixed-entries):
=== modified file 'lisp/net/shr.el'
--- lisp/net/shr.el 2014-01-05 10:23:35 +0000
+++ lisp/net/shr.el 2014-01-11 03:16:17 +0000
@@ -242,8 +242,10 @@
(defun shr-next-link ()
"Skip to the next link."
(interactive)
- (let ((skip (text-property-any (point) (point-max) 'help-echo nil)))
- (if (not (setq skip (text-property-not-all skip (point-max)
+ (let ((skip (and (get-text-property (point) 'help-echo)
+ (or (next-single-property-change (point) 'help-echo)
+ (point-max)))))
+ (if (not (setq skip (text-property-not-all (or skip (point)) (point-max)
'help-echo nil)))
(message "No next link")
(goto-char skip)
@@ -254,11 +256,17 @@
(interactive)
(let ((start (point))
(found nil))
- ;; Skip past the current link.
- (while (and (not (bobp))
- (get-text-property (point) 'help-echo))
+ ;; Skip past the current link. When the current link extends past
+ ;; the end of the narrowed region and point is at (point-max),
+ ;; don't do anything, so that point will get moved to the
+ ;; beginning of this link.
+ (when (and (get-text-property (point) 'help-echo)
+ (not (and (eobp) (buffer-narrowed-p))))
+ (goto-char (or (previous-single-property-change
+ (min (1+ (point)) (point-max)) 'help-echo)
+ (point-min))))
+ (unless (bobp)
(forward-char -1))
- ;; Find the previous link.
(while (and (not (bobp))
(not (setq found (get-text-property (point) 'help-echo))))
(forward-char -1))
@@ -267,10 +275,9 @@
(message "No previous link")
(goto-char start))
;; Put point at the start of the link.
- (while (and (not (bobp))
- (get-text-property (point) 'help-echo))
- (forward-char -1))
- (forward-char 1)
+ (goto-char (or (previous-single-property-change
+ (min (1+ (point)) (point-max)) 'help-echo)
+ (point-min)))
(message "%s" (get-text-property (point) 'help-echo)))))
(defun shr-show-alt-text ()
# Begin bundle
IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWfXc+CUAAuD/gHA4uABQ////
XgUMgL////BQBg1VeaDorNupU1Xc3XRwkkIRhAmNNAwiT9SaabUABjSA9QJKmUzU9NMSmQ2oGgaa
aNAAAAACRIJqp41T9E1PRP1E0ybU000eRGTQ00ABoc0ZMTABMRgRpgQYjBMmARgkkCaANEFNpP0q
eDUyekymQAND1A9JiJkmYjXlx0FUHqNeXnE2y591FE275bfzZHiCIa3LdjTS0volR52i+VrYU8Fq
S13RLUkhQgNM8mZGf7je7+Z/VSS5fsx59DRLeSqiQaQi4nhpZMyGyc1TghkhB9TQbuYYs4pxw2UT
rqx2kdHhIf4pwU1HjNyUVY8d7gqWbW0dqMEXPXJPGSPhG9oLz4j4Sfp0IwyGWGWwwvnqOOzJ1aot
/QSr7lJpGKMAaRznNB0D2PawXS+kaPa7jnXSt2xHpqHjQclEPTljIQOJ7e/QSQNfLWRfxeqIon3D
0f6BKoJc1mTRSB1jDMBxR4VfAO7zipHim7gKqx6mO2jNyleIrRHINR+NtxUXEaebTD2auHMUnKEc
wYdkiRVCiBJsJwDGoYDDTCeOKFcYBIJK/+9kYefAuwDUi5XQh2k3BE8v0gWjHyxtDOg4COh1GvXl
EJAMBaGLwlVTIqjuv3UIA1ZTjMS3hiVlvDByeYGmQF+MAK7fudw+3eEQxJaDjduAjfaxaLkyFAJw
BnDfHJ+YXs9s2VRvHFxUUsRRZ4nGfROGVhWcHA0QMntAKFHW/SYW4GXxxfBtsDdAiFtjqXMKEA9g
TaagTWQPTtYZ7SBR0ptktA1kOvLzKGDsq0+5h66dkSdNSlu0Ky2+s6gfI5BpdLST5kEEVU7HMfk+
dBn7dtrKyJG2ok+0Ckh7PvaROs1KXPC0mRqfYH0AmD6dODrI0OJFJbB1cr82XW3sAyFllIRHVkwy
gQORIKSKrDSKsxyagGyoyDLPmB7ylmjTvfYxfi6urVKSB1zhFVFkWufWGwNa8RybizaG90ZJ+vj+
RCPR6RFco02/tdy3lBwwi/M4F5+KQb0BMZM0qNzGTqYP30XAZww5pk5Ds60BopDLwkNMk0pnc5S9
km9Bhd+huzxBjcXnYW+4z8DDh5BoCI+oVoL91eCg6+Uu/euGBxqRni5CJtBjYlUjDMw+7uKH1llQ
QJA6POKJmfjhp2LAsnwrDh7ky7hmR0XQ77r4FuHMP0zhGdZNI3FnT0DIwmKc2on/1rV75gn7dzgz
0N7Lws7dnBDprmu8XFJSlZrwI0pgvcs1m+Pr4JcOrrGw2MMSvEVjwrTMjCdfYb+ByMuUGge9GQHS
QOqrADAz5lZ2cy0ynUxEX29pFnZjUiorCCpZkMWcSA9SD+UQOQFF7fCwBrRPHL0YHXsinojn/0CS
Jgqw2pUiQyKfD1Q0c9U5e0WDjtN7HQiUM0ltoWXEkpY7n0uRmRAUYNRBTk4azimXUJUSHfTciaPW
Cr6BmSghzgpxKJgls5AcNGQwzLloNgdi3rEo6oiIY1BDydZIvGLI+4m96eRoaVPYHjExlJV9wj5G
aYs4loWsWodZVUVhhJVCalqhC0uZQpvhPINJtJmRNQw0ohXceQ82NtiGJw7JqtoUnTad4BckZcXR
ORygpQKQxo9yM6les6ppKlOivMeFBAWkpq0I1iHGFwjDWwwMnq9Kp5ohUwgnlThTKXUChwukMOHO
en9IJgxNRU4EfxKrCPSmiOSpVoaEMrVBjknmgVnxGnNhMtm4kna83oYbaBoGEq8d2BU9ZFIj3LkN
bd1ywRYrZrKsHFFl0NjzCvjRNvZipxJlJpQi79gZJgeHjVAgEukHF2RjgGuNg8XNnYaXqhGBgiCy
3Ah1TBY4XeDw2R68eKs7S4CfE4g96ZYCPwAcV5EC4LwzR5AQEt5mwMWBvM1HwAw3kNKYltP+LuSK
cKEh67nwSg==
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#16415: 24.3.50; Handle contiguous links correctly in shr [PATCH]
2014-01-11 3:22 bug#16415: 24.3.50; Handle contiguous links correctly in shr [PATCH] Nathan Trapuzzano
@ 2014-01-11 12:50 ` Nathan Trapuzzano
2014-01-20 13:20 ` Nathan Trapuzzano
2014-01-31 2:09 ` Lars Ingebrigtsen
1 sibling, 1 reply; 14+ messages in thread
From: Nathan Trapuzzano @ 2014-01-11 12:50 UTC (permalink / raw)
To: 16415
[-- Attachment #1: Type: text/plain, Size: 388 bytes --]
Nathan Trapuzzano <nbtrap@nbtrap.com> writes:
> `shr-next-link' and `shr-previous-link' currently skip over links that
> are contiguous with the current link. The attached patch addressed this
> problem.
>
> When I say "contiguous", I'm talking in terms of Emacs "positions"--not
> in terms of HTML.
Use this one instead. I clarified one of the comments and referenced a
bug number:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: shr.patch --]
[-- Type: text/x-diff, Size: 5452 bytes --]
# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: nbtrap@nbtrap.com-20140111124832-14454dcnawyzjkny
# target_branch: file:///home/nathan/opt/etc/bzr-repos/emacs/trunk/
# testament_sha1: 6cb8b589f64f1b09f140c539ef23d4305646a92e
# timestamp: 2014-01-11 07:48:46 -0500
# base_revision_id: rgm@gnu.org-20140110201931-3ybs57oe9egahtb4
#
# Begin patch
=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog 2014-01-10 20:19:31 +0000
+++ lisp/ChangeLog 2014-01-11 03:16:17 +0000
@@ -1,3 +1,8 @@
+2014-01-11 Nathan Trapuzzano <nbtrap@nbtrap.com>
+
+ * lisp/net/shr.el (shr-next-link, shr-previous-link): Don't skip
+ over contiguous links.
+
2014-01-10 Glenn Morris <rgm@gnu.org>
* emacs-lisp/authors.el (authors-fixed-entries):
=== modified file 'lisp/net/shr.el'
--- lisp/net/shr.el 2014-01-05 10:23:35 +0000
+++ lisp/net/shr.el 2014-01-11 12:48:32 +0000
@@ -242,8 +242,10 @@
(defun shr-next-link ()
"Skip to the next link."
(interactive)
- (let ((skip (text-property-any (point) (point-max) 'help-echo nil)))
- (if (not (setq skip (text-property-not-all skip (point-max)
+ (let ((skip (and (get-text-property (point) 'help-echo)
+ (or (next-single-property-change (point) 'help-echo)
+ (point-max)))))
+ (if (not (setq skip (text-property-not-all (or skip (point)) (point-max)
'help-echo nil)))
(message "No next link")
(goto-char skip)
@@ -254,11 +256,17 @@
(interactive)
(let ((start (point))
(found nil))
- ;; Skip past the current link.
- (while (and (not (bobp))
- (get-text-property (point) 'help-echo))
+ ;; Skip backwards past the current link. Be carefule when the
+ ;; current link extends past the end of the narrowed region and
+ ;; point is at (point-max). In such a case, we proceed as though
+ ;; point is _not_ looking at a link. Cf. Emacs bug#16413.
+ (when (and (get-text-property (point) 'help-echo)
+ (not (and (eobp) (buffer-narrowed-p))))
+ (goto-char (or (previous-single-property-change
+ (min (1+ (point)) (point-max)) 'help-echo)
+ (point-min))))
+ (unless (bobp)
(forward-char -1))
- ;; Find the previous link.
(while (and (not (bobp))
(not (setq found (get-text-property (point) 'help-echo))))
(forward-char -1))
@@ -267,10 +275,9 @@
(message "No previous link")
(goto-char start))
;; Put point at the start of the link.
- (while (and (not (bobp))
- (get-text-property (point) 'help-echo))
- (forward-char -1))
- (forward-char 1)
+ (goto-char (or (previous-single-property-change
+ (min (1+ (point)) (point-max)) 'help-echo)
+ (point-min)))
(message "%s" (get-text-property (point) 'help-echo)))))
(defun shr-show-alt-text ()
# Begin bundle
IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWU9sFaMABHF/gHA4uABY////
XiUMgL////BgCC+quzFADVUyAERVSCgEiRTaQ1GU8mp+k02phTymJoNqjRgIzaox6g5gCMExAMAm
CaMhoYBMEYmEpA1U/CKfpT0jQNNAAAAAAAA5gCMExAMAmCaMhoYBMEYmOYAjBMQDAJgmjIaGATBG
JhJICAAQ0QaGk8KTKfpE8oDRp6hpo/VMRhVomBDKL677TQTkiom/r41O/yb3E927Fiw7dnwPL8/6
frzpzCY1Ozpmhp2YTaQiTGjAXj6casqJlTiUu2uuROrpSAJIRbhVHzI8nEb0f/PMqYMn+M46S3B6
CpWkxpkea/QzGBmTMDYfdGtEDAhB5wbhF29zhaGpvXONN8InTy6BnsOqDwMajTryTON/rqPHPgld
9tVw+LFjnFYyaJ4VyFS1LOX4n3fxVRMuuoukpvINdNj4uFQytodes/lsH5AmAaPSewlk42K/EaOP
GX4TErFM+UlTb7hTvQAX9KMoNI7zug8B+t+xguDOA0e10PSuW2NSPV1EhzhK8SULETmuw/nwzlJn
Rq4XBV+x5CY9iZeXeYPR+wglQEvFaFCMyC5DDDCPIXxJ/RHT8ohI0TcwUykeqAdt2M5lubt1p1xQ
i0CjQOKfnfgOc6ZgRhs/JsqUu44uHDIMIjsIkksaLx75BIKJIiAE2E80ggHwYTYLvhGr1EcVBbEg
ilBJGVL7okT28QcK4wFePciyBD4FDgiex+cArGD621hliDgUdDkHl6kRYSBwgYQVovejbMoK8sV/
wqoo1wo1KX5k0NYMZnmVgLelkTYVZeeBiOTy025grf54wxkCrLv4OPHSSIhiSxByo11BSL4MwyUq
0HVkkRB8EMOBuHrXeRiUmiVzfgK2bzYyLDgOqZ8geGdYGdYxRorVZL0s7yuWdoT1Y0eDSBXPZ4oI
0LrdxCJl4Jh4U5kdK4FsjN5aRCBCZYQ+ALAMy2EqHAySGGSarDK2CHVkhu4HORkZipnEBkmjxnsI
VkQM9xIIESxjNGA+igW0OLh1xcYH3NlRHQk0el+GAijLzTDBQiZoUaMthIjXWQWQdUZW0ZyftsIg
tWiWlBQ0KmMtg/OuFOhKkfLcbqsQhYora25ZQkK8ErVJE4K5R8YjmF1LDOFMkelUUkI0VRrR7grQ
nIbe+yd1LECy8iKgvoMrWum6CsSJO4m6RK5bxqvtVULAthQqhuglFDbCgMdcSkqLjSauyJiYzBbJ
mde1wabNDP5AvibLiIZOsMSFwxiSGkNIZERRHpMSMwdJDisCugz+gNoG5Fq8xlVjeRvpG2pDPTrP
moF2dyEVYRsaG2/tYV6SCbG4GLmk7BkCJb/OAnnHWCUhk8MDa3LeQPHFs6YFp1A4AvkG3tmszFTM
/kmHixToISHnP355gulaaiEEOM2ocfqmJiYXbebThsyBh8F26WYh0HQNnxMOJ7BiIRGfuj1QvLza
7z5VuM+fasyNz5fjnsdkcuS63uOCJxG6C+iEX5DG2LgrCgZMMxDqbTabctnIvKhTKUtXlPykBYUy
Su3L1RgVdGpN9SOJ2Xq5HRMdXbmFtrwo4eo7yidpHPuY39+PAlIzChdVfNl1GcXYpgKTS4l5onZs
ObcvSKJ8/QoejcW7nH0Ln7g9XHE+ADu1x30OOZ+g4NTUD1O4760HATJfFy2enGZy5gcz0rBrtowx
K1JUg9FKZgLigp5L/XDwOxj2g0Dqi15AWzMdprKyV8nddYibhDqxo39/ivOvKs7V4yMpZv3BQz4Y
g0ouDAE10jYDLNhXeU1QOKLx2gudbNGtlgJ8wiShamEYmgy8Ud5ymVIdaApDcIyIKGJkfM+4DETP
yRJ68EFzg+BvGO4C5rO1y9RBruEF/E1KiJNB2FWlaq3oK1fcTT3dRfPBb2EMTBx76gZ1B/5mgKKn
XwGYSqQQQB19GpbcygV/P5wXXaNDbTGvBmsp1GAtIsi4zQi0Pr5IsFWuGJaGBEgc6lwC6kpRSc7k
qiPzMkEhhfBoojBaLsQj2mZMsQyBneitFYMWAOKyZMqRhIJiZPNXCDa0FEjd1ow1Jg0mMBrCmKGl
aiBbRX91i36t+9DOdHqsuNgaFy2HBIMtwCymLkoQdpNUwoOkMYH2RsRY8WwLdTZ3K4Xnmf3uUEtx
rvyRwQhxSOQinzGTJMh6LgJvDQSyugDyEx4qFlZkjI7rJDDhznp+aAcOB4EiYhHupyBqx2YPBXit
OpJFSHhX5TgidcHAUrEJL6g1BQwmFptXBpp/gp+UBMNtBaBfMrJ4brwoeMyxWUSRAbTzDGUosaCt
VVtWLGwcXlZYxgywCbWvyiMx7cAIOexFQSgRcf2QwDA8PnMjFRFI7wcFpgX2i8S+tPEfgw4szLVi
EYFwEBYbRCHTZKocLoh4aTkUeiv4qPeEUFHivFD3iZXJL7AuOMFW5RC1FyMwX0BQSCo1Mcx48HA6
0G1CLtBfYFV0UdwMG8Vh6L/4u5IpwoSCe2CtGA==
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#16415: 24.3.50; Handle contiguous links correctly in shr [PATCH]
2014-01-11 12:50 ` Nathan Trapuzzano
@ 2014-01-20 13:20 ` Nathan Trapuzzano
0 siblings, 0 replies; 14+ messages in thread
From: Nathan Trapuzzano @ 2014-01-20 13:20 UTC (permalink / raw)
To: 16415
Nathan Trapuzzano <nbtrap@nbtrap.com> writes:
> Use this one instead. I clarified one of the comments and referenced
> a bug number:
Can this be applied before the release? I'd like to finally do away
with w3m.
Thanks,
Nathan
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#16415: 24.3.50; Handle contiguous links correctly in shr [PATCH]
2014-01-11 3:22 bug#16415: 24.3.50; Handle contiguous links correctly in shr [PATCH] Nathan Trapuzzano
2014-01-11 12:50 ` Nathan Trapuzzano
@ 2014-01-31 2:09 ` Lars Ingebrigtsen
2014-01-31 16:06 ` nbtrap
1 sibling, 1 reply; 14+ messages in thread
From: Lars Ingebrigtsen @ 2014-01-31 2:09 UTC (permalink / raw)
To: Nathan Trapuzzano; +Cc: 16415
Nathan Trapuzzano <nbtrap@nbtrap.com> writes:
> `shr-next-link' and `shr-previous-link' currently skip over links that
> are contiguous with the current link. The attached patch addressed this
> problem.
>
> When I say "contiguous", I'm talking in terms of Emacs "positions"--not
> in terms of HTML.
>
> P.S. I'm still waiting for my boss to return the copyright disclaimer
> form to me. Hopefully this change is minor enough...
The patch looks good, but it's big enough that the FSF needs a copyright
assignment, I think. Do you have one of those on file?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#16415: 24.3.50; Handle contiguous links correctly in shr [PATCH]
2014-01-31 2:09 ` Lars Ingebrigtsen
@ 2014-01-31 16:06 ` nbtrap
2014-11-13 18:42 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 14+ messages in thread
From: nbtrap @ 2014-01-31 16:06 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 16415
Lars Ingebrigtsen <larsi@gnus.org> writes:
> The patch looks good, but it's big enough that the FSF needs a
> copyright assignment, I think. Do you have one of those on file?
Yes, but I'm waiting for a disclaimer from my new employer. Should have
it soon.
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#16415: 24.3.50; Handle contiguous links correctly in shr [PATCH]
2014-01-31 16:06 ` nbtrap
@ 2014-11-13 18:42 ` Lars Magne Ingebrigtsen
2015-12-25 17:37 ` Lars Ingebrigtsen
0 siblings, 1 reply; 14+ messages in thread
From: Lars Magne Ingebrigtsen @ 2014-11-13 18:42 UTC (permalink / raw)
To: nbtrap; +Cc: 16415
nbtrap@nbtrap.com writes:
> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> The patch looks good, but it's big enough that the FSF needs a
>> copyright assignment, I think. Do you have one of those on file?
>
> Yes, but I'm waiting for a disclaimer from my new employer. Should have
> it soon.
Was there any progress on this?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#16415: 24.3.50; Handle contiguous links correctly in shr [PATCH]
2014-11-13 18:42 ` Lars Magne Ingebrigtsen
@ 2015-12-25 17:37 ` Lars Ingebrigtsen
2015-12-26 11:10 ` bug#16415: 24.3.50; Handle contiguous links correctly in shr Ivan Shmakov
0 siblings, 1 reply; 14+ messages in thread
From: Lars Ingebrigtsen @ 2015-12-25 17:37 UTC (permalink / raw)
To: nbtrap; +Cc: 16415
Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
> nbtrap@nbtrap.com writes:
>
>> Lars Ingebrigtsen <larsi@gnus.org> writes:
>>
>>> The patch looks good, but it's big enough that the FSF needs a
>>> copyright assignment, I think. Do you have one of those on file?
>>
>> Yes, but I'm waiting for a disclaimer from my new employer. Should have
>> it soon.
>
> Was there any progress on this?
More information was requested, but no response was given within a few
months, so I'm closing this bug report. If the problem still exists,
please reopen this bug report.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#16415: 24.3.50; Handle contiguous links correctly in shr
2015-12-25 17:37 ` Lars Ingebrigtsen
@ 2015-12-26 11:10 ` Ivan Shmakov
2015-12-26 12:12 ` Eli Zaretskii
2015-12-28 21:21 ` Lars Ingebrigtsen
0 siblings, 2 replies; 14+ messages in thread
From: Ivan Shmakov @ 2015-12-26 11:10 UTC (permalink / raw)
To: 16415
[-- Attachment #1: Type: text/plain, Size: 1041 bytes --]
>>>>> Lars Ingebrigtsen <larsi@gnus.org> writes:
>>>>> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
>>>>> nbtrap@nbtrap.com writes:
>>>>> Lars Ingebrigtsen <larsi@gnus.org> writes:
>>>> The patch looks good, but it's big enough that the FSF needs a
>>>> copyright assignment, I think. Do you have one of those on file?
>>> Yes, but I'm waiting for a disclaimer from my new employer. Should
>>> have it soon.
>> Was there any progress on this?
> More information was requested, but no response was given within a
> few months, so I'm closing this bug report. If the problem still
> exists, please reopen this bug report.
I can confirm that the issue still exists as of 1dcf9a5d2a72
(2015-12-22 17:02:30 UTC.) Check the HTML MIMEd; for instance,
when issued at BOB, shr-next-link correctly moves the point to
‘f’. When issued one more time from here, it reports “No next
link” (although there is.)
--
FSF associate member #7257 http://am-1.org/~ivan/ … 3013 B6A0 230E 334A
[-- Attachment #2: Type: text/html, Size: 144 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#16415: 24.3.50; Handle contiguous links correctly in shr
2015-12-26 11:10 ` bug#16415: 24.3.50; Handle contiguous links correctly in shr Ivan Shmakov
@ 2015-12-26 12:12 ` Eli Zaretskii
2015-12-26 12:40 ` Ivan Shmakov
2015-12-28 21:21 ` Lars Ingebrigtsen
1 sibling, 1 reply; 14+ messages in thread
From: Eli Zaretskii @ 2015-12-26 12:12 UTC (permalink / raw)
To: Ivan Shmakov; +Cc: 16415
> From: Ivan Shmakov <ivan@siamics.net>
> Date: Sat, 26 Dec 2015 11:10:39 +0000
>
> >>>>> Lars Ingebrigtsen <larsi@gnus.org> writes:
> >>>>> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
> >>>>> nbtrap@nbtrap.com writes:
> >>>>> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
> >>>> The patch looks good, but it's big enough that the FSF needs a
> >>>> copyright assignment, I think. Do you have one of those on file?
>
> >>> Yes, but I'm waiting for a disclaimer from my new employer. Should
> >>> have it soon.
>
> >> Was there any progress on this?
>
> > More information was requested, but no response was given within a
> > few months, so I'm closing this bug report. If the problem still
> > exists, please reopen this bug report.
>
> I can confirm that the issue still exists as of 1dcf9a5d2a72
> (2015-12-22 17:02:30 UTC.) Check the HTML MIMEd; for instance,
> when issued at BOB, shr-next-link correctly moves the point to
> ‘f’. When issued one more time from here, it reports “No next
> link” (although there is.)
Nathan still doesn't have assignment on file, though, and he's already
exhausted the amount of contributions we can accept without legal
paperwork. So we cannot use his patch, unfortunately.
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#16415: 24.3.50; Handle contiguous links correctly in shr
2015-12-26 12:12 ` Eli Zaretskii
@ 2015-12-26 12:40 ` Ivan Shmakov
2015-12-26 13:02 ` Eli Zaretskii
0 siblings, 1 reply; 14+ messages in thread
From: Ivan Shmakov @ 2015-12-26 12:40 UTC (permalink / raw)
To: 16415
>>>>> Eli Zaretskii <eliz@gnu.org> writes:
>>>>> From: Ivan Shmakov Date: Sat, 26 Dec 2015 11:10:39 +0000
>>>>> Lars Ingebrigtsen <larsi@gnus.org> writes:
[…]
>>> More information was requested, but no response was given within a
>>> few months, so I'm closing this bug report. If the problem still
>>> exists, please reopen this bug report.
>> I can confirm that the issue still exists as of 1dcf9a5d2a72
>> (2015-12-22 17:02:30 UTC.) Check the HTML MIMEd; for instance, when
>> issued at BOB, shr-next-link correctly moves the point to ‘f’. When
>> issued one more time from here, it reports “No next link” (although
>> there is.)
> Nathan still doesn't have assignment on file, though, and he's
> already exhausted the amount of contributions we can accept without
> legal paperwork. So we cannot use his patch, unfortunately.
We aren’t supposed to close bug reports merely because they have
no patches we can accept, are we?
There is also my own patch for the issue at #19560 (one made
before I’ve got aware of #16415), but it had some flaws, ISTR.
--
FSF associate member #7257 http://am-1.org/~ivan/ … 3013 B6A0 230E 334A
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#16415: 24.3.50; Handle contiguous links correctly in shr
2015-12-26 12:40 ` Ivan Shmakov
@ 2015-12-26 13:02 ` Eli Zaretskii
2015-12-26 13:07 ` Ivan Shmakov
2015-12-26 13:09 ` Lars Ingebrigtsen
0 siblings, 2 replies; 14+ messages in thread
From: Eli Zaretskii @ 2015-12-26 13:02 UTC (permalink / raw)
To: Ivan Shmakov; +Cc: 16415
> From: Ivan Shmakov <ivan@siamics.net>
> Date: Sat, 26 Dec 2015 12:40:51 +0000
>
> > Nathan still doesn't have assignment on file, though, and he's
> > already exhausted the amount of contributions we can accept without
> > legal paperwork. So we cannot use his patch, unfortunately.
>
> We aren’t supposed to close bug reports merely because they have
> no patches we can accept, are we?
Did I say that?
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#16415: 24.3.50; Handle contiguous links correctly in shr
2015-12-26 13:02 ` Eli Zaretskii
@ 2015-12-26 13:07 ` Ivan Shmakov
2015-12-26 13:09 ` Lars Ingebrigtsen
1 sibling, 0 replies; 14+ messages in thread
From: Ivan Shmakov @ 2015-12-26 13:07 UTC (permalink / raw)
To: 16415
>>>>> Eli Zaretskii <eliz@gnu.org> writes:
>>>>> From: Ivan Shmakov Date: Sat, 26 Dec 2015 12:40:51 +0000
>>> Nathan still doesn't have assignment on file, though, and he's
>>> already exhausted the amount of contributions we can accept without
>>> legal paperwork. So we cannot use his patch, unfortunately.
>> We aren’t supposed to close bug reports merely because they have no
>> patches we can accept, are we?
> Did I say that?
Well, no, but I didn’t say anything about the patch in the
message you’ve replied to, either. EOUTOFSYNC on the part of
the parties involved, apparently.
--
FSF associate member #7257 http://am-1.org/~ivan/ … 3013 B6A0 230E 334A
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#16415: 24.3.50; Handle contiguous links correctly in shr
2015-12-26 13:02 ` Eli Zaretskii
2015-12-26 13:07 ` Ivan Shmakov
@ 2015-12-26 13:09 ` Lars Ingebrigtsen
1 sibling, 0 replies; 14+ messages in thread
From: Lars Ingebrigtsen @ 2015-12-26 13:09 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 16415, Ivan Shmakov
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Ivan Shmakov <ivan@siamics.net>
>> Date: Sat, 26 Dec 2015 12:40:51 +0000
>>
>> > Nathan still doesn't have assignment on file, though, and he's
>> > already exhausted the amount of contributions we can accept without
>> > legal paperwork. So we cannot use his patch, unfortunately.
>>
>> We aren’t supposed to close bug reports merely because they have
>> no patches we can accept, are we?
>
> Did I say that?
I've reopened it again.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 14+ messages in thread
* bug#16415: 24.3.50; Handle contiguous links correctly in shr
2015-12-26 11:10 ` bug#16415: 24.3.50; Handle contiguous links correctly in shr Ivan Shmakov
2015-12-26 12:12 ` Eli Zaretskii
@ 2015-12-28 21:21 ` Lars Ingebrigtsen
1 sibling, 0 replies; 14+ messages in thread
From: Lars Ingebrigtsen @ 2015-12-28 21:21 UTC (permalink / raw)
To: Ivan Shmakov; +Cc: 16415
Ivan Shmakov <ivan@siamics.net> writes:
> I can confirm that the issue still exists as of 1dcf9a5d2a72
> (2015-12-22 17:02:30 UTC.) Check the HTML MIMEd; for instance,
> when issued at BOB, shr-next-link correctly moves the point to
> ‘f’. When issued one more time from here, it reports “No next
> link” (although there is.)
This has now been fixed in Emacs 25.1.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2015-12-28 21:21 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-01-11 3:22 bug#16415: 24.3.50; Handle contiguous links correctly in shr [PATCH] Nathan Trapuzzano
2014-01-11 12:50 ` Nathan Trapuzzano
2014-01-20 13:20 ` Nathan Trapuzzano
2014-01-31 2:09 ` Lars Ingebrigtsen
2014-01-31 16:06 ` nbtrap
2014-11-13 18:42 ` Lars Magne Ingebrigtsen
2015-12-25 17:37 ` Lars Ingebrigtsen
2015-12-26 11:10 ` bug#16415: 24.3.50; Handle contiguous links correctly in shr Ivan Shmakov
2015-12-26 12:12 ` Eli Zaretskii
2015-12-26 12:40 ` Ivan Shmakov
2015-12-26 13:02 ` Eli Zaretskii
2015-12-26 13:07 ` Ivan Shmakov
2015-12-26 13:09 ` Lars Ingebrigtsen
2015-12-28 21:21 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).