* bug#23631: 25.0.94; Directories in completion-ignored-extensions not ignored
@ 2016-05-27 12:32 Dmitry Gutov
2016-05-27 12:51 ` thierry
2016-05-27 13:11 ` Eli Zaretskii
0 siblings, 2 replies; 8+ messages in thread
From: Dmitry Gutov @ 2016-05-27 12:32 UTC (permalink / raw)
To: 23631
Evaluate something like
(file-name-all-completions "" "~/.emacs.d/")
On my machine, this returns a list which includes ".git/". It should
not, however, because ".git/" is in completion-ignored-extensions.
Not 100% sure it's supposed to work, because it seems broken at least
since 24.2 (maybe longer).
in GNU Emacs 25.0.94.2 (x86_64-pc-linux-gnu, GTK+ Version 3.18.9)
of 2016-05-25 built on axl
Repository revision: 897fb6fa49d5ffc85f0a796e7414a43ef05ad096
Windowing system distributor 'The X.Org Foundation', version 11.0.11803000
System Description: Ubuntu 16.04 LTS
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#23631: 25.0.94; Directories in completion-ignored-extensions not ignored
2016-05-27 12:32 bug#23631: 25.0.94; Directories in completion-ignored-extensions not ignored Dmitry Gutov
@ 2016-05-27 12:51 ` thierry
2016-05-27 12:58 ` Dmitry Gutov
2016-05-27 13:11 ` Eli Zaretskii
1 sibling, 1 reply; 8+ messages in thread
From: thierry @ 2016-05-27 12:51 UTC (permalink / raw)
To: 23631
Le 27/05/2016 14:32, Dmitry Gutov a écrit :
> Evaluate something like
>
> (file-name-all-completions "" "~/.emacs.d/")
>
> On my machine, this returns a list which includes ".git/". It should
> not, however, because ".git/" is in completion-ignored-extensions.
>
> Not 100% sure it's supposed to work, because it seems broken at least
> since 24.2 (maybe longer).
I don't think it's supposed to filter ignored extensions, if is was the
case how one can list all the files in a directory using e.g
directory-files-recursively ?
IMO the filtering should happen (or not) in the application that use
file-name-all-completions.
I would be annoyed in my own applications if you modify
file-name-all-completion to handle ignored extensions.
So please don't do that.
Thanks.
> in GNU Emacs 25.0.94.2 (x86_64-pc-linux-gnu, GTK+ Version 3.18.9)
> of 2016-05-25 built on axl
> Repository revision: 897fb6fa49d5ffc85f0a796e7414a43ef05ad096
> Windowing system distributor 'The X.Org Foundation', version 11.0.11803000
> System Description: Ubuntu 16.04 LTS
>
>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#23631: 25.0.94; Directories in completion-ignored-extensions not ignored
2016-05-27 12:51 ` thierry
@ 2016-05-27 12:58 ` Dmitry Gutov
2016-05-27 13:05 ` Thierry Volpiatto
0 siblings, 1 reply; 8+ messages in thread
From: Dmitry Gutov @ 2016-05-27 12:58 UTC (permalink / raw)
To: thierry, 23631
On 05/27/2016 03:51 PM, thierry wrote:
> I don't think it's supposed to filter ignored extensions,
file-name-all-completions's docstring says it does.
> if is was the
> case how one can list all the files in a directory using e.g
> directory-files-recursively ?
You can bind the relevant variables to nil locally.
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#23631: 25.0.94; Directories in completion-ignored-extensions not ignored
2016-05-27 12:58 ` Dmitry Gutov
@ 2016-05-27 13:05 ` Thierry Volpiatto
0 siblings, 0 replies; 8+ messages in thread
From: Thierry Volpiatto @ 2016-05-27 13:05 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: 23631
Dmitry Gutov <dgutov@yandex.ru> writes:
> On 05/27/2016 03:51 PM, thierry wrote:
>
>> I don't think it's supposed to filter ignored extensions,
>
> file-name-all-completions's docstring says it does.
Not in emacs-24.5, so applications created before emacs-25 use this
behavior, i.e ignored extensions not handled.
And it is good like this.
>> if is was the
>> case how one can list all the files in a directory using e.g
>> directory-files-recursively ?
>
> You can bind the relevant variables to nil locally.
Of course.
--
Thierry
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#23631: 25.0.94; Directories in completion-ignored-extensions not ignored
2016-05-27 12:32 bug#23631: 25.0.94; Directories in completion-ignored-extensions not ignored Dmitry Gutov
2016-05-27 12:51 ` thierry
@ 2016-05-27 13:11 ` Eli Zaretskii
2016-05-27 13:53 ` Dmitry Gutov
2016-05-27 15:48 ` Michael Albinus
1 sibling, 2 replies; 8+ messages in thread
From: Eli Zaretskii @ 2016-05-27 13:11 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: 23631
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Fri, 27 May 2016 15:32:07 +0300
>
> Evaluate something like
>
> (file-name-all-completions "" "~/.emacs.d/")
>
> On my machine, this returns a list which includes ".git/". It should
> not, however, because ".git/" is in completion-ignored-extensions.
This works as designed: completion-ignored-extensions only affects
file-name-completion, but not file-name-all-completions. I've just
pushed a fix for the doc string of file-name-all-completions. (The
ELisp manual correctly says that the variable has no effect in your
case.)
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#23631: 25.0.94; Directories in completion-ignored-extensions not ignored
2016-05-27 13:11 ` Eli Zaretskii
@ 2016-05-27 13:53 ` Dmitry Gutov
2016-05-27 14:06 ` Eli Zaretskii
2016-05-27 15:48 ` Michael Albinus
1 sibling, 1 reply; 8+ messages in thread
From: Dmitry Gutov @ 2016-05-27 13:53 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 23631-done
On 05/27/2016 04:11 PM, Eli Zaretskii wrote:
> This works as designed: completion-ignored-extensions only affects
> file-name-completion, but not file-name-all-completions. I've just
> pushed a fix for the doc string of file-name-all-completions.
I see, thanks!
> (The
> ELisp manual correctly says that the variable has no effect in your
> case.)
That kind of illustrates the problem of divergence between different
kinds of documentation.
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#23631: 25.0.94; Directories in completion-ignored-extensions not ignored
2016-05-27 13:53 ` Dmitry Gutov
@ 2016-05-27 14:06 ` Eli Zaretskii
0 siblings, 0 replies; 8+ messages in thread
From: Eli Zaretskii @ 2016-05-27 14:06 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: 23631
> Cc: 23631-done@debbugs.gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Fri, 27 May 2016 16:53:25 +0300
>
> On 05/27/2016 04:11 PM, Eli Zaretskii wrote:
>
> > (The
> > ELisp manual correctly says that the variable has no effect in your
> > case.)
>
> That kind of illustrates the problem of divergence between different
> kinds of documentation.
Yes, nothing new here.
^ permalink raw reply [flat|nested] 8+ messages in thread
* bug#23631: 25.0.94; Directories in completion-ignored-extensions not ignored
2016-05-27 13:11 ` Eli Zaretskii
2016-05-27 13:53 ` Dmitry Gutov
@ 2016-05-27 15:48 ` Michael Albinus
1 sibling, 0 replies; 8+ messages in thread
From: Michael Albinus @ 2016-05-27 15:48 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 23631, Dmitry Gutov
Eli Zaretskii <eliz@gnu.org> writes:
>> Evaluate something like
>>
>> (file-name-all-completions "" "~/.emacs.d/")
>>
>> On my machine, this returns a list which includes ".git/". It should
>> not, however, because ".git/" is in completion-ignored-extensions.
>
> This works as designed: completion-ignored-extensions only affects
> file-name-completion, but not file-name-all-completions. I've just
> pushed a fix for the doc string of file-name-all-completions. (The
> ELisp manual correctly says that the variable has no effect in your
> case.)
Tramp does not honor `completion-ignored-extensions'. I will fix it, but
it shall go into the master branch then. Not important enough for
emacs-25.
Best regards, Michael.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-05-27 15:48 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-27 12:32 bug#23631: 25.0.94; Directories in completion-ignored-extensions not ignored Dmitry Gutov
2016-05-27 12:51 ` thierry
2016-05-27 12:58 ` Dmitry Gutov
2016-05-27 13:05 ` Thierry Volpiatto
2016-05-27 13:11 ` Eli Zaretskii
2016-05-27 13:53 ` Dmitry Gutov
2016-05-27 14:06 ` Eli Zaretskii
2016-05-27 15:48 ` Michael Albinus
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).