unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Alan Third <alan@idiocy.org>
Cc: 36403@debbugs.gnu.org, Pip Cet <pipcet@gmail.com>
Subject: bug#36403: 27.0.50; Trivial image.c bugs
Date: Fri, 21 Aug 2020 01:13:58 +0200	[thread overview]
Message-ID: <87v9hcj4g9.fsf@gnus.org> (raw)
In-Reply-To: <20200820230332.GB38852@breton.holly.idiocy.org> (Alan Third's message of "Fri, 21 Aug 2020 01:03:34 +0200 (CEST)")

Alan Third <alan@idiocy.org> writes:

> Hi, this patch appears to have broken something (in NS at least) and
> now interactively resizing an image no longer causes the image to be
> immediately redisplayed. I have to force a redisplay some other way
> before I see the resized image.

Yup.  This patch fixes things for me (on Debian)...

diff --git a/src/image.c b/src/image.c
index 643b3d0a1f..ceb690ed0a 100644
--- a/src/image.c
+++ b/src/image.c
@@ -1633,7 +1633,7 @@ search_image_cache (struct frame *f, Lisp_Object spec, EMACS_UINT hash)
 
   for (img = c->buckets[i]; img; img = img->next)
     if (img->hash == hash
-	&& !equal_lists (img->spec, spec)
+	&& !NILP (Fequal (img->spec, spec))
 	&& img->frame_foreground == FRAME_FOREGROUND_PIXEL (f)
 	&& img->frame_background == FRAME_BACKGROUND_PIXEL (f))
       break;

The equal_lists thing looks sensible, but I guess we do destructive
alterations with +/-, possibly, to equal is the correct thing, not a
list-of-eqs?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2020-08-20 23:13 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-27 16:28 bug#36403: 27.0.50; Trivial image.c bugs Pip Cet
2019-06-27 17:40 ` Eli Zaretskii
2019-06-28 15:05   ` Pip Cet
2019-06-28 19:52     ` Eli Zaretskii
2019-07-22  2:55       ` Pip Cet
2019-07-26  6:56         ` Eli Zaretskii
2019-07-28 14:50           ` Pip Cet
2019-09-24 16:26             ` Lars Ingebrigtsen
2020-08-03  7:47               ` Lars Ingebrigtsen
2020-08-18 16:28                 ` Lars Ingebrigtsen
2020-08-20 23:03                   ` Alan Third
2020-08-20 23:13                     ` Lars Ingebrigtsen [this message]
2020-08-20 23:17                       ` Lars Ingebrigtsen
2020-08-20 23:32                         ` Lars Ingebrigtsen
2020-08-21  9:26                           ` Pip Cet
2020-08-21 11:26                             ` Lars Ingebrigtsen
2022-10-04 13:52                               ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-04 14:06                                 ` Lars Ingebrigtsen
2022-10-04 18:05                                   ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-10-14 22:14                                   ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9hcj4g9.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=36403@debbugs.gnu.org \
    --cc=alan@idiocy.org \
    --cc=pipcet@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).