From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#36403: 27.0.50; Trivial image.c bugs Date: Fri, 21 Aug 2020 01:13:58 +0200 Message-ID: <87v9hcj4g9.fsf@gnus.org> References: <83pnmzhqq0.fsf@gnu.org> <83h889h4h9.fsf@gnu.org> <83tvb9mggh.fsf@gnu.org> <8736glzmls.fsf@gnus.org> <87h7tkw4qh.fsf@gnus.org> <87blj7j4v0.fsf@gnus.org> <20200820230332.GB38852@breton.holly.idiocy.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28685"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 36403@debbugs.gnu.org, Pip Cet To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 21 01:15:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k8tm2-0007L6-Vw for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Aug 2020 01:15:11 +0200 Original-Received: from localhost ([::1]:45586 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k8tm1-0001cf-Cx for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 20 Aug 2020 19:15:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35998) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k8tlu-0001cZ-8e for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2020 19:15:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32867) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k8tlt-0001dp-Si for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2020 19:15:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k8tlt-000546-Ne for bug-gnu-emacs@gnu.org; Thu, 20 Aug 2020 19:15:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 20 Aug 2020 23:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36403 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 36403-submit@debbugs.gnu.org id=B36403.159796526019404 (code B ref 36403); Thu, 20 Aug 2020 23:15:01 +0000 Original-Received: (at 36403) by debbugs.gnu.org; 20 Aug 2020 23:14:20 +0000 Original-Received: from localhost ([127.0.0.1]:44412 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8tlD-00052u-RL for submit@debbugs.gnu.org; Thu, 20 Aug 2020 19:14:20 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:35168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k8tlB-00052O-Oc for 36403@debbugs.gnu.org; Thu, 20 Aug 2020 19:14:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eJQ29A0rnTpm6Q9Zc0M7mlHBEUCWwXa4XaEOsJc1kzk=; b=i2Rvzu9KNgkcd7lN6lgJyKZu4s BGWaJN0xydj2V32VwOMnBP1FJ+UcKYLMLuH7d1EbtxGl8V73eoLawyh74sJRdL4h7OB+Lm7Zm4BeY lMLqMuMdjOaId+F8d9rSp0Y5f8neUzMC3p2l4vpdoJ2/StFQ+P/A1Zh7fR1b4ENU8AmQ=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k8tku-00045t-A0; Fri, 21 Aug 2020 01:14:10 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEUcGxogHhsmIh0v KiFEOib///9JOwZRAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+QIFBcMGX+9KgQAAAGmSURBVDjLxVPb keQgDJTwBCDBBgBiAzCIBPaY/GM6AWOP9zFXdV/LB2Wr6ZbUAoDfW/i/AL8AkF5K8b+BOHdHl5Tz a8OJeAdJngxvBLcIyWF6MgKgUxXxf7a9tlKIv/ZBACLKrDTibAzGJMwu7wBhJ61wADm0yhS0pqhb b6WKEA5BLMV2cWC/uQCKi2RVvdFWJILzNZNqAqzq3QJUtUl6ryr9XuVduzYVy2Td+RgfDTB7RLaV jIEoYZT0xaubSVktVorES3xVRQQOEOlwg03N+tAWXa0Wni2bxYiDEdCcyn24tc/j9JAyt4JZ8Tmz LavqXremXSRxXBnmGqZDllysgxTX6dkIbN6Eyjk5XOfZw9ve6tanUjrDUwqrr6GwFxs48gnBtoN1 rQ8dSqfU7eMem95NS3y0AiwoExi9JM724w0YsbXBZkMll3W24EowME7gJtpdb90S5ZC1V52fad6g sMcjp+oYgMi8XVhpWU4gGYke88DxTJimn07K4BHz8Qx42k0oK4YngHj1Ci/ANX7MfF3o59XmOZKf XuZB+/b8+AUArxiL8xeaUTbcszVHHwAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMC0wOC0yMFQyMzox MjoyNCswMDowMP60b0AAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMDgtMjBUMjM6MTI6MjQrMDA6 MDCP6df8AAAAAElFTkSuQmCC X-Now-Playing: Telefon Tel Aviv's _Dreams Are Not Enough_: "eyes glaring," In-Reply-To: <20200820230332.GB38852@breton.holly.idiocy.org> (Alan Third's message of "Fri, 21 Aug 2020 01:03:34 +0200 (CEST)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185795 Archived-At: Alan Third writes: > Hi, this patch appears to have broken something (in NS at least) and > now interactively resizing an image no longer causes the image to be > immediately redisplayed. I have to force a redisplay some other way > before I see the resized image. Yup. This patch fixes things for me (on Debian)... diff --git a/src/image.c b/src/image.c index 643b3d0a1f..ceb690ed0a 100644 --- a/src/image.c +++ b/src/image.c @@ -1633,7 +1633,7 @@ search_image_cache (struct frame *f, Lisp_Object spec, EMACS_UINT hash) for (img = c->buckets[i]; img; img = img->next) if (img->hash == hash - && !equal_lists (img->spec, spec) + && !NILP (Fequal (img->spec, spec)) && img->frame_foreground == FRAME_FOREGROUND_PIXEL (f) && img->frame_background == FRAME_BACKGROUND_PIXEL (f)) break; The equal_lists thing looks sensible, but I guess we do destructive alterations with +/-, possibly, to equal is the correct thing, not a list-of-eqs? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no