From: Lars Ingebrigtsen <larsi@gnus.org>
To: dick <dick.r.chiang@gmail.com>
Cc: 45907@debbugs.gnu.org
Subject: bug#45907: [PATCH] Shr memory singularity gif89a
Date: Tue, 19 Jan 2021 06:57:47 +0100 [thread overview]
Message-ID: <87v9bto4dg.fsf@gnus.org> (raw)
In-Reply-To: <871relaiyy.fsf@dick> (dick's message of "Fri, 15 Jan 2021 18:17:09 -0500")
dick <dick.r.chiang@gmail.com> writes:
> With the increased use of gif89a, my gnus is achieving memory
> consumption singularity more frequently.
>
> * lisp/net/shr.el (shr-put-image): When content-type is
> application/octet-stream, do not attempt insert-image.
This was a slightly confusing bug report and patch, but I think this was
the proposed functional change:
diff --git a/lisp/net/shr.el b/lisp/net/shr.el
index 9c3740fccc..c05ac17521 100644
--- a/lisp/net/shr.el
+++ b/lisp/net/shr.el
@@ -1124,6 +1124,8 @@ shr-put-image
((eq content-type 'image/svg+xml)
(when (image-type-available-p 'svg)
(create-image data 'svg t :ascent 100)))
+ ((eq content-type 'application/octet-stream)
+ nil)
((eq size 'full)
(ignore-errors
(shr-rescale-image data content-type
But I don't think that makes much sense: It doesn't really matter what
the content type is. The problem is that Emacs chokes on a particular
GIF file. To reproduce:
curl "https://raw.githubusercontent.com/enphysoft/search-gmail-using-message-id/main/images/lgmid.gif" > /tmp/lgmid.gif
emacs -Q /tmp/lgmid.gif
This initially hangs Emacs, but then it finally is able to display the
file... but Emacs uses 2GB worth of memory and 100% CPU.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-01-19 5:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 23:17 bug#45907: [PATCH] Shr memory singularity gif89a dick
2021-01-18 10:45 ` Robert Pluim
2021-01-19 5:57 ` Lars Ingebrigtsen [this message]
2021-01-19 16:53 ` dick
2021-01-19 17:47 ` Lars Ingebrigtsen
2021-01-19 23:27 ` dick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9bto4dg.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=45907@debbugs.gnu.org \
--cc=dick.r.chiang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).