unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: dick <dick.r.chiang@gmail.com>
Cc: 45907@debbugs.gnu.org
Subject: bug#45907: [PATCH] Shr memory singularity gif89a
Date: Mon, 18 Jan 2021 11:45:14 +0100	[thread overview]
Message-ID: <87ft2ywmkl.fsf@gmail.com> (raw)
In-Reply-To: <871relaiyy.fsf@dick> (dick's message of "Fri, 15 Jan 2021 18:17:09 -0500")

>>>>> On Fri, 15 Jan 2021 18:17:09 -0500, dick <dick.r.chiang@gmail.com> said:

Your patch has spurious whitespace changes. Also, your checks for
display-graphic-p are not the right thing to do: the tests need to be
fixed to work, rather than skipped (I think Eli may already have done
this).

Robert





  reply	other threads:[~2021-01-18 10:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-15 23:17 bug#45907: [PATCH] Shr memory singularity gif89a dick
2021-01-18 10:45 ` Robert Pluim [this message]
2021-01-19  5:57 ` Lars Ingebrigtsen
2021-01-19 16:53   ` dick
2021-01-19 17:47     ` Lars Ingebrigtsen
2021-01-19 23:27       ` dick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ft2ywmkl.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=45907@debbugs.gnu.org \
    --cc=dick.r.chiang@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).