* bug#49574: 28.0.50; [ELPA] [PATCH] Remove deprecated modus-{operandi,vivendi}-themes
@ 2021-07-15 14:39 Protesilaos Stavrou
2021-07-16 10:12 ` Lars Ingebrigtsen
0 siblings, 1 reply; 9+ messages in thread
From: Protesilaos Stavrou @ 2021-07-15 14:39 UTC (permalink / raw)
To: 49574
[-- Attachment #1: Type: text/plain, Size: 640 bytes --]
Hello everyone,
Following the release of version 1.5.0 of the modus-themes (bug#49572),
I believe this is the right time to remove the long-discontinued
packages 'modus-operandi-theme' and 'modus-vivendi-theme'.
The technicalities were discussed in bug#46964, with the gist being that
we would provide users a few months to migrate to the new 'modus-themes'
package. We had also introduced code in the old packages that would
pull in the new package, so we can assume that the old packages are no
longer required.
The change I would like to install is attached.
Thank you!
Protesilaos
--
Protesilaos Stavrou
https://protesilaos.com
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Remove-deprecated-modus-operandi-vivendi-themes.patch --]
[-- Type: text/x-patch, Size: 1772 bytes --]
From b438674100fab7fa7f7424cd6f185e002597c0cb Mon Sep 17 00:00:00 2001
Message-Id: <b438674100fab7fa7f7424cd6f185e002597c0cb.1626359505.git.info@protesilaos.com>
From: Protesilaos Stavrou <info@protesilaos.com>
Date: Thu, 15 Jul 2021 17:31:33 +0300
Subject: [PATCH] Remove deprecated modus-{operandi,vivendi}-themes
Subject to bug#49572, which updates the modus-themes in emacs.git to
version 1.5.0, it now is the right time to delete the long-deprecated
standalone packages of modus-operandi and modus-vivendi.
---
elpa-packages | 7 -------
1 file changed, 7 deletions(-)
diff --git a/elpa-packages b/elpa-packages
index e7c527f6a1..af7f075913 100644
--- a/elpa-packages
+++ b/elpa-packages
@@ -233,19 +233,12 @@
("mmm-mode"
:url "https://github.com/purcell/mmm-mode.git"
:auto-sync t)
- ;; `modus-operandi-theme' and `modus-vivendi-theme' are deprecated and
- ;; will have to be deleted by the summer of 2021, as discussed in Emacs
- ;; bug#46964: <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=46964>.
- ("modus-operandi-theme":url "https://gitlab.com/protesilaos/modus-themes"
- :branch "elpa/modus-operandi-theme")
("modus-themes" :core ("etc/themes/modus-themes.el"
"etc/themes/modus-operandi-theme.el"
"etc/themes/modus-vivendi-theme.el"
"doc/misc/modus-themes.org"
"doc/misc/doclicense.texi")
:doc "modus-themes.org")
- ("modus-vivendi-theme" :url "https://gitlab.com/protesilaos/modus-themes"
- :branch "elpa/modus-vivendi-theme")
("multishell" :url "https://github.com/kenmanheimer/EmacsMultishell")
("muse" :url "https://github.com/alexott/muse") ;FIXME: Not nearly in-sync
("myers" :url nil)
--
2.32.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* bug#49574: 28.0.50; [ELPA] [PATCH] Remove deprecated modus-{operandi,vivendi}-themes
2021-07-15 14:39 bug#49574: 28.0.50; [ELPA] [PATCH] Remove deprecated modus-{operandi,vivendi}-themes Protesilaos Stavrou
@ 2021-07-16 10:12 ` Lars Ingebrigtsen
2021-07-16 10:15 ` Protesilaos Stavrou
2021-07-16 11:35 ` Eli Zaretskii
0 siblings, 2 replies; 9+ messages in thread
From: Lars Ingebrigtsen @ 2021-07-16 10:12 UTC (permalink / raw)
To: Protesilaos Stavrou; +Cc: 49574
Protesilaos Stavrou <info@protesilaos.com> writes:
> Following the release of version 1.5.0 of the modus-themes (bug#49572),
> I believe this is the right time to remove the long-discontinued
> packages 'modus-operandi-theme' and 'modus-vivendi-theme'.
>
> The technicalities were discussed in bug#46964, with the gist being that
> we would provide users a few months to migrate to the new 'modus-themes'
> package. We had also introduced code in the old packages that would
> pull in the new package, so we can assume that the old packages are no
> longer required.
>
> The change I would like to install is attached.
The deprecated themes were also new in Emacs 28, so I think removing
them (since they've been replaced by a new theme) should be fine.
Eli, do you have an opinion here?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#49574: 28.0.50; [ELPA] [PATCH] Remove deprecated modus-{operandi,vivendi}-themes
2021-07-16 10:12 ` Lars Ingebrigtsen
@ 2021-07-16 10:15 ` Protesilaos Stavrou
2021-07-16 11:35 ` Eli Zaretskii
1 sibling, 0 replies; 9+ messages in thread
From: Protesilaos Stavrou @ 2021-07-16 10:15 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 49574
On 2021-07-16, 12:12 +0200, Lars Ingebrigtsen <larsi@gnus.org> wrote:
> Protesilaos Stavrou <info@protesilaos.com> writes:
>
>> Following the release of version 1.5.0 of the modus-themes (bug#49572),
>> I believe this is the right time to remove the long-discontinued
>> packages 'modus-operandi-theme' and 'modus-vivendi-theme'.
>>
>> The technicalities were discussed in bug#46964, with the gist being that
>> we would provide users a few months to migrate to the new 'modus-themes'
>> package. We had also introduced code in the old packages that would
>> pull in the new package, so we can assume that the old packages are no
>> longer required.
>>
>> The change I would like to install is attached.
>
> The deprecated themes were also new in Emacs 28, so I think removing
> them (since they've been replaced by a new theme) should be fine.
>
> Eli, do you have an opinion here?
Just to add here that the current files in emacs.git are automatically
synced into the 'modus-themes' GNU ELPA package. Whereas the old
packages were pulled from dedicated branches on my own git repo.
--
Protesilaos Stavrou
https://protesilaos.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#49574: 28.0.50; [ELPA] [PATCH] Remove deprecated modus-{operandi,vivendi}-themes
2021-07-16 10:12 ` Lars Ingebrigtsen
2021-07-16 10:15 ` Protesilaos Stavrou
@ 2021-07-16 11:35 ` Eli Zaretskii
2021-07-16 11:57 ` Lars Ingebrigtsen
1 sibling, 1 reply; 9+ messages in thread
From: Eli Zaretskii @ 2021-07-16 11:35 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 49574, info
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: 49574@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
> Date: Fri, 16 Jul 2021 12:12:07 +0200
>
> > The technicalities were discussed in bug#46964, with the gist being that
> > we would provide users a few months to migrate to the new 'modus-themes'
> > package. We had also introduced code in the old packages that would
> > pull in the new package, so we can assume that the old packages are no
> > longer required.
> >
> > The change I would like to install is attached.
>
> The deprecated themes were also new in Emacs 28, so I think removing
> them (since they've been replaced by a new theme) should be fine.
>
> Eli, do you have an opinion here?
No. Please do what you feel is right here.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#49574: 28.0.50; [ELPA] [PATCH] Remove deprecated modus-{operandi,vivendi}-themes
2021-07-16 11:35 ` Eli Zaretskii
@ 2021-07-16 11:57 ` Lars Ingebrigtsen
2021-07-16 12:06 ` Protesilaos Stavrou
0 siblings, 1 reply; 9+ messages in thread
From: Lars Ingebrigtsen @ 2021-07-16 11:57 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 49574, info
Eli Zaretskii <eliz@gnu.org> writes:
>> The deprecated themes were also new in Emacs 28, so I think removing
>> them (since they've been replaced by a new theme) should be fine.
>>
>> Eli, do you have an opinion here?
>
> No. Please do what you feel is right here.
OK, Protesilaos, go ahead and push.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#49574: 28.0.50; [ELPA] [PATCH] Remove deprecated modus-{operandi,vivendi}-themes
2021-07-16 11:57 ` Lars Ingebrigtsen
@ 2021-07-16 12:06 ` Protesilaos Stavrou
2021-07-19 15:39 ` Lars Ingebrigtsen
0 siblings, 1 reply; 9+ messages in thread
From: Protesilaos Stavrou @ 2021-07-16 12:06 UTC (permalink / raw)
To: Lars Ingebrigtsen, Eli Zaretskii; +Cc: 49574
On 2021-07-16, 13:57 +0200, Lars Ingebrigtsen <larsi@gnus.org> wrote:
> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> The deprecated themes were also new in Emacs 28, so I think removing
>>> them (since they've been replaced by a new theme) should be fine.
>>>
>>> Eli, do you have an opinion here?
>>
>> No. Please do what you feel is right here.
>
> OK, Protesilaos, go ahead and push.
Done. Thank you for your time!
--
Protesilaos Stavrou
https://protesilaos.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#49574: 28.0.50; [ELPA] [PATCH] Remove deprecated modus-{operandi,vivendi}-themes
2021-07-16 12:06 ` Protesilaos Stavrou
@ 2021-07-19 15:39 ` Lars Ingebrigtsen
2021-07-19 15:50 ` Protesilaos Stavrou
0 siblings, 1 reply; 9+ messages in thread
From: Lars Ingebrigtsen @ 2021-07-19 15:39 UTC (permalink / raw)
To: Protesilaos Stavrou; +Cc: 49574
Protesilaos Stavrou <info@protesilaos.com> writes:
>> OK, Protesilaos, go ahead and push.
>
> Done. Thank you for your time!
Did you forget to push this?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#49574: 28.0.50; [ELPA] [PATCH] Remove deprecated modus-{operandi,vivendi}-themes
2021-07-19 15:39 ` Lars Ingebrigtsen
@ 2021-07-19 15:50 ` Protesilaos Stavrou
2021-07-19 15:56 ` Lars Ingebrigtsen
0 siblings, 1 reply; 9+ messages in thread
From: Protesilaos Stavrou @ 2021-07-19 15:50 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 49574
On 2021-07-19, 17:39 +0200, Lars Ingebrigtsen <larsi@gnus.org> wrote:
> Protesilaos Stavrou <info@protesilaos.com> writes:
>
>>> OK, Protesilaos, go ahead and push.
>>
>> Done. Thank you for your time!
>
> Did you forget to push this?
I did. Here it is:
<https://git.savannah.gnu.org/cgit/emacs/elpa.git/commit/?id=b438674100fab7fa7f7424cd6f185e002597c0cb>.
--
Protesilaos Stavrou
https://protesilaos.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#49574: 28.0.50; [ELPA] [PATCH] Remove deprecated modus-{operandi,vivendi}-themes
2021-07-19 15:50 ` Protesilaos Stavrou
@ 2021-07-19 15:56 ` Lars Ingebrigtsen
0 siblings, 0 replies; 9+ messages in thread
From: Lars Ingebrigtsen @ 2021-07-19 15:56 UTC (permalink / raw)
To: Protesilaos Stavrou; +Cc: 49574
Protesilaos Stavrou <info@protesilaos.com> writes:
> I did. Here it is:
> <https://git.savannah.gnu.org/cgit/emacs/elpa.git/commit/?id=b438674100fab7fa7f7424cd6f185e002597c0cb>.
Sorry; I looked in the wrong place. :-/
I'm closing this bug report, then.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-07-19 15:56 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-15 14:39 bug#49574: 28.0.50; [ELPA] [PATCH] Remove deprecated modus-{operandi,vivendi}-themes Protesilaos Stavrou
2021-07-16 10:12 ` Lars Ingebrigtsen
2021-07-16 10:15 ` Protesilaos Stavrou
2021-07-16 11:35 ` Eli Zaretskii
2021-07-16 11:57 ` Lars Ingebrigtsen
2021-07-16 12:06 ` Protesilaos Stavrou
2021-07-19 15:39 ` Lars Ingebrigtsen
2021-07-19 15:50 ` Protesilaos Stavrou
2021-07-19 15:56 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).