unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Robert Pluim <rpluim@gmail.com>
To: "समीर सिंह Sameer Singh" <lumarzeli30@gmail.com>
Cc: 58111@debbugs.gnu.org
Subject: bug#58111: [PATCH] Add support for the Adlam script
Date: Tue, 27 Sep 2022 15:05:45 +0200	[thread overview]
Message-ID: <87v8p97ys6.fsf@gmail.com> (raw)
In-Reply-To: <CAOR1sLyXNx=diMJkY3oX3-D_YvarAJKaHN7efj_CF2qLzmZKrw@mail.gmail.com> ("समीर सिंह Sameer Singh"'s message of "Tue, 27 Sep 2022 16:52:22 +0530")

>>>>> On Tue, 27 Sep 2022 16:52:22 +0530, समीर सिंह Sameer Singh <lumarzeli30@gmail.com> said:


    समीर> * lisp/language/misc-lang.el ("Adlam"): New language environment.
    समीर> Add composition rules for Adlam. Add sample text and input method.

Two spaces after full stop.

    समीर> @@ -1229,10 +1229,9 @@ to edit such sequences by allowing point to "enter" the sequence.
    समीर>  *** Support for many old scripts and writing systems.
    समीर>  Emacs now supports and has language-environments and input methods for
    समीर>  several dozens of old scripts that were used in the past for various
    समीर> -languages in South and South-East Asia.  For each such script Emacs
    समीर> -now has font-selection and character composition rules, a language
    समीर> -environment, and an input method.  The newly-added scripts and the
    समीर> -corresponding language environments are:
    समीर> +languages.  For each such script Emacs now has font-selection and character
    समीर> +composition rules, a language environment, and an input method.  The newly-added
    समीर> +scripts and the corresponding language environments are:

I think this text should be re-wrapped ('M-q')

    समीर> +(quail-define-package
    समीर> + "adlam" "Adlam" "𞤀" t "Adlam input method.
    समीर> +
    समीर> + `\\=`' is used to switch levels instead of Alt-Gr.

Are the `' necessary around the "\\=" ?

The rest looks good to a limited Latin-1 person such as myself :-)

Thanks for doing this.

Robert
-- 





  reply	other threads:[~2022-09-27 13:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-27 11:19 bug#58111: [PATCH] Add support for the Adlam script समीर सिंह Sameer Singh
2022-09-27 11:22 ` समीर सिंह Sameer Singh
2022-09-27 13:05   ` Robert Pluim [this message]
2022-09-27 15:42     ` समीर सिंह Sameer Singh
2022-09-27 16:10       ` Robert Pluim
2022-09-27 13:15   ` Eli Zaretskii
2022-09-27 15:53     ` समीर सिंह Sameer Singh
2022-09-27 16:36       ` Eli Zaretskii
2022-09-28  6:25         ` समीर सिंह Sameer Singh
2022-09-28 12:44           ` Eli Zaretskii
2022-09-28 12:56             ` समीर सिंह Sameer Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8p97ys6.fsf@gmail.com \
    --to=rpluim@gmail.com \
    --cc=58111@debbugs.gnu.org \
    --cc=lumarzeli30@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).