unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "समीर सिंह Sameer Singh" <lumarzeli30@gmail.com>
Cc: 58111@debbugs.gnu.org
Subject: bug#58111: [PATCH] Add support for the Adlam script
Date: Tue, 27 Sep 2022 19:36:23 +0300	[thread overview]
Message-ID: <83y1u4ixko.fsf@gnu.org> (raw)
In-Reply-To: <CAOR1sLyWefxFPaC3kDZMLN91nx_3mPa+2mvqzVG4kAZz2Ti+kA@mail.gmail.com> (message from समीर सिंह Sameer Singh on Tue, 27 Sep 2022 21:23:40 +0530)

> From: समीर सिंह Sameer Singh <lumarzeli30@gmail.com>
> Date: Tue, 27 Sep 2022 21:23:40 +0530
> Cc: 58111@debbugs.gnu.org
> 
>  This doesn't look right: why 1 and not 0?
> 
> I copied this from my hanifi-rohingya composition rules, where I do not remember
> why I added 0 instead of 1. Even though they were working as intended I have replaced it with 0
> there just to be safe. 

In hanifi-rohingya, the codepoints that triggered composition were
between #x10D1D and #x10D27, whereas the regexp was
"[\x10D00-\x10D27]+", which matches many more characters.  With 1 as
the 2nd element of the rule vector, this means the sequence of
characters U+10D00 U+10D00 will not cause composition, but the
sequence U+10D00 U+10D1D will.  By contrast, in Adlam case, the
characters that trigger composition and the regexp are identical, so I
see no reason to trigger the composition only on the second character
of a sequence.

I see that you have now changed the hanifi-rohingya as well, but I'm
not sure that does what you want.  Please consider the effect I
described above, and decide whether you want 0 or 1 there.





  reply	other threads:[~2022-09-27 16:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-27 11:19 bug#58111: [PATCH] Add support for the Adlam script समीर सिंह Sameer Singh
2022-09-27 11:22 ` समीर सिंह Sameer Singh
2022-09-27 13:05   ` Robert Pluim
2022-09-27 15:42     ` समीर सिंह Sameer Singh
2022-09-27 16:10       ` Robert Pluim
2022-09-27 13:15   ` Eli Zaretskii
2022-09-27 15:53     ` समीर सिंह Sameer Singh
2022-09-27 16:36       ` Eli Zaretskii [this message]
2022-09-28  6:25         ` समीर सिंह Sameer Singh
2022-09-28 12:44           ` Eli Zaretskii
2022-09-28 12:56             ` समीर सिंह Sameer Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83y1u4ixko.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=58111@debbugs.gnu.org \
    --cc=lumarzeli30@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).