bug#12514: 24.2; message-make-date returns a localized date after X restart

bug#12514: 24.2; message-make-date returns a localized date after X restart

[Marco Pessotto]

Sorry for the cross-post to bugs@gnus.org, but I suspect the bug is more
related to Emacs than to Gnus, as it seems to be at C level. Or
maybe this is related to some libraries shipped by Debian.

The bug is present at least since emacs 23.2.

start emacs with emacs --daemon

start gnus to load message.el

(message-make-date)

=> "Tue, 25 Sep 2012 15:43:59 +0200"

; kill X

(message-make-date)

=> "mar, 25 set 2012 15:44:31 +0200"

; message-make-date is a two lines function:

(let ((system-time-locale "C"))
  (format-time-string "%a, %d %b %Y %T %z"))

=> "Tue, 25 Sep 2012 15:45:13 +0200"

; after the evaluation, everything is back to normal

; without evaluating it, calling (message-make-date) alone continues
; to return a localized date.

(message-make-date)

=> "Tue, 25 Sep 2012 15:45:32 +0200"

Best wishes


In GNU Emacs 24.2.1 (i686-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2012-09-25 on universe
Windowing system distributor `The X.Org Foundation', version 11.0.11004000
Configured using:
 `configure '--with-x-toolkit=lucid''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: it_IT.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
M-x g <backspace> v <backspace> v e r s i o n <return> 
( m e s s a g e - m a k e - d a <M-backspace> <M-backspace> 
<M-backspace> <M-backspace> C-n M-x g n u s <return> 
y M-x m e s s a g - e m <backspace> <backspace> <backspace> 
e - m a k <tab> e <tab> C-g C-g q y <return> <return> 
( m e s s a g e - m a k e - d a t e ) C-x C-e C-x C-e 
C-u C-x C-e C-a M-f M-f M-f C-f <return> <return> C-n 
C-n <return> <return> C-x C-f <M-backspace> <M-backspace> 
<M-backspace> <M-backspace> <backspace> <backspace> 
m e <backspace> <backspace> ~ / m e <tab> <backspace> 
<backspace> <tab> <tab> * b u g <tab> <M-backspace> 
<backspace> m k a <backspace> <backspace> a k e <tab> 
<return> C-p C-p C-p M-< C-SPC M-> M-w C-x b <return> 
C-y C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p 
C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p 
C-p C-p C-n C-SPC C-n C-n C-n C-n C-w C-n C-n C-n C-n 
C-n C-n C-n C-n C-n C-n C-n C-p C-p C-p C-p C-e C-x 
C-e C-n C-n C-n C-n C-n C-e C-x C-e C-n C-n C-n C-n 
C-n C-n C-x C-e C-p C-p C-p C-p C-p C-p C-p C-p C-p 
C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-n C-SPC C-n 
C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-n C-n C-n C-n C-n C-n C-n C-n M-w M-x g n u <backspace> 
<backspace> <backspace> e m - <backspace> a c s - <tab> 
<M-backspace> r e p o <tab> r t <tab> <return>

Recent messages:
byte-code: Beginning of buffer [3 times]
Mark set
Mark activated
Mark set [2 times]
"mar, 25 set 2012 15:55:51 +0200"
"Tue, 25 Sep 2012 15:55:53 +0200"
"Tue, 25 Sep 2012 15:55:55 +0200"
Mark activated
byte-code: End of buffer
Making completion list... [2 times]

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug sendmail regexp-opt help-mode view
nndraft nnmh nnagent nnml network-stream auth-source eieio byte-opt
bytecomp byte-compile cconv macroexp assoc starttls tls gnus-agent
gnus-srvr gnus-score score-mode nnvirtual gnus-msg gnus-art mm-uu
mml2015 epg-config mm-view mml-smime smime password-cache dig mailcap
nntp gnus-cache gnus-sum nnoo gnus-group gnus-undo nnmail mail-source
gnus-start gnus-spec gnus-int gnus-range message format-spec rfc822 mml
easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231
rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils mailheader gnus-win gnus
gnus-ems nnheader gnus-util mail-utils mm-util mail-prsvr wid-edit
server time-date tooltip ediff-hook vc-hooks lisp-float-type mwheel
x-win x-dnd tool-bar dnd fontset image fringe lisp-mode register page
menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core frame cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer loaddefs
button faces cus-face files text-properties overlay sha1 md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote make-network-process dbusbind dynamic-setting
system-font-setting font-render-setting x-toolkit x multi-tty emacs)


-- 
Marco

bug#12514: 24.2; message-make-date returns a localized date after X restart

[Lars Ingebrigtsen]

Marco Pessotto <melmothx@gmail.com> writes:

> Sorry for the cross-post to bugs@gnus.org, but I suspect the bug is more
> related to Emacs than to Gnus, as it seems to be at C level. Or
> maybe this is related to some libraries shipped by Debian.
>
> The bug is present at least since emacs 23.2.
>
> start emacs with emacs --daemon
>
> start gnus to load message.el
>
> (message-make-date)
>
> => "Tue, 25 Sep 2012 15:43:59 +0200"
>
> ; kill X
>
> (message-make-date)
>
> => "mar, 25 set 2012 15:44:31 +0200"
>
> ; message-make-date is a two lines function:
>
> (let ((system-time-locale "C"))
>   (format-time-string "%a, %d %b %Y %T %z"))
>
> => "Tue, 25 Sep 2012 15:45:13 +0200"

This is the definition of `message-make-date', so this seems rather odd:

(defun message-make-date (&optional now)
  "Make a valid data header.
If NOW, use that time instead."
  (let ((system-time-locale "C"))
    (format-time-string "%a, %d %b %Y %T %z" now)))

Are you picking up a very old version of message.el from somewhere,
perhaps?  Or are you redefining `message-make-date'?

-- 
(domestic pets only, the antidote for overdose, milk.)
  http://lars.ingebrigtsen.no  *  Lars Magne Ingebrigtsen

bug#12514: 24.2; message-make-date returns a localized date after X restart

[Marco Pessotto]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> This is the definition of `message-make-date', so this seems rather odd:
>
> (defun message-make-date (&optional now)
>   "Make a valid data header.
> If NOW, use that time instead."
>   (let ((system-time-locale "C"))
>     (format-time-string "%a, %d %b %Y %T %z" now)))
>
> Are you picking up a very old version of message.el from somewhere,
> perhaps?  Or are you redefining `message-make-date'?

No and no. "Library is file /usr/share/emacs/23.2/lisp/gnus/message.elc"

I run GNU Emacs shipped with Debian. GNU Emacs 23.2.1
(i486-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2010-12-11 on
raven, modified by Debian.

I can reliably reproduce this bug on my box with the receipt provided.
My workaround was to put something like this in .xinitrc:

emacsclient -e '(let ((system-time-locale "C")) (format-time-string "%a,
%d %b %Y %T %z"))'

After the apparently useless evaluation, everything is back to normal.
From what I can see, the bug is deep inside the C code or related
libraries shipped by Debian, as the Lisp looks quite fine (I did some
source-diving myself).

I can reproduce it reliably with emacs 24.2 too.

; start emacs
emacs --daemon
emacsclient -c -n

; start gnus

; evaluate: everything fine
(message-make-date)
"Tue, 25 Dec 2012 17:44:53 +0100"

; kill X and leave the daemon alive
; bring the emacs back with emacsclient -c -n


; evaluate first time, here we have the broken header
(message-make-date)
"mar, 25 dic 2012 17:45:40 +0100"

(emacs-version)
"GNU Emacs 24.2.2 (i686-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2012-12-25 on universe"

; and now we're back to normal, after the first evaluation
(message-make-date)
"Tue, 25 Dec 2012 17:46:23 +0100"

(gnus-version)
"Gnus v5.13"

Please let me know if I can help in some way.

Best wishes and thanks for your awesome work.

-- 
Marco

bug#12514: 24.2; message-make-date returns a localized date after X restart

[Lars Ingebrigtsen]

Marco Pessotto <melmothx@gmail.com> writes:

> emacsclient -e '(let ((system-time-locale "C")) (format-time-string "%a,
> %d %b %Y %T %z"))'
>
> After the apparently useless evaluation, everything is back to normal.
>>From what I can see, the bug is deep inside the C code or related
> libraries shipped by Debian, as the Lisp looks quite fine (I did some
> source-diving myself).

Oh, it's that bug.  There was some talk about fixing this a few days
ago, but I don't recall what the result was.

Anybody?

Anyway, it's an Emacs bug, not a Gnus bug, so I'm reassigning back to
Emacs.

-- 
(domestic pets only, the antidote for overdose, milk.)
  http://lars.ingebrigtsen.no  *  Lars Magne Ingebrigtsen

bug#12514: 24.2; message-make-date returns a localized date after X restart

[Lars Ingebrigtsen]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Marco Pessotto <melmothx@gmail.com> writes:
>
>> emacsclient -e '(let ((system-time-locale "C")) (format-time-string "%a,
>> %d %b %Y %T %z"))'
>>
>> After the apparently useless evaluation, everything is back to normal.
>>>>From what I can see, the bug is deep inside the C code or related
>> libraries shipped by Debian, as the Lisp looks quite fine (I did some
>> source-diving myself).
>
> Oh, it's that bug.  There was some talk about fixing this a few days
> ago, but I don't recall what the result was.

I'm pretty sure this was fixed at the time (six years ago), so I'm
closing this bug report.  If it's still present, please reopen.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no