unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#34976: [debbugs.el] debbugs-read-emacs-bug-with-gnus sets user options
@ 2019-03-24 15:32 Basil L. Contovounesios
  2019-03-25 16:45 ` Michael Albinus
  0 siblings, 1 reply; 13+ messages in thread
From: Basil L. Contovounesios @ 2019-03-24 15:32 UTC (permalink / raw)
  To: 34976; +Cc: lars ingebrigtsen, michael albinus, noam postavsky

X-Debbugs-Cc: Lars Ingebrigtsen <larsi@gnus.org>, Michael Albinus <michael.albinus@gmx.de>, Noam Postavsky <npostavs@gmail.com>

When I use Gnus as my MUA, I leave the user options
gnus-suppress-duplicates and gnus-save-duplicate-list at their default
value of nil, as I have not yet run into any issues with duplicate
messages.

After using debbugs.el, however, I noticed that the value of these two
user options had been changed, and a file called 'suppression' had
appeared under my gnus-directory.  I think this was caused by a change
to debbugs-read-emacs-bug-with-gnus[1].

[1]: Save list of read articles
  2015-12-26 01:17:29 +0100
  https://git.savannah.gnu.org/cgit/emacs/elpa.git/commit/?id=f43413e5ad2817fb0ee055e358178924a6affe8b

I don't know what sort of issues gave rise to this change, but it would
be nice if debbugs.el could do its job without permanently changing the
value of user options from other packages.

Thanks,

-- 
Basil

In GNU Emacs 27.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2019-03-24 built on thunk
Repository revision: dbd6490ad49b0f088d56cdd5f04178bdd62c806a
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12003000
System Description: Debian GNU/Linux buster/sid





^ permalink raw reply	[flat|nested] 13+ messages in thread

* bug#34976: [debbugs.el] debbugs-read-emacs-bug-with-gnus sets user options
  2019-03-24 15:32 bug#34976: [debbugs.el] debbugs-read-emacs-bug-with-gnus sets user options Basil L. Contovounesios
@ 2019-03-25 16:45 ` Michael Albinus
  2019-03-25 17:40   ` Lars Ingebrigtsen
  0 siblings, 1 reply; 13+ messages in thread
From: Michael Albinus @ 2019-03-25 16:45 UTC (permalink / raw)
  To: Basil L. Contovounesios; +Cc: lars ingebrigtsen, noam postavsky, 34976

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

> When I use Gnus as my MUA, I leave the user options
> gnus-suppress-duplicates and gnus-save-duplicate-list at their default
> value of nil, as I have not yet run into any issues with duplicate
> messages.
>
> After using debbugs.el, however, I noticed that the value of these two
> user options had been changed, and a file called 'suppression' had
> appeared under my gnus-directory.  I think this was caused by a change
> to debbugs-read-emacs-bug-with-gnus[1].
>
> [1]: Save list of read articles
>   2015-12-26 01:17:29 +0100
>   https://git.savannah.gnu.org/cgit/emacs/elpa.git/commit/?id=f43413e5ad2817fb0ee055e358178924a6affe8b
>
> I don't know what sort of issues gave rise to this change, but it would
> be nice if debbugs.el could do its job without permanently changing the
> value of user options from other packages.

Looks like this is a preference Lars needs for his workflow. Lars, do
you still need this? Or shall we convert this setting into a user option
you would set, in order not to annoy other people?

> Thanks,

Best regards, Michael.





^ permalink raw reply	[flat|nested] 13+ messages in thread

* bug#34976: [debbugs.el] debbugs-read-emacs-bug-with-gnus sets user options
  2019-03-25 16:45 ` Michael Albinus
@ 2019-03-25 17:40   ` Lars Ingebrigtsen
  2019-03-25 17:46     ` Michael Albinus
  0 siblings, 1 reply; 13+ messages in thread
From: Lars Ingebrigtsen @ 2019-03-25 17:40 UTC (permalink / raw)
  To: Michael Albinus; +Cc: Basil L. Contovounesios, noam postavsky, 34976

Michael Albinus <michael.albinus@gmx.de> writes:

> Looks like this is a preference Lars needs for his workflow. Lars, do
> you still need this? Or shall we convert this setting into a user option
> you would set, in order not to annoy other people?

I'm not quite sure I understand the last sentence there, but debbugs-gnu
shouldn't be setting those variables globally.  Perhaps buffer-local or
something? 

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 13+ messages in thread

* bug#34976: [debbugs.el] debbugs-read-emacs-bug-with-gnus sets user options
  2019-03-25 17:40   ` Lars Ingebrigtsen
@ 2019-03-25 17:46     ` Michael Albinus
  2019-03-25 17:48       ` Lars Ingebrigtsen
  0 siblings, 1 reply; 13+ messages in thread
From: Michael Albinus @ 2019-03-25 17:46 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: Basil L. Contovounesios, noam postavsky, 34976

Lars Ingebrigtsen <larsi@gnus.org> writes:

> I'm not quite sure I understand the last sentence there, but debbugs-gnu
> shouldn't be setting those variables globally.  Perhaps buffer-local or
> something?

Well, that's OK for gnus-suppress-duplicates. But
gnus-save-duplicate-list seems to be taken into account only when you
leave Gnus. So I don't know how to set it locally (but this might be
simply because I don't know Gnus in detail).

That's why I thought we could add a user option debbugs-lars-workflow or
alike :-) If non-nil, the gnus-* variables would be set as of today.

Best regards, Michael.





^ permalink raw reply	[flat|nested] 13+ messages in thread

* bug#34976: [debbugs.el] debbugs-read-emacs-bug-with-gnus sets user options
  2019-03-25 17:46     ` Michael Albinus
@ 2019-03-25 17:48       ` Lars Ingebrigtsen
  2019-03-25 18:14         ` Basil L. Contovounesios
  2019-03-26 15:56         ` Michael Albinus
  0 siblings, 2 replies; 13+ messages in thread
From: Lars Ingebrigtsen @ 2019-03-25 17:48 UTC (permalink / raw)
  To: Michael Albinus; +Cc: Basil L. Contovounesios, noam postavsky, 34976

Michael Albinus <michael.albinus@gmx.de> writes:

> That's why I thought we could add a user option debbugs-lars-workflow or
> alike :-) If non-nil, the gnus-* variables would be set as of today.

:-)

Sounds good.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 13+ messages in thread

* bug#34976: [debbugs.el] debbugs-read-emacs-bug-with-gnus sets user options
  2019-03-25 17:48       ` Lars Ingebrigtsen
@ 2019-03-25 18:14         ` Basil L. Contovounesios
  2019-03-25 18:25           ` Michael Albinus
  2019-03-26 15:56         ` Michael Albinus
  1 sibling, 1 reply; 13+ messages in thread
From: Basil L. Contovounesios @ 2019-03-25 18:14 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: Michael Albinus, noam postavsky, 34976

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Michael Albinus <michael.albinus@gmx.de> writes:
>
>> That's why I thought we could add a user option debbugs-lars-workflow or
>> alike :-) If non-nil, the gnus-* variables would be set as of today.
>
> :-)
>
> Sounds good.

Sorry if I'm missing something obvious, but how would setting this new
debbugs user option be different from setting the existing Gnus user
options?  In other words, why can't users who want a Lars-esque workflow
(Larsflow?) just set the gnus-* user options themselves?  Wouldn't the
proposed debbugs user option be redundant?

Thanks,

-- 
Basil





^ permalink raw reply	[flat|nested] 13+ messages in thread

* bug#34976: [debbugs.el] debbugs-read-emacs-bug-with-gnus sets user options
  2019-03-25 18:14         ` Basil L. Contovounesios
@ 2019-03-25 18:25           ` Michael Albinus
  2019-03-25 18:41             ` Basil L. Contovounesios
  0 siblings, 1 reply; 13+ messages in thread
From: Michael Albinus @ 2019-03-25 18:25 UTC (permalink / raw)
  To: Basil L. Contovounesios; +Cc: Lars Ingebrigtsen, noam postavsky, 34976

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

Hi Basil,

> Sorry if I'm missing something obvious, but how would setting this new
> debbugs user option be different from setting the existing Gnus user
> options?  In other words, why can't users who want a Lars-esque workflow
> (Larsflow?) just set the gnus-* user options themselves?  Wouldn't the
> proposed debbugs user option be redundant?

IIUC, Lars doesn't set these variables in his .emacs permanently. He
needs them *only* in case of debbug-gnu, when a gnus-ephemeral group is
created. The proposed variable does this for him.

Otherwise, he would need to wrap the debbugs-gnu commands by own ones.

> Thanks,

Best regards, Michael.





^ permalink raw reply	[flat|nested] 13+ messages in thread

* bug#34976: [debbugs.el] debbugs-read-emacs-bug-with-gnus sets user options
  2019-03-25 18:25           ` Michael Albinus
@ 2019-03-25 18:41             ` Basil L. Contovounesios
  2019-03-25 18:55               ` Michael Albinus
  0 siblings, 1 reply; 13+ messages in thread
From: Basil L. Contovounesios @ 2019-03-25 18:41 UTC (permalink / raw)
  To: Michael Albinus; +Cc: Lars Ingebrigtsen, noam postavsky, 34976

Michael Albinus <michael.albinus@gmx.de> writes:

> "Basil L. Contovounesios" <contovob@tcd.ie> writes:
>
>> Sorry if I'm missing something obvious, but how would setting this new
>> debbugs user option be different from setting the existing Gnus user
>> options?  In other words, why can't users who want a Lars-esque workflow
>> (Larsflow?) just set the gnus-* user options themselves?  Wouldn't the
>> proposed debbugs user option be redundant?
>
> IIUC, Lars doesn't set these variables in his .emacs permanently. He
> needs them *only* in case of debbug-gnu, when a gnus-ephemeral group is
> created. The proposed variable does this for him.
>
> Otherwise, he would need to wrap the debbugs-gnu commands by own ones.

Thank you for clarifying.

I still don't see how the proposed user option would save Lars in that
case.  When Debbugs sets the gnus-* variables, these changes are not
isolated to Debbugs ephemeral groups, but affect Gnus globally.  One
would have to use different Emacs instances for each of Debbugs and Gnus
in order for these settings to not interfere with one another.  Right?

So, if one wants to suppress and persist duplicates in Debbugs but not
in Gnus, then either Gnus duplicate suppression has to become more
granular, or Debbugs has to implement its own duplicate suppression.

Or am I missing something?

-- 
Basil





^ permalink raw reply	[flat|nested] 13+ messages in thread

* bug#34976: [debbugs.el] debbugs-read-emacs-bug-with-gnus sets user options
  2019-03-25 18:41             ` Basil L. Contovounesios
@ 2019-03-25 18:55               ` Michael Albinus
  0 siblings, 0 replies; 13+ messages in thread
From: Michael Albinus @ 2019-03-25 18:55 UTC (permalink / raw)
  To: Basil L. Contovounesios; +Cc: Lars Ingebrigtsen, noam postavsky, 34976

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

Hi Basil,

> I still don't see how the proposed user option would save Lars in that
> case.  When Debbugs sets the gnus-* variables, these changes are not
> isolated to Debbugs ephemeral groups, but affect Gnus globally.  One
> would have to use different Emacs instances for each of Debbugs and Gnus
> in order for these settings to not interfere with one another.  Right?

For gnus-suppress-duplicates you are right. I would change the global
setting into a local let-bind.

gnus-save-duplicate-list has effect only when Gnus is exited. I
understand it such a way, that Lars wants to save the list of such
duplicate entries from the gnus-ephemeral group created by
debbugs. Using Gnus outside debbugs doesn't need this setting. So it
makes sense to set gnus-save-duplicate-list globally, for Lars.

Best regards, Michael.





^ permalink raw reply	[flat|nested] 13+ messages in thread

* bug#34976: [debbugs.el] debbugs-read-emacs-bug-with-gnus sets user options
  2019-03-25 17:48       ` Lars Ingebrigtsen
  2019-03-25 18:14         ` Basil L. Contovounesios
@ 2019-03-26 15:56         ` Michael Albinus
  2019-03-26 16:16           ` Lars Ingebrigtsen
  2019-03-27  3:56           ` Basil L. Contovounesios
  1 sibling, 2 replies; 13+ messages in thread
From: Michael Albinus @ 2019-03-26 15:56 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: Basil L. Contovounesios, noam postavsky, 34976-done

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Michael Albinus <michael.albinus@gmx.de> writes:
>
>> That's why I thought we could add a user option debbugs-lars-workflow or
>> alike :-) If non-nil, the gnus-* variables would be set as of today.
>
> :-)
>
> Sounds good.

I've fixed it this way. Lars, you shall set debbugs-gnu-lars-workflow to
a non-nil value.

Closing the bug.

Best regards, Michael.





^ permalink raw reply	[flat|nested] 13+ messages in thread

* bug#34976: [debbugs.el] debbugs-read-emacs-bug-with-gnus sets user options
  2019-03-26 15:56         ` Michael Albinus
@ 2019-03-26 16:16           ` Lars Ingebrigtsen
  2019-03-26 16:21             ` Michael Albinus
  2019-03-27  3:56           ` Basil L. Contovounesios
  1 sibling, 1 reply; 13+ messages in thread
From: Lars Ingebrigtsen @ 2019-03-26 16:16 UTC (permalink / raw)
  To: Michael Albinus; +Cc: Basil L. Contovounesios, noam postavsky, 34976-done

Michael Albinus <michael.albinus@gmx.de> writes:

> I've fixed it this way. Lars, you shall set debbugs-gnu-lars-workflow to
> a non-nil value.

Perhaps change the name to something a bit more generic?  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 13+ messages in thread

* bug#34976: [debbugs.el] debbugs-read-emacs-bug-with-gnus sets user options
  2019-03-26 16:16           ` Lars Ingebrigtsen
@ 2019-03-26 16:21             ` Michael Albinus
  0 siblings, 0 replies; 13+ messages in thread
From: Michael Albinus @ 2019-03-26 16:21 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: Basil L. Contovounesios, noam postavsky, 34976

Lars Ingebrigtsen <larsi@gnus.org> writes:

>> I've fixed it this way. Lars, you shall set debbugs-gnu-lars-workflow to
>> a non-nil value.
>
> Perhaps change the name to something a bit more generic?  :-)

I've thought about, but I'm bad in finding names. So I let it to you.

Best regards, Michael.





^ permalink raw reply	[flat|nested] 13+ messages in thread

* bug#34976: [debbugs.el] debbugs-read-emacs-bug-with-gnus sets user options
  2019-03-26 15:56         ` Michael Albinus
  2019-03-26 16:16           ` Lars Ingebrigtsen
@ 2019-03-27  3:56           ` Basil L. Contovounesios
  1 sibling, 0 replies; 13+ messages in thread
From: Basil L. Contovounesios @ 2019-03-27  3:56 UTC (permalink / raw)
  To: Michael Albinus; +Cc: Lars Ingebrigtsen, noam postavsky, 34976

Michael Albinus <michael.albinus@gmx.de> writes:

> Lars Ingebrigtsen <larsi@gnus.org> writes:
>
>> Michael Albinus <michael.albinus@gmx.de> writes:
>>
>>> That's why I thought we could add a user option debbugs-lars-workflow or
>>> alike :-) If non-nil, the gnus-* variables would be set as of today.
>>
>> :-)
>>
>> Sounds good.
>
> I've fixed it this way. Lars, you shall set debbugs-gnu-lars-workflow to
> a non-nil value.
>
> Closing the bug.

Thanks!

-- 
Basil





^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2019-03-27  3:56 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-24 15:32 bug#34976: [debbugs.el] debbugs-read-emacs-bug-with-gnus sets user options Basil L. Contovounesios
2019-03-25 16:45 ` Michael Albinus
2019-03-25 17:40   ` Lars Ingebrigtsen
2019-03-25 17:46     ` Michael Albinus
2019-03-25 17:48       ` Lars Ingebrigtsen
2019-03-25 18:14         ` Basil L. Contovounesios
2019-03-25 18:25           ` Michael Albinus
2019-03-25 18:41             ` Basil L. Contovounesios
2019-03-25 18:55               ` Michael Albinus
2019-03-26 15:56         ` Michael Albinus
2019-03-26 16:16           ` Lars Ingebrigtsen
2019-03-26 16:21             ` Michael Albinus
2019-03-27  3:56           ` Basil L. Contovounesios

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).