From: Michael Heerdegen <michael_heerdegen@web.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Po Lu <luangruo@yahoo.com>, 61307@debbugs.gnu.org
Subject: bug#61307: 30.0.50; pixel-scroll-precision-mode: window-scroll-functions?
Date: Sun, 19 Feb 2023 06:50:29 +0100 [thread overview]
Message-ID: <87ttzifbkq.fsf@web.de> (raw)
In-Reply-To: <83edqq81f0.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 16 Feb 2023 10:22:43 +0200")
[-- Attachment #1: Type: text/plain, Size: 390 bytes --]
Eli Zaretskii <eliz@gnu.org> writes:
> I'm not sure, but Po Lu will know.
>
> In any case, AFAIR some mice produce mouse-4 and mouse-5 events
> instead, so relying on the events' symbols might not be the best
> idea. We are supposed to know whether the device supports pixel
> precision, so maybe basing the decision on that is better?
So, would this already be good enough as a start?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: ps.diff --]
[-- Type: text/x-diff, Size: 846 bytes --]
diff --git a/lisp/pixel-scroll.el b/lisp/pixel-scroll.el
index 487144144f5..1d2d3ff10fe 100644
--- a/lisp/pixel-scroll.el
+++ b/lisp/pixel-scroll.el
@@ -714,7 +714,10 @@ pixel-scroll-precision
(let ((kin-state (pixel-scroll-kinetic-state)))
(aset kin-state 0 (make-ring 30))
(aset kin-state 1 nil))
- (pixel-scroll-precision-interpolate delta current-window))
+ (pixel-scroll-precision-interpolate delta current-window)
+ (run-hook-with-args 'window-scroll-functions
+ current-window
+ (window-start current-window)))
(condition-case nil
(progn
(if (< delta 0)
[-- Attachment #3: Type: text/plain, Size: 132 bytes --]
AFAIU, in that branch of the code we know that we are presumably dealing
with a mouse or we scrolled by a larger amount.
Michael.
next prev parent reply other threads:[~2023-02-19 5:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 1:49 bug#61307: 30.0.50; pixel-scroll-precision-mode: window-scroll-functions? Michael Heerdegen
2023-02-06 12:15 ` Eli Zaretskii
2023-02-06 21:30 ` Michael Heerdegen
2023-02-12 12:15 ` Eli Zaretskii
2023-02-13 2:20 ` Michael Heerdegen
2023-02-13 3:31 ` Eli Zaretskii
2023-02-13 3:44 ` Michael Heerdegen
2023-02-13 12:56 ` Eli Zaretskii
2023-02-14 1:30 ` Michael Heerdegen
2023-02-14 13:06 ` Eli Zaretskii
2023-02-15 4:06 ` Michael Heerdegen
2023-02-15 13:21 ` Eli Zaretskii
2023-02-16 4:57 ` Michael Heerdegen
2023-02-16 8:22 ` Eli Zaretskii
2023-02-16 8:47 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-16 8:54 ` Michael Heerdegen
2023-02-19 5:50 ` Michael Heerdegen [this message]
2023-02-19 6:54 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-19 7:36 ` Michael Heerdegen
2023-02-19 8:30 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-06 14:07 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-06 15:25 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttzifbkq.fsf@web.de \
--to=michael_heerdegen@web.de \
--cc=61307@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).